Marie
c7aa59491b
Fixes https://github.com/twentyhq/private-issues/issues/362 **How to reproduce** Link a person that has a duplicate to an opportunity. (you can create a duplicate by giving two people the same linkedin link). Open the opportunity record from opportunity table. Click on the related person (in "Point of contact"). In front of "Duplicates", click on the merge button (two arrows becoming one). You should here see an empty "Merge preview" and an error when clicking "First" tab. **Issue** The issue is that CommandMenuMergeRecordPage is getting the referenced objectMetadataItem from useContextStoreObjectMetadataItemOrThrow without an instance id. contextStoreObjectMetadataItem is still "opportunity" as it should be, being on an opportunity view. So further down it attempts to display the record page according the label identifier field from opportunity, which is a text field, "name", and it breaks because the record is actually a person for who the "name" field is not a text but a full_name type. **Fix** I suggested a fix that offers the possibility to find the referenced objectMetadataItem from the MergeRecords instanceId. But I still gave flexibility to avoid having to set that state everytime we open the merge tab, by falling back to the default contextStoreObjectMetadataItem. (this is used when we merge records from ticking two records from a view and open the command menu). Im not sure this is the best option. Open to suggestions ! --------- Co-authored-by: Charles Bochet <charles@twenty.com>
The #1 Open-Source CRM
🌐 Website · 📚 Documentation · 
Roadmap · 
Discord · 
Figma
Installation
See: 🚀 Self-hosting 🖥️ Local Setup
Does the world need another CRM?
We built Twenty for three reasons:
CRMs are too expensive, and users are trapped. Companies use locked-in customer data to hike prices. It shouldn't be that way.
A fresh start is required to build a better experience. We can learn from past mistakes and craft a cohesive experience inspired by new UX patterns from tools like Notion, Airtable or Linear.
We believe in Open-source and community. Hundreds of developers are already building Twenty together. Once we have plugin capabilities, a whole ecosystem will grow around it.
What You Can Do With Twenty
Please feel free to flag any specific needs you have by creating an issue.
Below are a few features we have implemented to date:
- Personalize layouts with filters, sort, group by, kanban and table views
- Customize your objects and fields
- Create and manage permissions with custom roles
- Automate workflow with triggers and actions
- Emails, calendar events, files, and more
Personalize layouts with filters, sort, group by, kanban and table views
Customize your objects and fields
Create and manage permissions with custom roles
Automate workflow with triggers and actions
Emails, calendar events, files, and more
Stack
- TypeScript
- Nx
- NestJS, with BullMQ, PostgreSQL, Redis
- React, with Recoil, Emotion and Lingui
Thanks
Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).
Join the Community
- Star the repo
- Subscribe to releases (watch -> custom -> releases)
- Follow us on Twitter or LinkedIn
- Join our Discord
- Improve translations on Crowdin
- Contributions are, of course, most welcome!