BugIsGod
68f5e70ade
Fixes: #18943 ## Problem Two bugs related to the Files field: 1. **File loss on click outside**: When `MultiItemFieldInput` was not in edit mode (input hidden), clicking outside would still call `validateInputAndComputeUpdatedItems()` with an empty `inputValue` and `itemToEditIndex = 0`, causing the first file to be silently deleted. <img width="624" height="332" alt="image" src="https://github.com/user-attachments/assets/657aff2c-e497-4685-b8b7-fa22aba772f8" /> 2. **Unsigned file URLs in timeline activity**: FileId, FileName stored in `timelineActivity.properties.diff` (before/after values) were not being signed (timeActivity.properties is stored as json in database), making them inaccessible from the frontend. <img width="1092" height="103" alt="image" src="https://github.com/user-attachments/assets/23d83ea3-4eb9-41ef-a99c-c4515d1cfb35" /> ## Reproduction https://github.com/user-attachments/assets/e75b842b-5cbb-46e8-a923-ac9df62deb98 ## Changes - `MultiItemFieldInput.tsx`: Wrap the validate + onChange logic in `if (isInputDisplayed)` so it only runs when the input is actually open. - `timeline-activity-query-result-getter.handler.ts`: New handler that iterates over `properties.diff` fields and signs any file arrays found in `before`/`after` values (call same method: `fileUrlService.signFileByIdUrl` as table field view `FilesFieldQueryResultGetterHandler`. - `common-result-getters.service.ts`: Register the new handler for `timelineActivity`. ## After https://github.com/user-attachments/assets/368c7be1-3101-43a2-ac93-fe1b0d8a7a37
The #1 Open-Source CRM
🌐 Website · 📚 Documentation · 
Roadmap · 
Discord · 
Figma
Installation
See: 🚀 Self-hosting 🖥️ Local Setup
Why Twenty
We built Twenty for three reasons:
CRMs are too expensive, and users are trapped. Companies use locked-in customer data to hike prices. It shouldn't be that way.
A fresh start is required to build a better experience. We can learn from past mistakes and craft a cohesive experience inspired by new UX patterns from tools like Notion, Airtable or Linear.
We believe in open-source and community. Hundreds of developers are already building Twenty together. Once we have plugin capabilities, a whole ecosystem will grow around it.
What You Can Do With Twenty
Please feel free to flag any specific needs you have by creating an issue.
Below are a few features we have implemented to date:
- Personalize layouts with filters, sort, group by, kanban and table views
- Customize your objects and fields
- Create and manage permissions with custom roles
- Automate workflow with triggers and actions
- Emails, calendar events, files, and more
Personalize layouts with filters, sort, group by, kanban and table views
Customize your objects and fields
Create and manage permissions with custom roles
Automate workflow with triggers and actions
Emails, calendar events, files, and more
Stack
- TypeScript
- Nx
- NestJS, with BullMQ, PostgreSQL, Redis
- React, with Jotai, Linaria and Lingui
Thanks
Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).
Join the Community
- Star the repo
- Subscribe to releases (watch -> custom -> releases)
- Follow us on Twitter or LinkedIn
- Join our Discord
- Improve translations on Crowdin
- Contributions are, of course, most welcome!