Amlan Kumar Nandy
49aac04b84
## Summary After uploading an image/file to the empty avatar field in the person tab, the edit icon next to the field would not appear until the browser was refreshed or another field was clicked. ### Root cause - When user clicks over the avatar field, `recordFieldListCellEditModePosition` is set to `globalIndex` - That is fine when a avatar already exists. But when there is no avatar already set, the native file picker is opened with no `onClose` handler attached. - So after the file upload is completed, `recordFieldListCellEditModePosition` is never reset to null. - `FieldsWidgetCellEditModePortal` stays anchored to the avatar file element - When the user hovers over the same field again, its hover portal tries to compete to anchor for the same element - So, `RecordInlineCellDisplayMode ` (the edit button) doesn't render ### Fix - Pass the `onClose` function through `openFieldInput` to `openFilesFieldInput` - `onClose` resets `recordFieldListCellEditModePosition` back to null, when the upload completes. ## Before https://github.com/user-attachments/assets/ac9318e9-5471-434c-8af3-5c20d0112460 ## After https://github.com/user-attachments/assets/0d064a7f-95ad-4b92-a9ee-d9570f360972 Fixes #19595 --------- Co-authored-by: Charles Bochet <charles@twenty.com>
The #1 Open-Source CRM
🌐 Website · 📚 Documentation · 
Roadmap · 
Discord · 
Figma
Installation
See: 🚀 Self-hosting 🖥️ Local Setup
Why Twenty
We built Twenty for three reasons:
CRMs are too expensive, and users are trapped. Companies use locked-in customer data to hike prices. It shouldn't be that way.
A fresh start is required to build a better experience. We can learn from past mistakes and craft a cohesive experience inspired by new UX patterns from tools like Notion, Airtable or Linear.
We believe in open-source and community. Hundreds of developers are already building Twenty together. Once we have plugin capabilities, a whole ecosystem will grow around it.
What You Can Do With Twenty
Please feel free to flag any specific needs you have by creating an issue.
Below are a few features we have implemented to date:
- Personalize layouts with filters, sort, group by, kanban and table views
- Customize your objects and fields
- Create and manage permissions with custom roles
- Automate workflow with triggers and actions
- Emails, calendar events, files, and more
Personalize layouts with filters, sort, group by, kanban and table views
Customize your objects and fields
Create and manage permissions with custom roles
Automate workflow with triggers and actions
Emails, calendar events, files, and more
Stack
- TypeScript
- Nx
- NestJS, with BullMQ, PostgreSQL, Redis
- React, with Jotai, Linaria and Lingui
Thanks
Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).
Join the Community
- Star the repo
- Subscribe to releases (watch -> custom -> releases)
- Follow us on Twitter or LinkedIn
- Join our Discord
- Improve translations on Crowdin
- Contributions are, of course, most welcome!