061cc897af
This PR is a first step for improving the performance on boards and table with groups. It is related to : https://github.com/twentyhq/core-team-issues/issues/1870 Here we implement only a groupBy query for aggregate values in the group section. This also allows to improve the DX of aggregate computing and group by query creation and parsing. ## Demo Main : https://github.com/user-attachments/assets/5d2a8077-5322-4928-a551-f03583bcfb87 This PR : https://github.com/user-attachments/assets/d0e82b28-72c3-40f0-b5cb-045f1a736ffb ## Aggregate update bug fix This PR also solves a bug with aggregate update that was already present on main. The bug is linked to core views not being updated properly during a modification of the aggregate operation on a view. We should probably improve the view lifecycle and state management because it is a bit too complex right now. Main : https://github.com/user-attachments/assets/10dbfb8b-dfa0-4f21-8698-d222871a43e7 This PR : https://github.com/user-attachments/assets/bac41890-5191-4e4c-b82b-19b1039e9ab5 ## Miscellaneous - Fixed optimistic rendering of group by queries, when adding a new record, the aggregate recomputes well. ## TODO - We might want to improve the optimistic for group by queries that don't have records nor more than one dimension.
99 lines
3.6 KiB
TypeScript
99 lines
3.6 KiB
TypeScript
import { useDeleteOneFieldMetadataItemMutation } from '~/generated-metadata/graphql';
|
|
|
|
import { MAIN_CONTEXT_STORE_INSTANCE_ID } from '@/context-store/constants/MainContextStoreInstanceId';
|
|
import { useMetadataErrorHandler } from '@/metadata-error-handler/hooks/useMetadataErrorHandler';
|
|
import { useRefreshObjectMetadataItems } from '@/object-metadata/hooks/useRefreshObjectMetadataItems';
|
|
import { type MetadataRequestResult } from '@/object-metadata/types/MetadataRequestResult.type';
|
|
import { recordIndexGroupAggregateFieldMetadataItemComponentState } from '@/object-record/record-index/states/recordIndexGroupAggregateFieldMetadataItemComponentState';
|
|
import { recordIndexGroupAggregateOperationComponentState } from '@/object-record/record-index/states/recordIndexGroupAggregateOperationComponentState';
|
|
import { AggregateOperations } from '@/object-record/record-table/constants/AggregateOperations';
|
|
import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
|
|
import { useRecoilComponentState } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentState';
|
|
import { useSetRecoilComponentState } from '@/ui/utilities/state/component-state/hooks/useSetRecoilComponentState';
|
|
import { useRefreshCoreViewsByObjectMetadataId } from '@/views/hooks/useRefreshCoreViewsByObjectMetadataId';
|
|
import { ApolloError } from '@apollo/client';
|
|
import { t } from '@lingui/core/macro';
|
|
|
|
export const useDeleteOneFieldMetadataItem = () => {
|
|
const [deleteOneFieldMetadataItemMutation] =
|
|
useDeleteOneFieldMetadataItemMutation();
|
|
|
|
const { refreshObjectMetadataItems } =
|
|
useRefreshObjectMetadataItems('network-only');
|
|
const { refreshCoreViewsByObjectMetadataId } =
|
|
useRefreshCoreViewsByObjectMetadataId();
|
|
|
|
const { handleMetadataError } = useMetadataErrorHandler();
|
|
const { enqueueErrorSnackBar } = useSnackBar();
|
|
|
|
const setRecordIndexGroupAggregateOperation = useSetRecoilComponentState(
|
|
recordIndexGroupAggregateOperationComponentState,
|
|
MAIN_CONTEXT_STORE_INSTANCE_ID,
|
|
);
|
|
|
|
const [
|
|
recordIndexGroupAggregateFieldMetadataItem,
|
|
setRecordIndexGroupAggregateFieldMetadataItem,
|
|
] = useRecoilComponentState(
|
|
recordIndexGroupAggregateFieldMetadataItemComponentState,
|
|
MAIN_CONTEXT_STORE_INSTANCE_ID,
|
|
);
|
|
|
|
const resetRecordIndexKanbanAggregateOperation = async (
|
|
idToDelete: string,
|
|
) => {
|
|
if (recordIndexGroupAggregateFieldMetadataItem?.id === idToDelete) {
|
|
setRecordIndexGroupAggregateOperation(AggregateOperations.COUNT);
|
|
setRecordIndexGroupAggregateFieldMetadataItem(null);
|
|
}
|
|
};
|
|
|
|
const deleteOneFieldMetadataItem = async ({
|
|
idToDelete,
|
|
objectMetadataId,
|
|
}: {
|
|
idToDelete: string;
|
|
objectMetadataId: string;
|
|
}): Promise<
|
|
MetadataRequestResult<
|
|
Awaited<ReturnType<typeof deleteOneFieldMetadataItemMutation>>
|
|
>
|
|
> => {
|
|
try {
|
|
const response = await deleteOneFieldMetadataItemMutation({
|
|
variables: {
|
|
idToDelete,
|
|
},
|
|
});
|
|
|
|
// TODO: see if we can remove this lin altogether
|
|
await resetRecordIndexKanbanAggregateOperation(idToDelete);
|
|
|
|
await refreshObjectMetadataItems();
|
|
await refreshCoreViewsByObjectMetadataId(objectMetadataId);
|
|
|
|
return {
|
|
status: 'successful',
|
|
response,
|
|
};
|
|
} catch (error) {
|
|
if (error instanceof ApolloError) {
|
|
handleMetadataError(error, {
|
|
primaryMetadataName: 'fieldMetadata',
|
|
});
|
|
} else {
|
|
enqueueErrorSnackBar({ message: t`An error occurred.` });
|
|
}
|
|
|
|
return {
|
|
status: 'failed',
|
|
error,
|
|
};
|
|
}
|
|
};
|
|
|
|
return {
|
|
deleteOneFieldMetadataItem,
|
|
};
|
|
};
|