twenty

Author	SHA1	Message	Date
Parship Chowdhury	c635a191bf	fix: uneven spacing in date picker calendar grid (#21881 ) ### Summary While working on #19739, I found that in the date filter calendar dropdown, day cells and highlighted dates looked misaligned i.e. tighter on the right side. The solution is to apply a uniform margin in `DatePicker.tsx` and `DateTimePicker.tsx`. ### Before: <img width="377" height="436" alt="Screenshot 2026-06-20 021856" src="https://github.com/user-attachments/assets/4ef62a48-6b99-4647-95f6-bd39f43eaa26" /> <img width="442" height="518" alt="Screenshot 2026-06-20 021932" src="https://github.com/user-attachments/assets/e6e1e8f8-257a-41e5-825f-bd2fe91e372a" /> ### After: <img width="346" height="380" alt="Screenshot 2026-06-20 021813" src="https://github.com/user-attachments/assets/5fdd03fe-e61b-4fec-a0f3-f6ac4ee9effb" /> <img width="322" height="457" alt="Screenshot 2026-06-20 022013" src="https://github.com/user-attachments/assets/a33c6439-f2d5-43e7-a043-f9cf4fec770a" /> <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21881?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> --------- Signed-off-by: Parship Chowdhury <parshipchowdhury@gmail.com> Co-authored-by: Charles Bochet <charles@twenty.com>	2026-06-26 07:51:37 +02:00
Aleksa Jankovic	0b31d2a6a0	fix(front): wrap long note/markdown text on mobile browsers (#21909 ) Fixes #21929 ### Issue When viewing/reading a note's body (BlockNote rich-text / markdown content) on Android, long text overflows horizontally off the viewport in Chrome and Firefox, while it wraps correctly on iOS Safari. ### Root cause The note body is rendered by the BlockNote editor (`StyledEditor` in `BlockEditor.tsx`). The block/inline content had no `overflow-wrap`, and the flex-based `.bn-block-content` had no `min-width` constraint. WebKit (iOS Safari) breaks the content, but Blink (Android Chrome) and Gecko (Android Firefox) keep the intrinsic min-content width of the flex children, so the container expands past the viewport instead of wrapping. ### Fix Add wrapping/sizing rules to the editor container so text breaks and wraps consistently across browsers, without changing the desktop layout: - `overflow-wrap: anywhere` on `.bn-block-content` / `.bn-inline-content` — unlike `break-word`, this reduces the min-content size so flex children can actually shrink. - `min-width: 0` on `.bn-block-content` and on the editor wrapper, plus `max-width: 100%` on the wrapper. ### Test plan - Open a Note containing a very long word / URL or a long paragraph. - Android Chrome & Firefox: text now wraps within the viewport (no horizontal overflow). - iOS Safari: unchanged (still wraps). - Desktop: layout unchanged. ### Screenshots Android <img width="1080" height="1949" alt="Screenshot_20260620_231356_Chrome(1)" src="https://github.com/user-attachments/assets/bb1e38cf-198a-4ded-9dde-e0a26e637ed8" /> iPhone <img width="686" height="1280" alt="IMG_20260620_231841_096" src="https://github.com/user-attachments/assets/9cee7557-bb69-453d-bea4-a5c37de220af" /> --- ### ✅ Verified on a real Android device Reproduced and validated on a Samsung Galaxy A71 (Android, Chrome / Blink) using the exact note show-page DOM/CSS chain (`ScrollWrapper` → full-width container → `StyledEditor` → `.bn-mantine` `container-type: inline-size` → flex `.bn-block-content` → ProseMirror `word-wrap: break-word`): - Without the fix: a long unbreakable string stays on one line and overflows horizontally off the viewport (`scrollWidth ≈ 1336px` in a ~360px viewport, with a horizontal scrollbar) — matching the reported bug. - With the fix: the same string wraps within the viewport. Notably this does not reproduce on desktop Chromium — only on the mobile engine — which matches the original report (Android Chrome/Firefox broken, iOS Safari fine). The flex `.bn-block-content` (`min-width: auto`) resolves to the unbreakable token's intrinsic width on Android Blink; `min-width: 0` + `overflow-wrap: anywhere` lets it shrink and wrap. Screenshot <img width="1080" height="2400" alt="image" src="https://github.com/user-attachments/assets/827dc579-4b1e-43ea-8b28-0ca781b12d88" />	2026-06-25 16:49:11 +02:00
nitin	f86bf637d1	[BREAKING CHANGE] remove call recording feature flag and backfill upgrade command for existing command menu items navigation command (#22176 ) <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22176?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-25 19:43:36 +05:30
Akash!	87329c8810	fix(ask-ai): resolve stream subscription race condition on new thread… (#21916 ) ## Description Resolves a race condition in the Ask AI feature where the first assistant reply in a newly created thread does not stream into the UI and only appears after sending a second message. ### What's Changed - Immediate Thread Subscription: Updated `useAgentChat.ts` to immediately set `currentAiChatThread` to the newly generated `threadId` instead of deferring it until after the `SEND_CHAT_MESSAGE` mutation finishes. - The Bug: Previously, the backend worker processed the AI chat job so quickly that the stream completed and fired the `message-persisted` event before the frontend established the SSE subscription. - The Fix: By setting the thread ID immediately, the `useAgentChatSubscription` hook now properly connects and listens to the SSE stream before the backend begins emitting chunks, guaranteeing the first message streams seamlessly. ### How to Test 1. Open the Ask AI panel and start a completely new thread. 2. Send an initial message (e.g., "Hello!"). 3. Observe that the AI's response successfully streams into the chat without needing a workaround or page refresh. Closes #21694 --------- Co-authored-by: Etienne <45695613+etiennejouan@users.noreply.github.com>	2026-06-25 15:41:56 +02:00
Weiko	864ea452b4	fix mobile side panel close (#22169 ) The side panel close (X) button was hidden on all mobile views, while the back button only renders when there is navigation history. When the side panel is opened at the root (e.g. viewing a record directly with a single-item navigation stack), neither button was shown, leaving no way to dismiss the panel on mobile. Keep the close button available on mobile whenever there is no back button to fall back on, so the panel is always dismissable. ## Before https://github.com/user-attachments/assets/61891d25-26b8-4ba4-8b05-73fd44f92d89 ## After https://github.com/user-attachments/assets/41342722-bcaf-420b-83bb-3cafaec49516	2026-06-25 14:55:04 +02:00
Charles Bochet	d8cb4aa15b	fix(filter): resolve filter-derived date defaults with Temporal (fixes create/update crash in date-filtered views) (#22124 ) ## Symptom Creating or updating an Opportunity on a board view crashes with: ``` Uncaught TypeError: e.split is not a function at splitDateString (date-fns) → parseISO → isMatchingDateFilter → isRecordMatchingFilter → <group-by optimistic effect> → createOneRecord ``` `e` is a non-string (a `Date` object, shown as `{}` in the debugger). Distinct from the `null` case fixed in #22029. ## Root cause Reproduced on a live board filtered by Close date — Is relative — "This quarter" (a `DATE_TIME` field). When you create a record in a filtered view, `useCreateNewIndexRecord` derives default field values from the view's filters via `buildRecordInputFromFilter` → `buildValueFromFilter`. For a date field, `computeValueFromFilterDate` returned a JS `Date` object (`new Date()` / `new Date(value)`), assigned to the new record verbatim. The optimistic record's `closeDate` was then a `Date`, not an ISO string, and the group-by optimistic effect matched it via `parseISO(dateObject)` → `dateString.split is not a function`, crashing every create/update in the view. ## Fix `computeValueFromFilterDate` now returns timezone-aware ISO strings via Temporal, mirroring what `turnRecordFilterIntoGqlOperationFilter` produces for the same filters — so a record created in a date-filtered view actually satisfies its own filter: - `DATE_TIME` → an instant. Date-only filter values (a `DATE_TIME` "is" filter stores `yyyy-MM-dd`, no time) are resolved to the start of day in the user's time zone, matching how the filter operands are built — `Temporal.Instant.from()` alone would `RangeError` on them. - `DATE` → a plain date `yyyy-MM-dd` resolved in the user's time zone (`Temporal.Now.plainDateISO(timeZone)`). A bare `new Date().toISOString()` would use the UTC date, which near midnight is the wrong calendar day for non-UTC users, so the new record could miss its own `IS_TODAY`/relative filter. The time zone is threaded from `useUserTimezone` (same source the filter side uses). - `IS_BEFORE` subtracts 1 day for `DATE` / 1 minute for `DATE_TIME` (the `-1 minute` special-case moved out of `buildRecordInputFromFilter`, which now just assigns the string). No `Date` object ever reaches `parseISO`, and the value matches the filter operand, so the optimistic card lands in the right place. ## Tests - `buildValueFromFilter.spec.ts`: every date operator returns an ISO string (round-tripped to the expected instant); a `DATE` block asserts date-only `yyyy-MM-dd` output and that `IS_TODAY` resolves to the correct calendar day per time zone at a UTC day boundary (`2024-03-20` UTC vs `2024-03-21` Asia/Tokyo); a date-only `DATE_TIME` `IS` value resolves to start-of-day in the user time zone (UTC vs America/New_York) without throwing. - `buildRecordInputFromFilter.test.ts`: filter-derived date values are ISO strings, not `Date` objects. ## Verified locally (Chrome) Reproduced the exact prod scenario on the By Stage Opportunities Kanban board (the group-by optimistic effect) with a Close date — Is relative filter: - Created a card in a column → no `split is not a function` crash; the card got a valid Close date (`now` for the relative filter, e.g. `25 Jun 2026 13:10`). Console clean. - Also verified a table view + Close date — Is filter: created record gets a valid start-of-day value (`25 Jun 2026 00:00`). Both `IS_RELATIVE` (→ now instant) and the date-only `IS` (→ start-of-day in the user tz) paths produce string values that the optimistic matcher handles without throwing.	2026-06-25 14:51:42 +02:00
Thomas des Francs	2aeacf341f	Flatten system object pickers (#22161 ) ## Summary - Flatten system object entries into the first-level workflow object pickers. - Flatten dashboard Source and record-page Field picker advanced/system entries into the main searchable list. - Keep regular entries first, place system/advanced entries at the bottom, and cap page-layout picker height at 340px. - Add keyboard selection support to workflow object pickers through `SelectableList`. ## Review notes - Removed now-unused Advanced submenu state, submenu headers, and duplicated filtering paths. - Kept the width behavior scoped to each existing dropdown; the shared page-layout wrapper only controls height/scrolling. - No blocking issues found in the final reviewed diff. ## Screenshots ### Workflow record type picker \| Before \| After \| \| --- \| --- \| \| <img src="https://gist.githubusercontent.com/Bonapara/d2b6754b3f1927b3d755b5f260e8b12f/raw/dc3f7ef933bdca6c39599c45c827db0f27f01e7d/before-workflow-record-type-advanced.png" width="320" /> \| <img src="https://gist.githubusercontent.com/Bonapara/d2b6754b3f1927b3d755b5f260e8b12f/raw/2ee195a8562e13d0f4307e7891ab60cfaecae8cf/after-workflow-record-type-flat.png" width="320" /> \| ### Dashboard Source picker \| Before \| After \| \| --- \| --- \| \| <img src="https://gist.githubusercontent.com/Bonapara/d2b6754b3f1927b3d755b5f260e8b12f/raw/45f57728ec7643c7048e857829e977d49b9b365c/before-dashboard-source-tall.png" width="420" /> \| <img src="https://gist.githubusercontent.com/Bonapara/d2b6754b3f1927b3d755b5f260e8b12f/raw/f8b864ea5e3d04a00b9b6a613e8bf97dd545933c/after-dashboard-source-340px.png" width="420" /> \| ### Record page Field picker \| Before \| After \| \| --- \| --- \| \| <img src="https://gist.githubusercontent.com/Bonapara/d2b6754b3f1927b3d755b5f260e8b12f/raw/ea5f14ccac6c0d9b3d953b4047dc7491702f756a/before-record-field-advanced.png" width="320" /> \| <img src="https://gist.githubusercontent.com/Bonapara/d2b6754b3f1927b3d755b5f260e8b12f/raw/9d0717cf3cfcb47ed17d595ba83b19a37718c3eb/after-record-field-flat.png" width="320" /> \| ## Checks - `npx oxfmt --check` on touched files - `git diff --check` - `npx tsc -p tsconfig.json --noEmit --pretty false --noErrorTruncation \| rg "(ChartDataSourceDropdownContent\|FieldWidgetFieldDropdownContent\|PageLayoutDropdownContentContainer\|WorkflowObjectDropdownContent\|WorkflowEditTriggerDatabaseEventForm\|WorkflowEditActionFindRecords\|WorkflowEditActionPickRecord\|ChartSettingItem)"` returned no touched-file diagnostics - Browser verification: dashboard Source top/bottom, record-page Field top/bottom, workflow Record Type top/bottom, and ArrowDown selection in workflow Record Type menu <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22161?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-25 14:10:30 +02:00
Abdul Rahman	db5338cf32	Feat: group records by many to one relation (#22123 ) ## Group records by relation (Kanban + Table) Adds grouping by `MANY_TO_ONE` relation fields on both board and table views, reusing the existing `ViewGroup` storage (`fieldValue = related record id`). - New group record picker to create relation-backed groups (board column + table row) - Relation-aware group headers (name/avatar), filtering, and drag-drop (writes the FK join column) — all using one canonical `${name}Id` column - Sort menu hides alphabetical options when grouping by a relation (no comparable title) - A group whose backing record no longer exists renders a "Deleted" chip instead of a blank header - Backend: allow `MANY_TO_ONE` relations as the Kanban `mainGroupByField` in the flat-view validator https://github.com/user-attachments/assets/267077a6-2667-4506-b178-eee420a16f20 <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22123?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-25 13:55:50 +02:00
Emmanuel Hernández Bazán	981ee6a2d7	fix: stabilize tooltip anchor ID with useRef to prevent hover glitch (#21888 ) ## Context Tooltip components were generating a new anchor ID on every render. This caused a flicker/glitch when hovering: the tooltip would briefly disappear and reappear because React reconciled the changed ID as a different element. ## Solution Changed the anchor ID generation from inline (re-created every render) to `useRef` (stable across renders). The ID is now created once on mount and stays the same for the lifetime of the component. ## Test plan - [x] Hover over any element with a tooltip — no flicker or disappear/reappear behavior - [x] Multiple tooltips on the same page still work independently 🤖 Generated with [Claude Code](https://claude.ai/claude-code) <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21888?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> --------- Co-authored-by: Emmanuel Hernandez <emmanuel.hernandez@clickbalance.com> Co-authored-by: Charles Bochet <charles@twenty.com>	2026-06-25 13:12:11 +02:00
martmull	a20ebfa880	feat(applications): remove the application custom settings tab (#22156 ) ## Summary Removes the application custom settings tab feature. This is one half of #22059, split out so it can be reviewed/merged independently from the variable-types enrichment. ## Changes - Remove the `SettingsApplicationCustomTab` component and its tab entry/rendering in `SettingsApplicationDetails`. - Stop syncing `settingsCustomTabFrontComponent` from application manifests — `ApplicationManifestMigrationService` now only syncs the default role. - Deprecate the now-unused fields (kept for backward compatibility, no longer read or synced): - `ApplicationDTO.settingsCustomTabFrontComponentId` (GraphQL `@deprecated`) - `ApplicationManifest.settingsCustomTabFrontComponentUniversalIdentifier` - the `settingsCustomTabFrontComponentId` column comment on `ApplicationEntity` The DB column is intentionally not dropped, so existing installations upgrade cleanly.	2026-06-25 12:29:45 +02:00
Félix Malfait	5242ddf458	feat(apps): let front components open a record in the side panel (#22140 ) ## Why Front components (apps) could `navigate()` to a record's full page, but there was no way to open a specific record in the side panel. More generally, `openSidePanelPage` could navigate to a `SidePanelPages` enum page but couldn't pass the context most pages need. ## What `openSidePanelPage`'s params are now a discriminated union keyed on `page`, so each page declares its own typed payload (instead of a flat bag of optionals whose validity silently depends on `page`). This is also safer: pages that can't render without context can't be "opened" into a broken panel. Wired the param-bearing pages host-side, each bridging to its existing internal hook: \| `page` \| Params \| Bridges to \| \|---\|---\|---\| \| `ViewRecord` \| `recordId`, `objectNameSingular`, `resetNavigationStack?` \| `useOpenRecordInSidePanel` (full-page fallback on mobile / unsupported objects) \| \| `EditRichText` \| `recordId`, `objectNameSingular`, `fieldName?` \| `useOpenRichTextInSidePanel` \| \| `ComposeEmail` \| `connectedAccountId`, `threadId?`, `defaultTo?`, `defaultSubject?`, `defaultInReplyTo?`, `pageTitle?`, `pageIcon?` \| `useOpenComposeEmailInSidePanel` \| \| `ViewFrontComponent` \| `frontComponentId`, optional `recordId`+`objectNameSingular`, `pageTitle`, `pageIcon?`, `resetNavigationStack?` \| `useOpenFrontComponentInSidePanel` \| \| (any other page) \| `pageTitle`, `pageIcon?`, `shouldResetSearchState?` \| `navigateSidePanel` \| `CommandOpenSidePanelPage` now takes the union directly, so headless command-menu items can open any of these. Threaded through `twenty-sdk` → `twenty-front-component-renderer` → host (`useFrontComponentExecutionContext`), with unit tests per page and the mobile/unsupported fallbacks. ## Deliberately deferred: `MergeRecords` `useOpenMergeRecordsPageInSidePanel` takes `objectNameSingular` / `objectRecordIds` at hook-init (it calls `useObjectMetadataItem` / `useLazyFindManyRecords` at render), so it can't be driven by runtime app params without refactoring that hook + its current caller. Left out of this PR — better as its own change. ## Worth a second look (reviewers) - `ViewFrontComponent` lets an app open a front component by id. Within an app that's clean composition; whether an app should be able to target another app's component is a scoping/security question. The render still runs under the app's access token, so cross-app fetches would fail auth — but flagging it explicitly. ## Security note Side-panel record/page views render natively under the user's session/Apollo client, not the app's scoped token — RLS/field permissions are enforced as if the user opened it themselves. Same trust model as `navigate(AppPath.RecordShowPage, …)`. ## Follow-up A separate PR will centralize the mobile + `canOpenObjectInSidePanel` guard inside `useOpenRecordInSidePanel` (currently duplicated across callers, missing in others). ## Validation > [!NOTE] > Dependencies wouldn't install in this environment (flaky network during `yarn install`), so lint / typecheck / jest weren't run locally — relying on CI. The diff was reviewed manually for type-consistency, including the discriminated-union narrowing in the host switch. https://claude.ai/code/session_01AAJFXzsCeoj6BeP3ofiTKQ	2026-06-25 10:47:39 +02:00
Félix Malfait	b841b92cb5	fix(billing): widen embedded add-card modal and align its buttons (#22141 ) ## Context Follow-up to #22125. The embedded "Add your credit card" modal had two visual issues: 1. Too narrow — it used `narrowWidth` (~368px), which capped the Stripe Payment Element too tightly (cramped card fields, country dropdown, and the Google Pay / Cash App / bank-account accordions). 2. Mismatched buttons — the submit used `MainButton` (onboarding's filled CTA) while Cancel used `Button` (the settings/`ConfirmationModal` outlined style), so the two never matched. No new components or behavior — purely prop/component swaps within existing primitives. ## Changes - `AddCreditCardModal`: drop `narrowWidth`, use `size="medium"` so the Payment Element has room. - `AddPaymentMethodForm`: replace `MainButton` with `Button` (`variant="secondary"`, `accent="blue"`, `fullWidth`), using `Button`'s built-in `isLoading` spinner. Both buttons are now full-width outlined `Button`s, matching the sibling `StartSubscriptionConfirmationModal` (which renders `ConfirmationModal`'s blue-accented confirm + plain cancel). Removed the now-unused `MainButton`/`Loader` imports and `StyledButtonContainer`. ## Notes - Frontend-only; no GraphQL/schema/codegen impact. https://claude.ai/code/session_01VU7SfrSgaYWr2AhVL8DMfu --- _Generated by [Claude Code](https://claude.ai/code/session_01VU7SfrSgaYWr2AhVL8DMfu)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22141?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-25 06:52:49 +02:00
Félix Malfait	94dbcc27a9	feat(billing): embed credit card form in the add-card trial-end modal (#22125 ) ## Context When a trialing workspace (trial without a credit card) clicks Add Credit Card from the "End trial period" banner or the AI-chat usage-limit banner, the modal currently redirects the browser to Stripe's hosted billing portal to collect the card. Since we already embed the Stripe Payment Element in onboarding, this brings the same in-app experience to the trial-end modal so the whole flow stays inside Twenty. ## Why the onboarding flow couldn't be reused as-is The onboarding embed (`createSubscriptionPaymentIntent` / `SubscriptionPaymentForm`) creates a new subscription with `payment_behavior: 'default_incomplete'`. In the trial-end case the customer already has a trialing subscription, so that path throws `BILLING_SUBSCRIPTION_INVALID`. The correct primitive here is a SetupIntent against the existing customer: collect + save the card, then end the trial. A standalone SetupIntent attaches the card to the customer but does not make it the default (the Stripe portal used to do that for us), so the trial-end invoice would have no payment method. The backend now backfills the customer default before charging. ## Changes Backend - `StripeCustomerService`: `createSetupIntent()` for an existing customer, and `ensureDefaultPaymentMethod()` which sets the customer default only when none is already set (won't clobber a portal-chosen default). - `BillingPortalWorkspaceService.createPaymentMethodSetupIntent()`: returns a SetupIntent client secret for the current non-canceled subscription's customer. - `BillingSubscriptionService.endTrialPeriod()`: ensures a default payment method before `trial_end: 'now'`. - New `createBillingPaymentMethodSetupIntent` mutation + `BillingSetupIntent` DTO; SDK schema snapshot synced. Frontend - `AddPaymentMethodForm`: Stripe Elements (`mode: 'setup'`), confirms with `redirect: 'if_required'` so the common card case stays in-app; 3DS still redirects and is finished by the existing `EndTrialAfterPaymentMethodEffect`. - `AddCreditCardModal`: hosts the embedded form. - Both trial-end banners (`InformationBannerEndTrialPeriod`, `AIChatNoMoreBillingCreditsBanner`) open the embedded modal instead of redirecting when no card is on file; the AI-chat path preserves its thread context in the 3DS return URL. ## Flow 1. User clicks Add Credit Card → embedded modal opens. 2. Card entered → `createBillingPaymentMethodSetupIntent` → `confirmSetup({ redirect: 'if_required' })`. 3. Non-3DS: confirms inline → `endSubscriptionTrialPeriod` → subscription active, no redirect. 4. 3DS: redirects to `?startSubscriptionAfterPaymentMethod=true` → existing effect finishes activation. 5. Self-hosted instances without a Stripe publishable key fall back to the existing portal redirect (the form renders an unavailable state). ## Notes for reviewers - The metadata GraphQL types were regenerated by hand (codegen needs a live `/metadata` server, which wasn't available in the authoring environment); a `graphql:generate --configuration=metadata` run against a live backend should be a no-op. - Local `typecheck`/`lint` could not be run in the authoring environment (dependency install was blocked); relying on CI to validate. - Scope is intentionally limited to the two trial-end banner modals. The Settings → Billing "update payment method" link still uses the Stripe portal. https://claude.ai/code/session_01VU7SfrSgaYWr2AhVL8DMfu --- _Generated by [Claude Code](https://claude.ai/code/session_01VU7SfrSgaYWr2AhVL8DMfu)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22125?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-25 04:49:31 +02:00
Félix Malfait	179ab2f066	feat(billing): clarify subscription, credits, and add-credits sections (#22126 ) ## What & why Redesigns the content of the workspace billing settings page so the numbers that matter are surfaced clearly. Strictly reuses existing design-system components — no new UI primitives, no color/font changes, same section structure. All pricing values are pulled from the pricing config (nothing hardcoded). ## Changes Subscription card (`SettingsBillingSubscriptionInfo.tsx`) - Seats row shows per-seat pricing inline, e.g. `16 × $25 / seat / mo` (interval-aware unit). - "Credits by period" → "Monthly credits" (interval-aware: "Yearly credits" on yearly plans). - New "Total per month" row (→ "Total per year" on yearly) with a helper line via the existing `Label`: `$400 seats + $2,000 credits · next charge <date>`. The total is computed at the billing interval, so it equals the actual next charge. - "Switch to Yearly · save 20%" — discount computed from real monthly vs. yearly config prices (only appended when > 0). Credit usage card (`SettingsBillingCreditsSection.tsx`) - Denominator stays total available (allocation + rollover); figures shown in full (`3,856`, not `3.86k`). - "Base Credits" → "This month's credits" + a "Rolled over" row rendered as `+1,856`. - Adds a blue `Info` note stating the rollover rule: "Unused credits roll over, up to 2× your plan's credits (max 4,000)." — verified against the backend cap (`billing-credit-rollover.service.ts`: `rolloverAmount = min(unused, tierQuantity)`). Add-credits section (`ResourceCreditPriceSelector.tsx`) - "Resource credits" → "Add monthly credits" with a description clarifying it stacks on the plan and adjusts the bill. - On selection, shows the resulting new total and new rollover cap (2× the new allocation). Shared logic - New `useBillingSubscriptionCost` hook centralizes the seats/credits/total math so the subscription card and the add-credits selector stay consistent. - Yearly-discount calculation lives in `useBillingWording` (`getYearlyDiscountPercent`) next to the existing price logic. All new figures degrade gracefully — the Total row and the add-credits summary only render when fully computable, so trial/edge states never show partial numbers. ## Testing ⚠️ `nx typecheck` / `lint` could not be run in the authoring environment (dependency install couldn't complete due to flaky network). The changes were reviewed manually against the generated GraphQL types (`BillingPlanKey` = `{ENTERPRISE, PRO}`, `unitAmount: number`, `creditAmount: Maybe<number>`, nullable `interval`/`currentPeriodEnd`/`quantity` — all guarded) and a 4-angle cleanup pass (reuse/simplify/efficiency/altitude). Please let CI run typecheck + lint to confirm. https://claude.ai/code/session_01GNhCHPfD1SRzAiBACXGCf7 --- _Generated by [Claude Code](https://claude.ai/code/session_01GNhCHPfD1SRzAiBACXGCf7)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22126?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-25 04:13:06 +02:00
Thomas des Francs	e22d31c553	Close side panel after command menu actions (#22118 ) ## What changed - Close the command side panel after eligible headless command-menu actions complete or are confirmed. - Cover delete, restore, permanent destroy, create view, import, see deleted, and hide deleted record commands. - Keep create-record behavior unchanged so a newly created record can still open in the side panel. - Add focused Jest coverage for the affected command components and the create-record exception. # Before https://github.com/user-attachments/assets/36632578-3cab-47db-8f6d-350cd6fce683 # After https://github.com/user-attachments/assets/c9dba19b-7f4a-44aa-ae7f-57660c5a1e96 --------- Co-authored-by: Charles Bochet <charles@twenty.com>	2026-06-24 19:15:01 +02:00
Raphaël Bosi	02120aac42	Add v2 create-workspace onboarding screen (#22075 ) https://github.com/user-attachments/assets/30d69db2-ef50-48b5-8233-d9a36511b5e8 Builds the second step of the new onboarding flow on top of #22027: the v2 "Create your workspace" screen, shown inside `/welcome-v2` at the `WorkspaceCreation` step. What changed: - New `SignInUpV2Header` (back chevron + Twenty logo) and `SignInUpWorkspaceCreationFormV2` (left-aligned title/subtitle, logo upload, Name + Subdomain fields, "Create workspace"), wired into `SignInUpV2` for the workspace-creation step. - When a subdomain is taken, a box now lists 3 server-verified-available alternatives. Backend `SubdomainAvailabilityDTO` returns `suggestedSubdomains` via a new `findAvailableSubdomains` helper. - The shared `useWorkspaceSubdomainField` hook is extended additively (new `suggestions` + `applySuggestionValue`) so the v1 `/welcome` screen is untouched. Reviewer notes: - `generated-metadata/graphql.ts` was hand-patched (metadata codegen needs a running server). - Storybook: `Pages/Auth/SignInUpV2 → WorkspaceCreation`. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22075?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 17:13:20 +00:00
Emmanuel Hernández Bazán	33d2441a93	fix(ux): input error messages no longer overlap adjacent fields in forms (#21886 ) ## Context `InputErrorHelper` used `position: absolute` which took the error message out of normal document flow. In multi-field grid layouts (e.g. the HTTP Request workflow node editor), this caused the error text to render on top of the input below it instead of pushing it down. ## Solution Removed `position: absolute` from `InputErrorHelper`. The error message now participates in normal document flow and pushes subsequent content downward, as expected in modern forms. ## Test plan - [x] Open the HTTP Request node editor, fill in a field incorrectly — error message appears below the field without overlapping the next input - [x] Verify single-field forms still display error messages correctly 🤖 Generated with [Claude Code](https://claude.ai/claude-code) <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21886?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> --------- Co-authored-by: Emmanuel Hernandez <emmanuel.hernandez@clickbalance.com> Co-authored-by: Charles Bochet <charles@twenty.com>	2026-06-24 19:07:33 +02:00
Thomas des Francs	9ed0d85954	Update workspace domain card layout (#22108 ) ## What changed - Render the Workspace domain cards side by side instead of stacked. - Keep both domain cards full width within the row. - Rename the section title from `Workspace Domain` to `Workspace domain`. - Use the `www` globe icon for Subdomain while keeping the standard globe for Custom Domain. - Export `IconWorldWww` from `twenty-ui/icon` for front-end consumers. <img width="1029" height="220" alt="image" src="https://github.com/user-attachments/assets/83ad8a29-d63c-42bb-9233-7754d1e7adf7" /> ## Why This matches the updated settings design for the Workspace domain section and makes the Subdomain and Custom Domain options scan as sibling actions. ## Validation - Ran focused `oxlint` and `oxfmt` checks on edited files. - Built `twenty-ui` successfully. - Ran `twenty-front` typecheck successfully. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22108?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 16:24:39 +00:00
martmull	b5958fb331	Enforce server route app configuration requirements (#22091 ) ## Summary This PR enforces that applications exposing server route logic functions must be claimed (have an owner workspace) and installed on that owner workspace to be considered "configured". This ensures server route resolvers have a valid workspace context to execute in. ## Key Changes - ApplicationRegistrationVariableService: Enhanced `isConfiguredBatch()` to check server route configuration in addition to required variables - Added `ApplicationEntity` repository injection to track app installations - Implemented `isServerRouteConfigured()` private method that validates: - If app exposes server route logic functions, it must have an owner workspace - If it has an owner workspace, it must be installed on that workspace - Added comprehensive test suite covering all configuration scenarios - ServerRouteTriggerService: Removed feature flag check (`IS_SERVER_LOGIC_FUNCTION_ENABLED`) - Deleted `TwentyConfigService` dependency - Removed feature disabled exception handling - Server route triggers are now always enabled (gated by app configuration instead) - Configuration: Removed `IS_SERVER_LOGIC_FUNCTION_ENABLED` config variable from `ConfigVariables` - Exception handling: Removed `FEATURE_DISABLED` exception code from `ServerRouteTriggerExceptionCode` - UI & Documentation: Updated messaging and docs to reflect that server route apps require claiming and installation on owner workspace ## Implementation Details - Server route configuration is checked alongside required variable validation in `isConfiguredBatch()` - Uses efficient batch queries with `Promise.all()` to fetch variables, registrations, and installations in parallel - Installs are tracked via a Set of `${registrationId}:${workspaceId}` keys for O(1) lookup - Apps without server route functions are unaffected by this change https://claude.ai/code/session_01Ub3K25p2q4XE1LW1LGJbkG <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22091?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 16:20:05 +00:00
Félix Malfait	7d3cd5ed00	feat(front): add search to the language picker (#22095 ) ## What Adds a search bar to the Settings → Experience → Language picker, and makes languages searchable across languages. Each option is matched against: - its displayed label (the name in the current UI language) - its name in English — typing `chinese` finds "Chinois — Simplifié" - its native name — typing `中文` finds the same option Matching is also accent-insensitive (`francais` finds "Français"). ## How - The shared `Select` already supports search via `withSearchInput` (used by the currency/country pickers) — the picker just opts in. - Cross-language matching uses the platform `Intl.DisplayNames` API to derive each language's English and native names — no hardcoded translation tables, no extra requests. - A generic optional `searchKeywords` field on `SelectOption` lets the `Select` filter match synonyms on top of the label; the filter now runs through the existing `normalizeSearchText`, hence the accent-insensitivity. Behavior is unchanged for every existing `Select` (strict superset for ASCII labels). ## Test - `nx typecheck` / `nx lint` pass for `twenty-front` and `twenty-ui`. - Open the Language dropdown and try `chinese`, `中文`, or `francais`. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22095?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 16:58:24 +02:00
Raphaël Bosi	dd9ad876a4	Reduce published twenty-ui npm package size (#22087 ) The published `twenty-ui@1.0.0-alpha.0` tarball was ~181 MB unpacked (27 MB compressed, 2,701 files). This was a build-config issue, so a clean CI build would reproduce the same size. Main fix: externalize `@tabler/icons-react` instead of bundling it. It was forced into the bundle and aliased to the full icon barrel, inlining the entire icon set into every entry point in both ESM and CJS (~81% of the package). It stays a `dependency`, so consumers still get it; the dynamic `<Icon name>` registry still resolves icons at runtime. Also: - Stop emitting/shipping declaration maps (`declarationMap: false`). - Exclude the internal `dist/individual` build and `*.map` from the tarball via `files` (it still builds locally for `twenty-front-component-renderer`). - Clean up the stale `files` / `project.json` build outputs at their source, `scripts/generateBarrels.ts`. - Add a `pack-size` CI guard (30 MB unpacked budget) and wire `size` + `pack-size` into `ci-ui.yaml`. Result: ~181 MB to ~2.3 MB unpacked (0.40 MB tarball, 400 files). All export subpaths, types, and icon rendering verified intact in both module formats. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22087?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 14:53:14 +00:00
RISHAV DEWAN	1cdede89de	fix(email-settings): enable independent message folder and subfolder selection (#21853 ) ## Summary Fixes #21840 Currently, selecting a root folder in Settings → Accounts → Emails → Folders automatically selects all of its subfolders, and selecting a subfolder automatically selects all of its ancestor folders. Users have no granular control over individual folder sync. This PR replaces the cascade selection logic with fully independent per-node selection, matching standard tree-select UX patterns used in file explorers and permission trees. ## Changes ### Bug Fix - `computeFolderIdsForSyncToggle.ts`: Removed `collectChildren` and `collectParents` cascade helpers. The function now returns only the toggled folder's ID, enabling fully independent selection. - `SettingsAccountsMessageFoldersCard.tsx`: Updated call site to match simplified function signature (removed unused `allFolders` and `isSynced` args). ### Tests - `computeFolderIdsForSyncToggle.test.ts`: Rewrote tests to reflect new per-node behavior. Removed tests asserting old cascade behavior; replaced with tests verifying only the toggled folder is affected. - `isFolderTreePartiallySelected.test.ts` (new): Added 9 tests for `isFolderTreePartiallySelected`, which is now the primary mechanism driving the indeterminate checkbox state on parent folders. ## Behavior Before / After \| Action \| Before \| After \| \|--------\|--------\|-------\| \| Check a root folder \| Checks root + all subfolders \| Checks root only \| \| Check a subfolder \| Checks subfolder + all ancestors \| Checks subfolder only \| \| Uncheck a root folder \| Unchecks root + all subfolders \| Unchecks root only \| \| Parent with partial children \| No indeterminate state (broken) \| Shows `–` indeterminate correctly \| ## What Was Already Correct The indeterminate checkbox UI was already fully implemented: - `isFolderTreePartiallySelected` correctly detects mixed sync states in subtrees - `SettingsMessageFoldersTreeItem` already passes `indeterminate` to the `Checkbox` component - The `Checkbox` component in `twenty-ui` already supports the `indeterminate` prop Only the toggle cascade logic needed fixing. ## Testing ```bash # Unit tests cd packages/twenty-front && yarn jest --testPathPattern="computeFolderIdsForSyncToggle\|isFolderTreePartiallySelected" # Lint npx nx lint:diff-with-main twenty-front # Type check npx nx typecheck twenty-front <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21853?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> --------- Co-authored-by: Charles Bochet <charles@twenty.com> Co-authored-by: neo773 <62795688+neo773@users.noreply.github.com> Co-authored-by: neo773 <neo773@protonmail.com>	2026-06-24 14:32:18 +00:00
Félix Malfait	614bc7b7e6	feat: serve HTTP logic functions on isolated .withtwenty.com domain (#22045 ) ## Summary Implements [core-team-issues#2473](https://github.com/twentyhq/core-team-issues/issues/2473): serve HTTP-triggered logic functions from a dedicated, cookieless* public domain (`{workspaceSubdomain}.withtwenty.com`) instead of the same-site `/s/` route, so functions can safely return arbitrary headers — custom headers, `Permissions-Policy` (camera/mic/geolocation), `Cross-Origin-Opener-Policy: same-origin`, `Cross-Origin-Embedder-Policy: require-corp`, `Set-Cookie`, etc. The `/s/` route stays the strict, same-site path it is today. Self-hosting is unchanged — everything new is gated on `PUBLIC_DOMAIN_URL` being set. ### Why Today user-authored function responses are served same-site with the Twenty app, so the response-header allow-list is restricted to 5 safe headers and request headers are limited to a per-function allow-list. Serving from an origin that shares nothing with `.twenty.com` removes that constraint safely — the same "user content domain" pattern as GitHub (`.githubusercontent.com`) and CodeSandbox (`.csb.app`). ## What's in here Routing* - The root-path → `/s` rewrite happens at the nginx ingress, not in app code. The existing `api-ingress.yaml` already rewrites root paths onto `/s` (host-agnostically) when the edge sets `X-Twenty-Public-Domain: true`, so `.withtwenty.com` and registered custom public domains are handled by the same mechanism. (An earlier in-app middleware was removed as a redundant, wrong-layer duplicate.) - `WorkspaceDomainsService.resolveWorkspaceAndPublicDomain` recognizes `.` subdomains, resolves the workspace by subdomain, and returns `isIsolatedOrigin`. Explicitly registered public-domain rows still take precedence and keep their application scoping. The ingress preserves the `Host` header, so this resolution still fires. Headers (server) - Isolated origin → all response headers pass through and all request headers are forwarded. Same-site `/s/` keeps the strict allow-lists. (Global CORS already handles preflight/ACAO.) `/s/` deprecation for new routes (cloud only) - New `LOGIC_FUNCTION_LEGACY_ROUTE_CUTOFF` config var (ISO date, optional). When `PUBLIC_DOMAIN_URL` is set, functions created on/after the cutoff return 410 Gone on `/s/` with the new URL. Existing routes and self-hosted instances are untouched. Frontend education - `publicFunctionDomain` added to `ClientConfig` (from `PUBLIC_DOMAIN_URL`). - The logic-function Live URL now resolves to `https://{workspaceSubdomain}.{publicFunctionDomain}{path}` on cloud, falling back to `/s/` for self-hosting. - Front components call their functions through the SDK (`RestApiClient`), which now targets the isolated domain via the injected `TWENTY_FUNCTIONS_URL`. - New "Public URL" section on the application Settings tab explaining the isolated domain (shown when the app exposes HTTP-triggered functions). Docs: note the `withtwenty.com` domain for external callers in the apps guide. ## Infra prerequisites (not code — needs dashboard work) - Wildcard DNS `.withtwenty.com` (proxied) + wildcard TLS in the public-domain Cloudflare zone. - Edge (Cloudflare) sets `X-Twenty-Public-Domain: true` for `.withtwenty.com` requests, so the existing nginx ingress rewrites them onto `/s` (same header the custom-domain flow already relies on). - Set `PUBLIC_DOMAIN_URL=https://withtwenty.com` on cloud. - Submit `withtwenty.com` to the Public Suffix List (required for cross-tenant cookie isolation before relying on `Set-Cookie`). ## Test plan - [x] `nx typecheck twenty-server`, `nx typecheck twenty-front` - [x] `lint:diff-with-main` + oxfmt clean (server + front) - [x] `npx jest route-trigger public-function-domain domain-server-config workspace-domains build-logic-function-event client-config` → server unit tests passing (resolution tiers, header passthrough vs allow-list, `/s/` cutoff 410) - [x] `npx jest getLogicFunctionHttpUrl` (front) and `nx test twenty-client-sdk` (RestApiClient routing) passing - [x] CI green (server, front, sdk, renderer, ui, zapier, example apps) - [ ] Manual: hit `{subdomain}.withtwenty.com/` end-to-end once infra is provisioned <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22045?utm_source=github" rel="nofollow noreferrer noopener" target="_blank">``<img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg">``</a>	2026-06-24 15:57:01 +02:00
martmull	b5a1aed24b	feat(server): run server-exposed logic functions in the owner workspace (#22002 ) ## Summary Implements the server-level logic-function tier in the simplest shape: a logic function is "server-exposed" iff its manifest entry carries `serverWebhookTriggerSettings`. Execution delegates to the owner-workspace copy of that function — billing, throttling, env vars, and the existing executor all apply uniformly against that workspace. Supersedes #21971 with the simplified design from that discussion (no `applicationRegistrationLogicFunction` registry, no dedicated manifest type, no separate SDK helper, no special throttling). ## Design - Manifest: `LogicFunctionManifest` gains `serverWebhookTriggerSettings?`. The declarative `workspaceIdResolver` shape is dropped. - Materialization: those settings become two new jsonb columns on `LogicFunctionEntity`. The manifest → flat converter and the create-from-source DTO/util forward them; the property-config map and editable-properties list are extended. - Lookup: a single QB query joins `logicFunction → application → applicationRegistration` and filters on `lf.workspaceId = reg.workspaceId` to get only the owner workspace's copy. - Webhook: `POST /webhooks/server/:logicFunctionUniversalIdentifier` → `ServerWebhookTriggerService.handle` → join lookup → `LogicFunctionTriggerService.run`. No registry table, no `:applicationRegistrationUniversalIdentifier` segment, no resolver. - Gate: `IS_SERVER_LOGIC_FUNCTION_ENABLED` config var (disabled by default). ## Test plan - [x] `npx jest server-webhook-trigger` — 9 unit tests across the webhook service. - [x] `npx jest logic-function` — 88 existing tests stay green. - [x] `npx nx typecheck twenty-server`. - [x] `npx nx lint:diff-with-main twenty-server`. - [x] Reset DB → init → run `database:migrate:prod` → run `database:migrate:generate --name pending-migration-check` → no drift. - [ ] Manual: hit `/webhooks/server/<uid>` end-to-end against a manifest carrying `serverWebhookTriggerSettings`. https://claude.ai/code/session_01GgsnCGmYJ26xRirx8va1Yh --- _Generated by [Claude Code](https://claude.ai/code/session_01GgsnCGmYJ26xRirx8va1Yh)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22002?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 13:34:12 +00:00
Paul Rastoin	ad3c82bd15	fix(front): prevent lingui extract crash in buildCrudToolStatusMessage (#22080 ) ## Problem The `build-front / s3-build` CD job fails during the `Build frontend` step, in the `twenty-front:lingui:extract` target (`lingui extract --overwrite --clean`): ``` Cannot process file .../build-crud-tool-status-message.util.ts: Cannot read properties of undefined (reading 'name') at @lingui/babel-plugin-extract-messages/dist/index.cjs:88:22 at extractFromObjectExpression (...index.cjs:87:18) at extractFromMessageDescriptor (...index.cjs:121:19) at PluginPass.CallExpression (...index.cjs:189:11) ``` ## Root cause `buildCrudToolStatusMessage` called `i18n._()` with an inline object literal containing a spread: ```ts i18n._({ ...verbs.loading, values: { objectLabel } }) ``` Lingui's `extract-messages` babel plugin fires on every `i18n._(...)` call. When the first argument is an `ObjectExpression`, it runs `extractFromObjectExpression`, which reads `key.name` for every property. The spread element `...verbs.loading` has no `key`, so `key.name` throws `Cannot read properties of undefined (reading 'name')`, crashing `lingui extract` and failing the whole S3 publish job. ## Fix Hoist the descriptors into variables so `i18n._()` receives an identifier rather than an inline object expression. The plugin then skips extraction (no statically-extractable id), so no crash. Runtime behavior is unchanged — the translatable strings are still extracted from the `msg` macros in `CRUD_TOOL_OPERATION_VERBS`. ## Testing - Reproduced the exact CI crash locally on `main` by running `lingui extract --overwrite --clean` (same file, message, and stack frames). - After the fix, `lingui extract --overwrite --clean` runs clean (exit 0). - `build-crud-tool-status-message.util.test.ts` passes (2/2). - `nx lint:diff-with-main twenty-front` passes (0 warnings, 0 errors, formatting clean). <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22080?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 15:21:43 +02:00
Thomas des Francs	9e57ec3153	Update data model object settings labels (#22070 ) ## Summary - Update Data Model object list copy: rename the section to Objects and the count column to Records. - Improve relation rows by showing the related object name with the field name as a secondary label, including morph relation-specific labels/icons. - Hide relations to system objects unless Advanced mode is enabled, and default the System objects filter to on while Advanced mode is on. - Reuse a shared secondary-label component for the light subtitle/deactivated text treatment. ## Screenshots ### Before Mix of field name & object name. Not all relations are navigable <img width="1642" height="950" alt="image" src="https://github.com/user-attachments/assets/e04fb710-e333-4dd7-a29f-82c226202e77" /> ### After <img width="1690" height="1112" alt="image" src="https://github.com/user-attachments/assets/f7d75974-a5cc-401b-bbd2-ab82a2006cf9" />	2026-06-24 15:15:41 +02:00
Charles Bochet	0df83eceb2	fix(front): restore loading state on third-party app command menu actions (#22073 ) ## Problem Headless command-menu actions provided by third-party applications (e.g. the "Twenty Eng" app actions like Fetch Pull Requests, Recompute Build Tasks) no longer show a loading/progress indicator while they run, so users can't see that the action is in progress. ## Root cause In `CommandMenuItemSelectableRenderer`, [#21020](https://github.com/twentyhq/twenty/pull/21020) added an early-return branch for third-party application actions that renders `AppMenuItem`: ```tsx if (isThirdPartyApp) { return ( <SelectableListItem ...> <AppMenuItem ... /> // no loader passed </SelectableListItem> ); } ``` This branch returns before the `listItem` path that builds the `loaderComponent` (spinner + progress %), and `AppMenuItem` had no way to render a right-side loader. So `progress` / `showDisabledLoader` from `useCommandMenuItemClick` were computed but dropped for third-party app actions. Native (non third-party) actions kept their loader because they go through the `listItem` path. ## Fix - Add an optional `RightComponent` prop to `AppMenuItem`, forwarded to the underlying `MenuItem` (which already renders it). - Hoist the `loaderComponent` computation in `CommandMenuItemSelectableRenderer` above the branches and pass it to both the third-party `AppMenuItem` path and the existing `listItem` path (no behavior change for the latter). The loader now appears for third-party app actions exactly as it does for native ones — `<CommandListItemLoader progress={progress} />` once progress is reported, falling back to a `<Loader />` spinner before the first progress update. ## Verification - `oxlint --type-aware` clean on both changed files. - `typecheck` clean for the changed files. - Manual browser repro requires a third-party application with a progress-reporting headless action installed in the workspace (as in the reported screenshot), which isn't available in a stock dev workspace. The fix mirrors the already-working native `listItem` loader path. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22073?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 15:05:28 +02:00
Raphaël Bosi	558e2e4107	Add new onboarding login screen at /welcome-v2 (#22027 ) Stands up the new onboarding login screen at a new route `/welcome-v2`, as the foundation for the new onboarding flow (future PRs build the post-login steps on top of it). There is no feature flag: feature flags are per-workspace and read from `currentWorkspaceState`, which is null on the pre-auth welcome screen, so they can't cleanly gate it. A dedicated route is used instead. `/welcome` is untouched and stays the default for logged-out users; `/welcome-v2` is reachable only by navigating to it directly (nothing links or redirects to it yet), so this is fully non-breaking. The new page reuses all existing auth logic and behavior components (`useSignInUp`, `useSignInUpForm`, step state, the Google/Microsoft/credentials forms, `Logo`, `Title`, `ModalContent`) and mirrors `SignInUp.tsx` almost exactly. The only intentional design delta from today's screen is the footer wording, per Figma: "Data Processing Agreement" (linking to `/legal/dpa`) instead of "Privacy Policy". Notable: - Added an optional `to` prop to the shared `Logo` (defaults to `AppPath.SignInUp`, backward-compatible) so the logo on `/welcome-v2` doesn't bounce users back to `/welcome`. - The remaining changes are single-line additions to the pre-auth allowlists next to the existing `AppPath.SignInUp` entries (router, redirect guard, auth modal, metadata gater, captcha, page title, focus). https://github.com/user-attachments/assets/abfc96ec-a87d-4608-b92a-87e2322e4874 <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22027?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 12:13:55 +00:00
Thomas des Francs	1589b9b912	Add search to new sidebar item picker (#22041 ) ## Summary - Add search to the custom layout “New menu item” side panel. - Group search results by Objects, Views, and Records. - Reuse the existing record search behavior through a shared hook and preserve add-to-navigation drag/select flows. ## Video - Recording: https://gist.githubusercontent.com/Bonapara/c78107650efd94b580e38426b9fc2dbd/raw/755c87fab253281a9c68e5a24cbfdff6c9248af1/search-nav-item-custom-layout.webm ## Verification - Browser plugin: opened layout customization, clicked `Add menu item`, searched `o`, and verified `Objects`, `Views`, and `Records` result groups with object/view/record results. - `npx oxlint --type-aware -c packages/twenty-front/.oxlintrc.json packages/twenty-front/src/modules/navigation-menu-item/edit/side-panel/components/SidePanelNewSidebarItemPage.tsx packages/twenty-front/src/modules/navigation-menu-item/edit/side-panel/components/SidePanelNewSidebarItemRecordSubPage.tsx packages/twenty-front/src/modules/navigation-menu-item/edit/side-panel/components/SidePanelNewSidebarItemSearchResults.tsx packages/twenty-front/src/modules/navigation-menu-item/edit/side-panel/hooks/useAvailableNavigationMenuItemSearchRecords.ts` - `npx nx typecheck twenty-front` - `npx nx lint twenty-front` <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22041?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 14:05:23 +02:00
Etienne	5ca41d55fb	feat(ai): humanize tool-call (#21976 ) # Humanize tool-call labels cc: https://github.com/twentyhq/twenty/pull/21462 ## Preview <img width="459" height="156" alt="Screenshot 2026-06-22 at 19 13 11" src="https://github.com/user-attachments/assets/e7a2f5f5-cd09-4ec6-920b-5eb16b98285c" /> <img width="461" height="156" alt="Screenshot 2026-06-22 at 19 14 54" src="https://github.com/user-attachments/assets/c2114d2e-2aa8-499a-9801-68e3bb7c45f8" /> <img width="461" height="505" alt="Screenshot 2026-06-22 at 19 15 01" src="https://github.com/user-attachments/assets/ee9ca5d0-8e79-4c63-a2ff-ed5e359a9a9c" /> ## Why In the AI chat, tool steps were displayed using raw tool identifiers (`find_many_companies`, `create_one_task`, `send_email`...) and labels were partially reconstructed/humanized on the frontend. This was hard to localize and inconsistent across tool categories. This PR makes the backend the single source of truth for human-readable, localized tool labels, exposes them through `getToolIndex`, and reduces the frontend to a thin resolver that picks the right label for the current status (in-progress / completed). ## What changed ### Backend - `ToolIndexEntry` (and the `getToolIndex` GraphQL DTO) now carry `label`, `inProgressLabel?`, `completedLabel?`. - New `getCrudToolLabels(operation, objectLabel, i18nService, locale)` builds CRUD labels from a verb table (Search / Find / Group / Create / Update / Upsert / Delete × imperative / in-progress / completed) + the (translated, lowercased) object label. - New `translate-tool-label.util.ts` translates a source label via `I18nService` (`generateMessageId` → fallback to source when no translation exists). - Action tools: labels extracted to the `ACTION_TOOL_LABELS` constant (`msg` + `i18nLabel`) and translated in `ActionToolProvider.buildDescriptor`. - Logic-function tools use the function name as label; `toolSetToDescriptors` (workflow / view / metadata / dashboard) accepts an optional `labels` map and falls back to a humanized tool name. - Labels are localized server-side using the request locale (`@RequestLocale` → `buildToolIndex` → `context.locale`, threaded through `ToolContext` / `ToolProviderContext`). - `code_interpreter` schema now asks the model for `loadingMessage` (present tense) and `completedMessage` (past tense), so its status text is model-generated. - Removed the old generic `loadingMessage` injection mechanism (`wrap-tool-for-execution.util.ts` deleted; `wrapJsonSchemaForExecution` / `stripLoadingMessage` no longer wrap every tool). ### Frontend - New `useToolLabelMap()` hook builds a `Map<name, { label, inProgressLabel, completedLabel }>` from `getToolIndex`. - `getToolDisplayMessage` → `resolveToolDisplayMessage({ input, toolName, isFinished, labelMap, output })`: a small resolver registry keyed by tool name (`execute_tool`, `web_search`, `learn_tools`, `load_skills`, `code_interpreter`, default). - Default resolver prefers backend `completedLabel` / `inProgressLabel`, falling back to `Ran X` / `Running X`. - `learn_tools` / `load_skills` resolve their inner tool/skill names to labels (label map → tool output labels via `getToolOutputLabelEntries` → raw name). - `code_interpreter` step is now expandable to show the code even while running. ## How tool labelling flows (BE → FE) ```text BACKEND ┌───────────────────────────────────────────────────────────────────────────┐ │ Tool providers (per category) → ToolIndexEntry │ │ │ │ DatabaseToolProvider │ │ getCrudToolLabels(operation, object.labelPlural/Singular, i18n, locale) │ │ verb table (Search/Create/Update/Delete…) + translateToolLabel(object) │ │ → { label, inProgressLabel, completedLabel } │ │ │ │ ActionToolProvider │ │ ACTION_TOOL_LABELS[toolId] (msg) → translateToolLabel(…, locale) │ │ → { label, inProgressLabel?, completedLabel? } │ │ │ │ LogicFunctionToolProvider → label = logicFunction.name │ │ toolSetToDescriptors → label = labels[name] ?? humanize(name) │ │ (workflow / view / metadata / dashboard) │ └───────────────────────────────────────────────────────────────────────────┘ │ ▼ ┌───────────────────────────────────────────────────────────────────────────┐ │ GraphQL Query getToolIndex : [ToolIndexEntry] │ │ { name, label, inProgressLabel, completedLabel, description, │ │ category, objectName, icon } │ └───────────────────────────────────────────────────────────────────────────┘ │ ▼ FRONTEND ─ resolve the right label for the current status ┌───────────────────────────────────────────────────────────────────────────┐ │ useGetToolIndex() → useToolLabelMap() │ │ Map<name, { label, inProgressLabel?, completedLabel? }> │ └───────────────────────────────────────────────────────────────────────────┘ │ ▼ ┌───────────────────────────────────────────────────────────────────────────┐ │ resolveToolDisplayMessage({ input, toolName, isFinished, labelMap, output })│ │ │ │ TOOL_LABEL_RESOLVERS[toolName] ?? defaultResolver │ │ ├─ execute_tool → unwrap { toolName, arguments } then re-resolve │ │ ├─ web_search → "Searching/Searched the web for <query>" │ │ ├─ learn_tools → "Learning/Learned <labels>" │ │ ├─ load_skills → "Loading/Loaded <labels>" │ │ │ inner names resolved via: labelMap → output labels → raw name │ │ ├─ code_interpreter → model's loadingMessage / completedMessage │ │ └─ default → isFinished │ │ ? completedLabel ?? "Ran <label>" │ │ : inProgressLabel ?? "Running <label>" │ └───────────────────────────────────────────────────────────────────────────┘ │ ▼ Rendered by ThinkingStepsDisplay / ToolStepRenderer ``` ## Localization notes - Standard object labels and action/CRUD verbs are translated server-side via `I18nService` using the requester's locale. - Custom object labels are not translated unless a workspace custom translation exists (matched by `generateMessageId`); otherwise the source label is used as-is. ## Tests - FE: `resolveToolDisplayMessage` / `getToolOutputLabelEntries` (status selection, inner-name resolution, `code_interpreter` model labels, fallbacks). - BE: `toolSetToDescriptors` (label map + humanized fallback) and `database-tool.provider` label generation. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21976?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 13:41:09 +02:00
Vincent Vu	680e4a712b	feat(ui): additional social providers to link components (#21716 ) The current link component matches only to linkedin, twitter and facebook. It is currently missing the x handle. In addition to this, we should also accomodate for instagram, bluesky and tiktok. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21716?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> Co-authored-by: Charles Bochet <charles@twenty.com>	2026-06-24 12:21:17 +02:00
martmull	269c8ef400	feat(front): allow advanced relation fields in FieldWidget selector (#22005 ) ## After <img width="706" height="760" alt="image" src="https://github.com/user-attachments/assets/d118285f-baab-4187-988c-d0180d61a629" /> <img width="707" height="372" alt="image" src="https://github.com/user-attachments/assets/5676d829-2ec1-494e-a8f0-5998f1f0c3c8" /> ## Summary The FieldWidget field-selection dropdown currently filters out relation fields whose target is a system object, so users can't pick fields like `calendarEventParticipants` on the CalendarEvent record page. The widget itself can render them just fine as boxed relations — the restriction only lives in the picker. This unblocks the consistency story from #22003 (revert of #21857): once shipped, participants can be added to the calendar event record page via the existing FieldWidget mechanism instead of a bespoke side-panel page. ## Changes - `isFieldCellSupported`: adds an opt-in `includeSystemObjectRelations` option that skips the `isObjectMetadataAvailableForRelation` system check. - `useFieldListFieldMetadataItems`: forwards the option through to `isFieldCellSupported`. Default is `false`, so all existing callers keep current behavior. - `useFieldWidgetEligibleFields`: turns the option on, so the FieldWidget selector now surfaces fields like `calendarEventParticipants`, `messageParticipants`, etc. ## Test plan - [x] `nx typecheck twenty-front` - [x] `nx lint:diff-with-main twenty-front` - [ ] CI - [ ] Manually verify the FieldWidget dropdown now lists `calendarEventParticipants` on a CalendarEvent record page, and that selecting it renders a participants list via the existing relation card/field widget. https://claude.ai/code/session_01RnMcjL35wdCRzpXN257RLJ --- _Generated by [Claude Code](https://claude.ai/code/session_01RnMcjL35wdCRzpXN257RLJ)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22005?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 10:30:42 +02:00
martmull	3943898642	Remove custom widget from calendarEvent page layout (#22046 ) ## Before <img width="608" height="759" alt="image" src="https://github.com/user-attachments/assets/e75f6cc9-aef8-4247-a88d-6992b3936d3d" /> ## After <img width="844" height="658" alt="image" src="https://github.com/user-attachments/assets/446a13f2-e40c-4e1c-a1ed-0920fe5065b3" /> remove https://github.com/twentyhq/twenty/pull/22016 custom widget and replace with regular field widget does not match figma design but avoid introducing specific behavior for calendarEvent <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22046?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-24 08:59:14 +02:00
Félix Malfait	2e099c91e1	fix(domains): show custom domain DNS records and activation status without a page reload (#22037 ) ## Problem Setting up a custom domain had two confusing UX issues, both caused by local state not being refreshed after the relevant mutation: 1. DNS records didn't appear after saving. After hitting save you got the green "Custom domain updated" snackbar, but the "Domain Setup" section (the Cloudflare/DNS records to configure) stayed empty. You had to leave the page and come back for the records to show up. 2. The "Custom Domain" card stayed "Inactive" even after the DNS records validated as "Success". Only a full page reload flipped it to "Active". ## Root cause Issue 1 — stale closure. In `useSettingsCustomDomain.handleSave`, the `updateWorkspace` `onCompleted` callback called `setCurrentWorkspace({ ...currentWorkspace, customDomain })` and then `checkCustomDomainRecords()`. But `checkCustomDomainRecords` guarded on the closed-over `currentWorkspace.customDomain`, which was still `null` at that render. The `setCurrentWorkspace` call doesn't synchronously update that captured value, so the guard returned early and the records were never fetched. Remounting the page (navigate away/back) ran the on-mount effect with a fresh workspace, which is why the trip "fixed" it. Issue 2 — `isCustomDomainEnabled` never refreshed locally. The Active/Inactive badge is driven by `currentWorkspace.isCustomDomainEnabled`. The backend flips this flag inside `checkCustomDomainValidRecords` (`custom-domain-manager.service.ts`), but the mutation didn't return it, so the local `currentWorkspaceState` stayed stale until a full reload re-ran the bootstrap query. The green "Success" DNS rows read from a different source (`record.status`), which is why the rows and the badge disagreed. ## Changes Issue 1 - `checkCustomDomainRecords` now accepts the domain explicitly (defaulting to the workspace value), so the freshly-saved domain can be passed straight from `handleSave` instead of relying on the stale closure. No new `useEffect` introduced. - Fixed the Reload button so it no longer passes its click event as the domain argument. Issue 2 - Added a nullable `isCustomDomainEnabled` field to the `DomainValidRecords` GraphQL type, populated only by the custom-domain check (the shared public-domain flow leaves it null, so it's backward compatible). - The frontend now writes that value back into `currentWorkspaceState` when the check completes, using a functional Jotai update so a concurrent `customDomain` update is never clobbered. The badge flips to "Active" as soon as validation passes — on mount, on Reload, and right after save. I deliberately kept this targeted rather than introducing real-time workspace sync: `isCustomDomainEnabled` only changes server-side during the on-demand DNS check (mount/Reload/cron), so returning it from that mutation is sufficient and far lower risk. ## Notes - `packages/twenty-front/src/generated-metadata/graphql.ts` was updated to match what `graphql:generate` produces for the new schema field (codegen requires a running backend, which isn't available in this environment). Worth re-running codegen in CI to confirm it's byte-identical. - No existing unit or integration tests reference these paths. ## Test plan - [ ] Set a custom domain → DNS records appear immediately (no navigation needed). - [ ] Once DNS validates, the "Custom Domain" card flips to "Active" without a reload. - [ ] Reload button still refreshes records. - [ ] Public domain validation flow is unaffected. https://claude.ai/code/session_01BB6C6bpPZMUbMzKSCydEaj --- _Generated by [Claude Code](https://claude.ai/code/session_01BB6C6bpPZMUbMzKSCydEaj)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22037?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-23 18:02:44 +02:00
Félix Malfait	f24be8eacb	fix: keep AI chat open when opening a record full-page (e.g. workflows) (#22036 ) ## Problem When the AI chat is open in the side panel and you click a workflow from the Workflows list, the AI chat closes as you navigate to the workflow page. Navigating between other index/list pages, or to settings, keeps the chat open — only opening a record full-page closes it. ## Root cause `useOpenRecordFromIndexView` unconditionally calls `closeSidePanelMenu()` before navigating to a full-page record: ```ts } else { closeSidePanelMenu(); navigate(AppPath.RecordShowPage, { ... }); } ``` Workflows (and other objects excluded by `canOpenObjectInSidePanel` — `workflow`, `workflowVersion`, `dashboard`) can't open in the side panel, so they always take this branch and close the panel, including the AI chat. This is inconsistent with `PageChangeEffect`, which already lets the AI chat survive navigation by exempting `SidePanelPages.AskAI`. That exemption is why navigating between index pages or to settings doesn't close the chat. ## Fix Skip the close when the side panel is showing the AI chat, mirroring the exemption already used in `PageChangeEffect`. Any other side panel page still closes as before. ## Testing - `nx lint:diff-with-main twenty-front` (file lints clean) - `nx typecheck twenty-front` passes https://claude.ai/code/session_01LtBBAxjn32FQVduyAi6B37 --- _Generated by [Claude Code](https://claude.ai/code/session_01LtBBAxjn32FQVduyAi6B37)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22036?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-23 18:01:51 +02:00
Raphaël Bosi	766d90af7e	Remove framer-motion from twenty-ui (#22021 ) ## What Removes the `framer-motion` dependency from `twenty-ui` and replaces every usage with pure CSS animations, reaching for Base UI primitives where one fits: - Collapse/expand (`AnimatedEaseInOut`, `AnimatedExpandableContainer`): rebuilt on Base UI `Collapsible` (CSS-animated `--collapsible-panel-height/width` + transition states). Public props unchanged, so the ~28 call sites are untouched. - ProgressBar: rebuilt on Base UI `Progress` (proper `role`/`aria-valuenow`). The snackbar auto-dismiss countdown now uses a CSS keyframe + `animation-play-state` (pause on hover), removing a per-frame React re-render; `useProgressAnimation` is deleted. - The remaining `Animated*` components, the circular spinner, checkmark, and the placeholder pointer parallax move to plain CSS (SCSS modules + the `duration()` helper + theme tokens). - Deletes 3 unused components (`AnimatedTranslation`, `AnimatedTextWord`, `AnimatedFadeOut`). ## Why `twenty-ui` is a publicly published library with a size budget, so dropping framer-motion shrinks what consumers ship. `twenty-front` keeps its own framer-motion; that is out of scope here. ## Notes for reviewers - A few `twenty-ui` components received framer props from `twenty-front` call sites; those were migrated (e.g. `AnimatedLightIconButton` gained a CSS `rotate` prop, and the `EMPTY_PLACEHOLDER_TRANSITION_PROPS` spreads were removed). - Behavior change: Base UI `Collapsible` animates only on open/close transitions, so the old "animate in on first mount while already open" case no longer plays (the `initial` prop is kept for API compatibility). <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22021?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-23 17:43:08 +02:00
Johnny Martin	d4e4e2612b	feat(front): render Instagram URLs as @handles in link fields (#21642 ) LinkedIn and X links already show a readable handle in Twenty's link fields. Instagram doesn't — it just shows `instagram.com`, which isn't much help when you're scanning a record. This adds the same handling for Instagram. `instagram.com/ptcrash` now shows as `@ptcrash`, in tables, on record pages, and in the edit menu. Post and reel links (`/p/...`, `/reel/...`) have no handle, so they fall back to `Instagram`. How it works: - `Instagram` added to the `LinkType` enum - `checkUrlType` detects `instagram.com` - `getDisplayValueByUrlType` pulls the handle and prefixes `@` - a shared `isSocialLinkType` helper keeps the three display components in sync Tested with unit tests for both helpers, the updated story, and manually against a record whose Instagram field is `http://instagram.com/ptcrash`. Closes #21644 Co-authored-by: Johnny Martin <ptcrash@users.noreply.github.com>	2026-06-23 17:25:50 +02:00
Félix Malfait	855664daa2	feat(timeline): activity kind registry (Layer A) (#21950 ) ## What & why The timeline-activity system's contract is a magic `name` string (`"company.updated"`, `"linked-note.created"`, `"message.linked"`) decoded by `String.split('.')` in four different frontend spots and produced by a hardcoded `if`-ladder + two listeners. It is not extensible and it already harbored a latent bug. This PR replaces that stringly-typed protocol with an explicit, persisted `kind` contract consumed through registries on both ends. Adding a new timeline activity type becomes: add a producer + register a presenter — no edits to a central switch. This is Layer A of a larger plan (see `packages/twenty-server/docs/TIMELINE_ACTIVITIES_REFACTOR.md` and `TIMELINE_ACTIVITIES_PR_A.md`). Layer B (timeline projection / "inheritance") and Layer C (user-defined aggregation rules) are intentionally out of scope here. ## 🐛 Bug fixed along the way `calendar-event-participant.listener.ts` was writing calendar-event timeline rows with `name: 'message.linked'` (copy-paste from the message listener). It rendered "correctly" only by luck — the frontend routed on `linkedObjectMetadataId → nameSingular`, never on `name`. This PR fixes it at the source (`calendarEvent.linked` / `kind: 'linkedCalendarEvent'`), and the shared resolver also corrects historical rows that carry the wrong `name`. ## Changes `twenty-shared` — new `timeline` module - `TimelineActivityKind` (`recordChange \| linkedNote \| linkedTask \| linkedMessage \| linkedCalendarEvent \| linkedRecord`) + `resolveTimelineActivityDescriptor`, the single place that decodes an activity into `{ kind, action }`. Reads the persisted `kind` when present and falls back to legacy `name`/`linkedObjectMetadataId` parsing (back-compat shim). Unit-tested (20 cases). `twenty-server` - Persist a nullable `kind` field on the `timelineActivity` standard object (entity shape + field-metadata builder + universalIdentifier). - Producers (`timeline-activity.service.ts`, the two participant listeners) set `kind` explicitly; dev seeder populates it. - Fix the `calendarEvent.linked` mislabel. `twenty-front` - Static `TIMELINE_ACTIVITY_PRESENTERS` registry replaces the render `switch`, the icon `if`-chain, the diff-validation name-parsing, and the `name.match(/note\|task/i)` title-prefetch hack. - New `EventRowGenericLinked` so an unknown linked object type renders a real "linked a {object}" row instead of falling through to the wrong (main-object) renderer. ## Migration / compatibility - The `kind` column on this workspace standard object is created by the normal workspace metadata sync — no hand-written migration. It is nullable, so pre-upgrade rows degrade gracefully through the resolver shim (they resolve correctly from `linkedObjectMetadataId` + `name`). An optional backfill workspace command could populate `kind` on old rows later; not required for correctness. - No GraphQL breaking change — `kind` is additive, `name` is retained for display/search. ## Test plan - `twenty-shared` unit tests (resolver) ✅ - `typecheck` + `lint:diff-with-main` green on `twenty-front`, `twenty-server`, `twenty-shared` ✅ - Reset + reseed a workspace: `kind` is populated for all seeded rows (recordChange / linkedMessage / linkedNote / linkedTask / linkedCalendarEvent) with no nulls ✅ - Manual end-to-end verification via Playwright on person / company record timelines — screenshots in a follow-up comment. Screenshots attesting the rendering (incl. the calendar fix) are posted as a comment below. --- _Generated by [Claude Code](https://claude.ai/code/session_01YRueWMo4UyaX2em8R2cdio)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21950?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-23 16:59:09 +02:00
Paul Rastoin	e9d5d71cd3	Wire up search field metadata (#21964 ) ## Part 1 - Exact scope of the current PR (#21964) close https://github.com/twentyhq/core-team-issues/issues/2586 This PR introduces `searchFieldMetadata` as a first-class flat metadata entity and migrates the existing search surface onto it, with no change to which records are searchable (ISO with `main`). In scope (what the PR does): - New flat entity `searchFieldMetadata` (universalIdentifier, applicationId, `position`, maps, conversions), registered in the central flat-entity constants and the migration build orchestrator. - `searchVector.asExpression` is derived server-side from `searchFieldMetadata` rows (validated by `isSafeTsVectorExpression`); never trusted from client input. - Derivation order is deterministic, driven by each row's `position` ([compute-search-vector-as-expression-from-search-field-metadatas.util.ts](packages/twenty-server/src/engine/metadata-modules/flat-search-field-metadata/utils/compute-search-vector-as-expression-from-search-field-metadatas.util.ts)), replacing the previous non-deterministic `(createdAt, id)` sort. That sort collapsed to random UUIDs for standard fields (same `createdAt`), so any rename/relabel rewrote the `STORED` generated column to a logically-identical-but-textually-different expression and produced a permanent per-workspace diff vs the standard definition. Ordering now equals provisioning order; ties break on `universalIdentifier`. - Provisioning at object creation mirrors the existing surface exactly and seeds `position`: - custom objects -> the `name` field only, at `position: 0` ([build-default-search-field-metadatas-for-custom-object.util.ts](packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/build-default-search-field-metadatas-for-custom-object.util.ts)) - standard objects -> their curated `SEARCH_FIELDS_FOR_` sets, `position` = the curated index - Backfill (instance + workspace commands in `2-16`) provisions rows for existing workspaces with the same surface and the same positions* (standard from the curated standard maps, custom `name` = `0`), scoped to the workspace's own custom application ([build-search-field-metadata-backfill-operations.util.ts](packages/twenty-server/src/database/commands/upgrade-version-command/2-16/utils/build-search-field-metadata-backfill-operations.util.ts)). The `position` column is added in the same `2-16` fast instance command as `universalIdentifier`/`applicationId`. - Field rename of an already-indexed field recomputes `asExpression` (positions preserved, so order is stable) ([recompute-search-vector-on-field-rename.util.ts](packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/recompute-search-vector-on-field-rename.util.ts)). - Field delete drops the matching row(s) and recomputes; remaining rows keep their relative order (no renumber) ([from-delete-field-input-to-flat-field-metadatas-to-delete.util.ts](packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/from-delete-field-input-to-flat-field-metadatas-to-delete.util.ts)). - Object relabel is additive and ISO/regression-fix only: it indexes the new label identifier appended last (`position = max(existing) + 1`) without dropping `name` ([recompute-search-vector-on-label-identifier-update.util.ts](packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/recompute-search-vector-on-label-identifier-update.util.ts)). This is a deliberate, temporary bridge. Explicitly OUT of scope (deferred): - No API to edit `searchFieldMetadata` (no user-facing search-field configuration, including `position` — it is internal and only written by provisioning/backfill/recompute). - No auto-indexing of arbitrary searchable fields. Creating a custom TEXT/EMAILS/etc. field does NOT add it to search (the `computeSearchFieldMetadataCreationForFields` behavior was removed in `e6820ad`). - No field-type-transition handling (field type is immutable - not in `FLAT_FIELD_METADATA_EDITABLE_PROPERTIES`, so that path was dead code). - No `position` validation (uniqueness/range) and no multi-vector / per-field `weight` config — deferred to the configurable-search follow-up (#1428). Net: `searchFieldMetadata` becomes the source of truth for the same surface as `main`. The only intentional divergences from `main` are "relabel preserves `name`" (additive) and the deterministic `position`-ordered `asExpression` (a correctness/perf fix that is byte-identical to provisioning order, so it does not change the searchable surface). --------- Co-authored-by: Félix Malfait <felix@twenty.com>	2026-06-23 16:27:13 +02:00
Parship Chowdhury	c18787350f	fix: month and year dropdowns in settings logs date picker (#21529 ) ### Summary - Fixes #21514 and Issue 2 - Issue 1: when opening the calendar and choosing a month or year, those lists could appear underneath the calendar, making them impossible to see and use. (Issue #21514) - Issue 2: after opening the calendar icon menu, clicking the month or year controls don't work, so you couldn’t actually change the month or year. Before: <img width="355" height="434" alt="607363028-0d3a302e-9dba-4d9a-b354-ad7cbcd1fba5" src="https://github.com/user-attachments/assets/b1c357d1-a7cf-4572-8737-721cf4e2597a" /> After: https://github.com/user-attachments/assets/ffc26447-ff34-4f11-a3b4-4c329e446ec4 <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21529?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> --------- Signed-off-by: Parship Chowdhury <parshipchowdhury@gmail.com> Co-authored-by: Charles Bochet <charles@twenty.com>	2026-06-23 11:40:27 +02:00
avonian	47b48d83f7	fix(front): include isUIEditable/isRemote in CreateOneObjectMetadataItem so new objects aren't read-only until refresh (#21796 ) ## Problem After creating a custom object in Settings → Data Model, the new object's "New Field" (and "Add relation") buttons are missing. They only appear after a hard page refresh. ## Root cause `CreateOneObjectMetadataItem` (`packages/twenty-front/src/modules/object-metadata/graphql/mutations.ts`) selected only a subset of object-level fields and omitted `isUIEditable`, `isRemote`, `isSystem`, `isUICreatable`, `universalIdentifier`, `shortcut`, and `duplicateCriteria` — all of which are present in the shared `ObjectMetadataFields` fragment used by the bootstrap query. `useCreateOneObjectMetadataItem` writes the mutation response into the metadata store via `addToDraft`. Because the mutation resolves after the SSE create event and `addToDraft` replaces entries by `id`, the reduced mutation response overwrites the fuller record that arrived over SSE. The stored object then has `isUIEditable === undefined`, so `isObjectMetadataReadOnly` returns `true` (`!undefined`), and `ObjectFields` hides the action buttons via its `{!readonly && …}` guard. A hard refresh "fixes" it only because the bootstrap query repopulates the store from `ObjectMetadataFields`, which includes the missing fields. ## Fix Add the missing object-level fields to the `CreateOneObjectMetadataItem` selection so a newly created object matches the bootstrap shape, and regenerate the metadata GraphQL types. No other code changes required. ## How to test 1. Go to Settings → Data Model and create a new custom object. 2. Open the new object's Fields tab. 3. ✅ The "New Field" button is visible immediately — no refresh needed. Before this change, the button was hidden until a manual refresh. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21796?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-23 10:46:16 +02:00
Félix Malfait	0e6d96bb5e	fix(workflow): stop trigger/action filter Conditions from flashing on edit (#21952 ) ## Problem Adding a condition to a database-event trigger (the new Conditions section), the Filter action, or the If/Else action causes the just-added condition to flash out and back in. ## Root cause `WorkflowEditActionFilterBodyEffect` seeds the builder's local jotai atoms from the persisted `defaultValue` through an effect that resynced whenever the live atoms differed from `defaultValue` (the atoms were in the effect deps and the equality check compared atoms vs `defaultValue`). A local edit writes the atoms synchronously, then persists through an async mutation — and for an active workflow that mutation first creates a draft version over the network. During that window the atoms are ahead of the still-stale `defaultValue`, so the effect treated it as "out of sync" and overwrote the edit back to the stale value, then wrote it again once the save landed. That round-trip is the flash. The resync existed for a real reason: the atoms are module-cached per `instanceId` and persist across mounts, and the trigger shares a single constant `instanceId` (`'trigger'`), so a previous trigger's filters must be overwritten when a different one is opened. (This is also why the `?? { stepFilterGroups: [], stepFilters: [] }` fallback was added in #21868 — to reset builder state deterministically between trigger edits.) So a naive "init-once" fix would reintroduce that stale-state leak. ## Fix Resync from `defaultValue` only when `defaultValue` itself changes, tracked via the last-synced value in `useState` (not the live atoms). This: - never clobbers an in-flight local edit → no flash; - still re-seeds when switching the trigger/action being edited → no stale-state leak; - preserves reflecting genuine external `defaultValue` changes. The `hasInitialized` flags are no longer needed and are removed (along with the now-unused `stepId` prop on the effect). ## Tests Adds a regression test covering: seeding from `defaultValue` on mount, the no-clobber-while-stale* invariant (the flash), and resync on a genuine `defaultValue` change. Verified the no-clobber test fails against the old "resync against live atoms" behavior and passes with the fix. ## Verification - `nx typecheck twenty-front` ✅ - `nx lint:diff-with-main twenty-front` ✅ (0 warnings / 0 errors) - New unit test: 3 passing ✅ ## Known residual / follow-up On an active workflow, the first edit creates a draft version over the network; making a second edit before that round-trip completes leaves a narrow window where the optimistic echo of the first value could momentarily win. Far narrower than the current flash-on-every-edit. Eliminating it entirely (and resolving the still-open HIGH-severity "constant `instanceId`" review flag from #21868) would mean giving the trigger a unique `instanceId` per workflow version + a React `key` to reset on remount — proposed as a separate, scoped follow-up. https://claude.ai/code/session_01XnjtzFepMJX2VFwnQVcQbV --- _Generated by [Claude Code](https://claude.ai/code/session_01XnjtzFepMJX2VFwnQVcQbV)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21952?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-23 10:44:56 +02:00
neo773	9e31ffdf68	feat(messaging): webhook push sync for Gmail, Calendar and Microsoft (#21970 ) <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21970?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-23 14:04:16 +05:30
Priyanshu Bartwal	6e7d8ef96c	[Twenty-front]: Record table Header drag and drop functionality (#21304 ) Closes #21303 and https://github.com/twentyhq/core-team-issues/issues/151 https://github.com/user-attachments/assets/45cee1be-464f-467e-a1c0-cf5354ff87db --------- Co-authored-by: Charles Bochet <charles@twenty.com>	2026-06-23 08:37:04 +02:00
Félix Malfait	46642c81c9	fix(front): unblock email verification on the central domain (blank modal) (#21980 ) ## Problem After clicking the email-verification link on the central domain (e.g. `app.twenty.com/verify-email?...`), a new user is left staring at a blank white auth modal and onboarding never continues. The email is actually verified — the user is just never moved off the verify-email page. ## Root cause `VerifyEmailEffect` (mounted on `/verify-email`) handles the central/workspace‑agnostic domain like this: ```tsx if (!isOnAWorkspace) { await verifyEmailAndGetWorkspaceAgnosticToken(emailVerificationToken, email); return enqueueSuccessSnackBar(successSnackbarParams); } ``` It renders nothing of its own in this branch (`return <></>`) and relies entirely on the auth hook to navigate. The onboarding workspace-creation refactor (#21641 "Let users pick their workspace subdomain during sign-up", refined by #21723) changed `navigateAfterMultiWorkspaceSignInUp`: - Before: a user with `0` workspaces was sent through `createWorkspace()`, which created the workspace and redirected to the workspace subdomain — navigating away from `/verify-email`. - After: for multi-workspace it now only does `setSignInUpStep(SignInUpStep.WorkspaceCreation)` (the new name/subdomain/logo form) — no navigation. `signInUpStepState` is read only by the `SignInUp` page (`/sign-in-up`), which renders `SignInUpWorkspaceCreationForm` for that step. But the user is on `/verify-email`, whose route renders only `VerifyEmailEffect` — which knows nothing about the step state and returns an empty fragment. Nothing bridges the gap (`usePageChangeEffectNavigateLocation` also won't redirect, because `/verify-email` is whitelisted in `ONGOING_USER_CREATION_PATHS`), so the user is stuck on an empty modal. ### Scope of the breakage - Broken: new user, multi-workspace instance (Twenty Cloud central domain), email verification enabled, signing up to create a workspace (`0` workspaces). The `2+`-workspaces case (`WorkspaceSelection`) is the same. - Not affected: the single existing-workspace case (still does a real `redirectToWorkspaceDomain`), the workspace-subdomain verification path (`verifyEmailAndGetLoginToken` → `verifyLoginToken`), and single-workspace self-host. ## Fix After a successful workspace-agnostic verification, hand off to the `SignInUp` page so it mounts and renders whatever step the hook just set: ```tsx if (!isOnAWorkspace) { await verifyEmailAndGetWorkspaceAgnosticToken(emailVerificationToken, email); enqueueSuccessSnackBar(successSnackbarParams); return navigate(AppPath.SignInUp); } ``` This is intentionally scoped to `VerifyEmailEffect` (the only entry point that lives on a route which doesn't host the sign-in-up step UI). The in-app sign-in/sign-up callers of `navigateAfterMultiWorkspaceSignInUp` are already on `/sign-in-up`, so they're untouched — keeping their query params (invite tokens, billing checkout, returnToPath) intact. For the single existing-workspace edge case, the hook's redirect still wins. ## Testing - New `VerifyEmailEffect.test.tsx`: - central-domain success → navigates to `AppPath.SignInUp` + shows the success snackbar; - failure → does not hand off to `SignInUp` (error state is shown); - workspace subdomain → workspace-scoped path is untouched (no workspace-agnostic call, no `SignInUp` hand-off). - `nx typecheck twenty-front` ✅, `oxlint --type-aware` + `oxfmt` on changed files ✅. https://claude.ai/code/session_017oVwW12hC42RdCgSKK8dFP --- _Generated by [Claude Code](https://claude.ai/code/session_017oVwW12hC42RdCgSKK8dFP)_ <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21980?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-23 08:19:33 +02:00
neo773	242b989c0e	fix(emails): stop reply composer infinite re-render (#21935 ) <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21935?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-23 00:57:54 +02:00
mfamularopsyc	d2083e7a1b	Set OpenAI Responses store false for AI chat and agents (#20888 ) ## Summary This PR sets `openai.store = false` for Twenty's `@ai-sdk/openai` AI calls. This follows the approach discussed in #20877: instead of adding a new Twenty-specific Zero Data Retention config variable, OpenAI Responses calls no longer rely on OpenAI-stored response/item references. This should help Zero Data Retention organizations and may also avoid stale persisted-item replay errors for non-ZDR OpenAI users. Changes included: - Adds a shared OpenAI provider-options helper that merges `openai.store = false` for `@ai-sdk/openai` models. - Applies the helper to AI chat `streamText` calls. - Applies the helper to workflow/agent `generateText` calls. - Preserves OpenAI encrypted reasoning metadata through DB/UI message mappers so reasoning context can be replayed without stored OpenAI item references. - Does not add a new env/config variable. Related to issue #20877. ## Behavior / Tradeoffs This changes OpenAI Responses behavior for all Twenty OpenAI users, not only ZDR users. The intended benefit is that Twenty no longer depends on OpenAI-stored response/item references. The main tradeoff is reduced provider-side item-reference reuse for non-ZDR OpenAI users. To reduce the impact for reasoning models, this PR preserves `providerMetadata.openai.reasoningEncryptedContent` through message persistence/replay so reasoning context can still be provided without stored OpenAI item references. ## Tests - Focused server Jest tests for OpenAI provider-options merging and reasoning metadata mapping. - Focused frontend Jest test for reasoning metadata mapping. - `oxlint` and `oxfmt --check` on changed files. - `git diff --check`. --------- Co-authored-by: Charles Bochet <charles@twenty.com> Co-authored-by: Etienne <45695613+etiennejouan@users.noreply.github.com>	2026-06-22 17:26:02 +00:00
Raphaël Bosi	5f22908588	Decouple twenty-ui Avatar from app server-URL config (#21968 ) Makes `twenty-ui`'s `Avatar` render the `avatarUrl` it receives instead of building it from `window._env_`/`window.location` at module load, so the library no longer depends on the app environment. URL resolution moves to `twenty-front` via a `getAbsoluteImageUrl` helper applied at the call sites. Part of making twenty-ui a standalone library.	2026-06-22 18:38:00 +02:00
Marie	96a2987610	Fix/sanitize chart filters on save (#21958 ) # Fix: sanitize chart filters referencing deactivated/deleted fields ## Summary When a field used in a chart (graph) widget filter was later deactivated or deleted, saving the page layout failed with a backend error such as: > Chart "...": One of the chart filters uses "...", but it was deleted. Please remove or replace this filter rule. This happened even after the user tried to remove the offending filter rule, because the invalid filter could still end up in the saved configuration. This PR makes invalid chart filters get cleaned up reliably — both as the user edits filters and, as a safety net, at save time. ## Root causes - Edit-time persistence kept invalid filters. `handleFiltersUpdate` persisted the current filter state to the page layout draft without sanitizing it against the object's active fields. An invalid filter (referencing a deactivated/deleted field) was re-saved on every update, blocking the configuration from being accepted. - Save never enforced the cleanup. `useSavePageLayout` serialized the draft as-is. The "filters referencing deactivated/deleted fields will be automatically removed on save" promise shown in the warning banner was only honored reactively (when the filter panel was actively edited), never at the actual save boundary. A chart whose filter panel wasn't touched kept its stale invalid filter in the payload. - Query time treated inactive fields as valid. `useGraphWidgetQueryCommon` considered all fields (including inactive ones) valid, so deactivated-field filters were never dropped when running the chart query. ## Changes ### Edit-time (keeps draft and UI in sync as you edit) - `ChartFiltersSettings` — sanitize filters in `handleFiltersUpdate` before writing to the draft, dropping any filter whose `fieldMetadataId` is not in the active-fields set. - `dropChartRecordFiltersWithDeletedFields` — enhanced to also clean up filter groups left orphaned once invalid filters are removed (iteratively removing empty groups and re-parenting checks). - `useGraphWidgetQueryCommon` — restrict valid field IDs to `isActive` fields so deactivated-field filters are silently dropped at query execution. - `ChartFiltersDeletedFieldsWarning` — updated copy to mention both deactivated and deleted fields. ### Save-time safety net (guarantees no invalid filter is ever persisted) - New `sanitizeChartFiltersInPageLayoutDraft` util — walks every chart widget in the draft and drops record filters (and now-orphaned groups) whose `fieldMetadataId` is not in the widget object's set of active fields. It leaves non-chart widgets untouched and leaves filters intact when the object metadata can't be resolved (avoids wiping valid filters during metadata loading). - `useSavePageLayout` — builds a `Map<objectMetadataId, Set<activeFieldId>>` from `useObjectMetadataItems()` and sanitizes the draft before converting it to the update input. This layer only ever removes filters whose field is genuinely deactivated/deleted — the exact set the backend rejects — and never removes filters pointing at valid fields. ## Tests - `dropChartRecordFiltersWithDeletedFields.test.ts` — extended coverage for orphaned filter-group cleanup. - `sanitizeChartFiltersInPageLayoutDraft.test.ts` — new: drops deactivated/deleted-field filters on save, keeps valid filters, cleans up orphaned groups, leaves non-chart widgets alone, and leaves filters untouched when object metadata is unresolved. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21958?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> --------- Co-authored-by: Charles Bochet <charles@twenty.com>	2026-06-22 18:15:33 +02:00
Thomas des Francs	6ce7d04f9d	Fix field widget textarea focus reset (#21959 ) Short description: Keeps the field widget textarea on a local draft value while focused so record-store rewrites do not reset the active caret. # Before Typing in an editor-mode text field can lose caret position when the global record store is rewritten by an external record update/refetch. https://github.com/user-attachments/assets/1ee7a819-2c27-4d09-aae5-814c2cf27181 # After The focused textarea should preserve the in-progress draft and caret while still updating sibling previews optimistically and flushing the final value on blur. https://github.com/user-attachments/assets/41832493-021f-46e8-bc75-722bbb1cd7b7 <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21959?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->	2026-06-22 17:45:49 +02:00

1 2 3 4 5 ...

6121 Commits