houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,366 Commits 1 Branch 0 Tags
ce045db15abe1111cbdfdfe80f7647cb69a67f21
Commit Graph

3418 Commits

Author SHA1 Message Date
Charles Bochet 52e5f7daeb Unselect record table records on table body click (#8306) 
We have previously fixed the unselection of table records on click
outside. However, the ref was mispositioned as it selected the full
height table. In the case of low record numbers, we also want the
unselection to happen on table body click
 2024-11-04 17:44:50 +01:00
martmull 695991881f 6071 return only updated fields of records in zapier update trigger (#8193) 
- move webhook triggers into `entity-events-to-db.listener.ts`
- refactor event management
- add a `@OnDatabaseEvent` decorator to manage database events
- add updatedFields in updated events
- update openApi webhooks docs
- update zapier integration
 2024-11-04 17:44:36 +01:00
Marie 741020fbb0 Fix gap in object edition page (#8310) 
Fixing 

![image](https://github.com/user-attachments/assets/794968c2-1d13-49f2-9367-e93285a7d10f)

Note - this page design be updated in the next release
(https://github.com/twentyhq/twenty/pull/7979)
 2024-11-04 17:36:03 +01:00
Marie 76e8bf33ac Fix relation picker for activity target (#8303) 
[This PR](https://github.com/twentyhq/twenty/pull/8210) introduced a
regression, causing noteId or taskId (respectively for noteTarget or
taskTarget creation) to be overwritten with an undefined value in the
input for noteTarget or taskTarget creation.
This is because in ActivityTargetInlineCellEditMode, in addition to the
noteId and taskId we are declaring, we are looking into the object
(noteTarget or taskTarget)'s fields and prefilling the record-to-create
with a value, potentially undefined, for all of the object fields.
So when looping over noteTarget's fields, we would find the `note`
relation field, and eventually add `note: undefined` to the
record-to-create input, in addition to the non-empty and valid existing
`noteId`.
Then in sanitizeRecordInput, from the note added right above, we add an
empty noteId to the input from node, overwriting the "good" noteId.

There are several ways to fix this, I chose to update prefillRecord not
to add an empty "note" object that makes no sense in addition to the
"noteId" we already have at this stage.
It is also possible to update `sanitizeRecordInput` not to overwrite a
value from a relation (noteId from note relation) if there is already a
value in the input.
 2024-11-04 14:39:48 +01:00
Jérémy M 258fd07839 feat: use new component state api for record table (#8143) 
This PR drop the use of the old component state api in favour of the new
component state api V2.
 2024-11-04 12:07:07 +01:00
Hitarth Sheth b66bdd9de5 [FIX] remove blue outline for Phones, Emails, and Domains fields (#8268) 
FIX: #8252

---------

Co-authored-by: Félix Malfait <felix@twenty.com>
 2024-11-04 08:32:27 +01:00
Félix Malfait 558cc6810e Fix assignee not displayed on tasks (#8280) 
Fix an issue where the assignee of a task wasn't displayed on the task
record's show page
 2024-11-01 18:26:56 +01:00
Raphaël Bosi 234a5db80c Fix hotkey scope when opening command menu (#8258) 
Fix hotkey scope when opening command menu
 2024-11-01 09:25:10 +01:00
Lucas Bordeau c93d2bcd5e Fixed many dropdown bugs (#8256) 
Many dropdown bugs have been fixed, more refactoring is needed.

Dropdown fixed : 
- Filter select
- Sort select
- Visible field select
- Hidden field select
- Multi item picker (phones, links, emails, etc.)
- Phone country select
 2024-11-01 09:23:01 +01:00
Charles Bochet a287edd91b Kanban full name (#8261) 2024-11-01 09:19:55 +01:00
NitinPSingh e5641c5c53 fix #7085 breadcrumb fix for mobile viewport (#7419) 
ISSUE
Closes https://github.com/twentyhq/twenty/issues/7085

DEMO 


https://github.com/user-attachments/assets/39692906-c02e-4e4c-9205-82447fa142df

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-10-31 17:17:13 +00:00
Thomas Trompette 74291e531c Fix storybook tests (#8260) 
Before 
<img width="717" alt="Capture d’écran 2024-10-31 à 16 58 34"
src="https://github.com/user-attachments/assets/b8ec61f3-11c2-497f-9e4f-183b7989fb59">

After
<img width="717" alt="Capture d’écran 2024-10-31 à 16 58 14"
src="https://github.com/user-attachments/assets/8e0a1fbf-19c4-4cd0-ab7b-58ebb5ded1f5">



Before
<img width="586" alt="Capture d’écran 2024-10-31 à 16 57 59"
src="https://github.com/user-attachments/assets/eb6caf91-3953-4a8f-a847-17a50cc40d02">

After
<img width="586" alt="Capture d’écran 2024-10-31 à 16 57 29"
src="https://github.com/user-attachments/assets/9eee3502-66b4-41c9-a924-b5d3ddb921e3">
 2024-10-31 17:19:44 +01:00
Raphaël Bosi b1a96e2e04 Fix logged out scopeId error (#8250) 
Fix logged out scopeId error
 2024-10-31 15:01:54 +01:00
Harshit Singh c9fcce6590 fix: Emails input field stays in errored state (#8243) 
## Description

- This PR fixes the issue #8235 
- Error state resets when error state is removed

## Changes



https://github.com/user-attachments/assets/0aeb99fe-56c8-437a-ad2c-97e245a44158
 2024-10-31 13:26:59 +01:00
Charles Bochet 034e558758 Deprecate useListenClickOutsideByClassNameListener (#8242) 2024-10-31 12:46:21 +01:00
Lucas Bordeau d46820472c Fix view filter creation on new view (#8199) 
Wrong view was used for the creation from another view (source and
target view were inverted)
 2024-10-31 12:44:20 +01:00
Baptiste Devessier b3f95d6db9 Ensure the text of select control is aligned on the left (#8238) 
Fixes:


![image](https://github.com/user-attachments/assets/900596ed-1426-49cd-a2f3-4b81eacbb7d0)

The regression is due a recent change I made to the SelectControl
component: https://github.com/twentyhq/twenty/pull/8125.

The SelectControls get applied `text-align: center` due to the styles
`react-datepicker` applies to the header component. My grid
implementation makes the label take all the available width. I could
have let it take an `auto` width, but I think it's better to set the
`text-align` property and ensure the `SelectControl` component behaves
predictably.
 2024-10-31 12:03:45 +01:00
Raphaël Bosi b1e9922660 Fix context store filters (#8236) 
Fix context store filters
 2024-10-31 11:51:51 +01:00
Baptiste Devessier d0dc8bae4f Fix save record table cell when clicking outside table (#8230) 2024-10-31 11:45:40 +01:00
Thomas Trompette f5bde0251b Put back object type in settings form (#8234) 
Before
<img width="673" alt="Capture d’écran 2024-10-31 à 11 15 27"
src="https://github.com/user-attachments/assets/78d81f5b-88c0-40b7-8901-104365ecdd49">


After
<img width="673" alt="Capture d’écran 2024-10-31 à 11 15 07"
src="https://github.com/user-attachments/assets/9427da22-a75b-4257-b948-28807b110b26">
 2024-10-31 10:27:54 +00:00
Charles Bochet 99837f9752 Fix integration tests (#8229) 
Removing leftovers of the deprecated "activity" object which is fixing
our integration tests
 2024-10-31 10:36:29 +01:00
Marie e5d492d09f Fix empty option selected in single entity select (#8208) 
SingleEntitySelect was wrongfully showing the empty option (eg "No
company") as selected if the selected option was not showing in the
list, because of a search filter for instance (eg selected option is
"Linkedin" but search filter is "a").

Fixing this and removing misleading prop selectedEntity from components
where it is never passed.
 2024-10-31 09:41:44 +01:00
Thomas Trompette c7c16f7114 Fix date picker size (#8216) 
<img width="760" alt="Capture d’écran 2024-10-30 à 16 54 19"
src="https://github.com/user-attachments/assets/b9b0f717-d93e-48d4-9df5-b817eab5b704">
 2024-10-30 17:34:05 +01:00
Raphaël Bosi 7a5d52e88d Update action menu bar (#8178) 
Closes #8023
 2024-10-30 17:22:42 +01:00
Marie 7dfde04957 Fix advanced settings display (#8196) 
In [this PR (fix navigation
overflow)](https://github.com/twentyhq/twenty/pull/7795) we introduced a
regression, hidding the left-side animation with advanced settings:
<img width="285" alt="Capture d’écran 2024-10-30 à 12 56 22"
src="https://github.com/user-attachments/assets/46d7b1e5-4759-42e9-9bcb-aaa0fedfe542">

<img width="274" alt="Capture d’écran 2024-10-30 à 12 56 31"
src="https://github.com/user-attachments/assets/d3c3d337-f6fc-4509-a920-4c2c7506f061">
 2024-10-30 16:18:44 +00:00
martmull 7f90ac2df8 Handle case where fieldValue is null (#8210) 
Allow null values when updating relation to fix detach action
 2024-10-30 16:53:02 +01:00
Charles Bochet b7d5c05a74 Fix front tests (#8207) 2024-10-30 15:50:56 +01:00
Félix Malfait 50c912d57f Delete unused objects (#7823) 
Fixes #7113

---------

Co-authored-by: Weiko <corentin@twenty.com>
 2024-10-30 13:35:43 +01:00
Lucas Bordeau 1782865ff8 Added feature flag for advanced filter (#8194) 
Added feature flag for advanced filter
 2024-10-30 12:06:46 +01:00
Baptiste Devessier d887a857ca Revert "fix: Country Dropdown not closing with AddressInput " (#8174) 
Reverts twentyhq/twenty#8147
 2024-10-29 15:55:18 +01:00
Raphaël Bosi fe2c8bb43b 7339 implement contextual actions inside the commandmenu (#8000) 
Closes #7339


https://github.com/user-attachments/assets/b623caa4-c1b3-448e-8880-4a8301802ba8
 2024-10-29 15:10:45 +01:00
Muhammad Abdullah 77a4aa2649 added light background for better hover visibility on dark theme (#8043) 
fixes: #7969 

## What does this PR do?

Apply a lighter background color to enhance the hover effect in dark
mode.


![twenty-hover](https://github.com/user-attachments/assets/3d218060-2328-481e-9e66-250abd276dc0)
 2024-10-29 10:42:04 +00:00
Antoine Moreaux 2e10070fdb fix(sso): improve enterprise key var management (#8152) 
Resolve https://github.com/twentyhq/twenty/issues/8070

---------

Co-authored-by: Félix Malfait <felix@twenty.com>
 2024-10-29 11:39:00 +01:00
Sanskar Jain 95b475c855 Fixes "No Result" flash and add a separator (#8140) 
Fix for #8137

---------

Co-authored-by: Félix Malfait <felix@twenty.com>
 2024-10-29 11:36:25 +01:00
Harsh Singh c0484aa9a2 fix: dropdown max-height and padding bottom (#8167) 
Fixes: #6105 

Also fixed side effect due to previous PR:

[Screencast from 2024-10-29
13-54-44.webm](https://github.com/user-attachments/assets/f15db853-ca1c-4be8-9362-610122c4d988)
 2024-10-29 11:00:35 +01:00
Harshit Singh 7901dbc02f fix: Country Dropdown not closing with AddressInput (#8147) 
## Description

- This PR fixes #8080 
- The Country Selector dropdown closes with Address Input `clickOutside`
function

## Changes


https://github.com/user-attachments/assets/1ab85175-9ce9-40d2-ac52-14bfe87e254f

---------

Co-authored-by: Devessier <baptiste@devessier.fr>
 2024-10-29 10:03:28 +01:00
martmull 94f2e1067b Revert "fix: dropdowns should have a max-height & padding from screen" (#8165) 
Reverts twentyhq/twenty#8055
 2024-10-29 08:54:16 +00:00
Reese is on Codeberg a725245c2f Add padding to navigation header (#8050) 
This PR adds padding to the header to align the logo with other icons on
the sidebar.

## Before


![image](https://github.com/user-attachments/assets/6501bbbf-bf06-4d9f-bff7-2d36c1b63a37)


## After


![image](https://github.com/user-attachments/assets/24610cf8-eab2-49bd-b611-e68a66228fd6)

---------

Co-authored-by: martmull <martmull@hotmail.fr>
 2024-10-29 07:56:16 +00:00
Thomas Trompette 409def8431 Fix manual trigger output schema (#8150) 
- add schema for manual trigger
- split into sub functions
- handle case with no variables
 2024-10-28 17:42:09 +00:00
Sanskar Jain 69c24968c1 fix for horizontal bar while login in (#8073) 
Fix for #8071

---------

Co-authored-by: martmull <martmull@hotmail.fr>
 2024-10-28 17:07:00 +00:00
Harsh Singh e648d942a2 fix: dropdowns should have a max-height & padding from screen (#8055) 
Fixes: #6105 

### Problem

- The dropdown gets clipped when the number of filters increases. 

### Solution

- Added scroll property to the ```DropdownMenu``` 
- Added size middleware to the floating UI hook.
- Provided padding of 20px to the size middleware, so that it maintains
distance from the bottom of the screen.

[Screencast from 2024-10-25
13-47-04.webm](https://github.com/user-attachments/assets/c2315ee2-6092-4c4a-8126-dba7ac3bf49b)

---------

Co-authored-by: martmull <martmull@hotmail.fr>
 2024-10-28 16:59:57 +00:00
Harshit Singh cabae4c462 fix: TimeZone dropdown clips through screen in Mobile viewport (#7935) 
## Description

- This PR fixes the issue #7934

---------

Co-authored-by: martmull <martmull@hotmail.fr>
 2024-10-28 16:11:41 +00:00
Balaji Krishnamurthy ca54bc1813 Fix country selector text overflow issue (#8125) 
Closes #7906 

Modified the two children(`TextInputV2` and `CountrySelect`) in the
`StyledHalfRowContainer` component to always be equal in size and divide
the available space equally.
The `StyledIconChevronDown` component has a `flex-shrink: 0` to prevent
it from completely disappearing. The same applies for the
`selectedOption.Icon`.
A `p` tag had to be added to the label to correctly handle the text
overflow.

---------

Co-authored-by: Devessier <baptiste@devessier.fr>
 2024-10-28 16:20:29 +01:00
Thomas Trompette 2ba98ddadd Handle NBSP in tiptap parsing (#8148) 
Tiptap uses non breaking spaces between nodes (like variables). Those
html characters are not properly handles in emails. Replacing by regular
spaces during parsing.

I tried to fix it in settings but looks like this is only for preserving
those nbsp and not for removal (see
https://github.com/ueberdosis/tiptap/pull/254)
 2024-10-28 15:50:14 +01:00
gitstart-app[bot] fc8c9d9167 Migrate to twenty-ui - input components (#7914) 
### Description

Migrate Input components: 

- CardPicker
- Radio
- RadioGroup
- Checkbox
- Toggle
- IconListViewGrip

### Demo

Radio Component on Storybook


![](https://assets-service.gitstart.com/4814/2d0c7436-9fab-4f3d-a5c4-be874e885789.png)

Checkbox component on Storybook


![](https://assets-service.gitstart.com/4814/07bcc040-cc92-4c7e-9be8-ca1a5f454993.png)

###### Fixes twentyhq/private-issues#92

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
 2024-10-28 15:36:58 +01:00
BOHEUS f9779c4b5e CreateWorkspace typo fix (#8146) 
Follow up of #8115
 2024-10-28 14:13:57 +01:00
gitstart-app[bot] 9b6359984d Migrate to twenty-ui - input/code-editor (#8072) 
This PR was created by [GitStart](https://gitstart.com/) to address the
requirements from this ticket:
[TWNTY-7062](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7062).

 --- 

### Description.  

Migrate `code-editor` component to twenty ui.\
\
Fixes twentyhq/private-issues#94

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
 2024-10-28 13:34:06 +01:00
gitstart-app[bot] fa0933b292 Migrate to twenty-ui - layout/section (#8068) 
This PR was created by [GitStart](https://gitstart.com/) to address the
requirements from this ticket:
[TWNTY-7533](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7533).

 --- 

Description \
\
Move Section component from twenty-front to twenty-ui and update
imports\
\
\
Fixes twentyhq/private-issues#85

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
 2024-10-28 13:08:55 +01:00
martmull 1aa961dedf 101 featch available variables from previous steps (#8062) 
- add outputSchema in workflow step settings
- use outputSchemas to compute step available variables


https://github.com/user-attachments/assets/6b851d8e-625c-49ff-b29c-074cd86cbfee
 2024-10-28 11:25:29 +00:00
Igor Kowalski 3ae987be92 folderStructure.json refactor (#8088) 
#7911 

If you encounter any issues or have any questions regarding the library,
feel free to write
[here](https://github.com/Igorkowalski94/eslint-plugin-project-structure/discussions/new?category=help),
I’d be happy to help.
 2024-10-28 12:06:58 +01:00