houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,832 Commits 1 Branch 0 Tags
4af2c5f2983fee90f16dcc4d094e4625648f3cea
Commit Graph

49 Commits

Author SHA1 Message Date
Charles Bochet d07dc11124 Fix activity Target picker not being displayed (#5040) 
<img width="1025" alt="image"
src="https://github.com/twentyhq/twenty/assets/12035771/3f37ed27-661e-43ea-bc15-f59efa12bfca">
 2024-04-18 16:16:12 +02:00
martmull 1c1a055c94 Improve multi word filtering (#5034) 
improve multi word search

closes #4212 
closes #3386
 2024-04-18 15:46:59 +02:00
Pacifique LINJANJA 627a6bda29 Update twenty-front commands (#4667) 
# This PR

- Moves dev and ci scripts to the `project.json` file in the
twenty-front package
- Adds a project.json file in the root of the project with the main
start command that start both twenty-server and twenty-front
applications concurrently
- Updates the script command of the root project with the start:prod
command (replacing the start command which will be used in dev with the
help of nx)
- Add a start:prod command in the twenty-front app, replacing the start
command (now used for dev purpose)

Issue ref #4645 

@charlesBochet @FelixMalfait please let me know how can I improve it

---------

Co-authored-by: Thaïs Guigon <guigon.thais@gmail.com>
 2024-04-17 18:06:02 +02:00
Charles Bochet 75fd430149 Increase storybook pages coverage (#4885) 
On FE:
- refreshing metadata mocks
- updating jest tests
- fixing storybook pages coverage
- fixing storybook modules coverage
 2024-04-17 16:24:04 +02:00
Ashutosh Gupta 340af9a244 fix: Auto Reset Opportunity Creation Search Field (#4951) 
## Description

In the previous implementation, we saved the user's search field input.
However, I have introduced a new prop called `clearOnOpen`, which allows
us to reset the search field upon loading.

Closes: #4923 



https://github.com/twentyhq/twenty/assets/95065270/dd2cab30-ea47-444e-b356-d5c98087bcc6

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
 2024-04-17 11:31:33 +02:00
bosiraphael d7d9f0c16b Fix ParticipantChip and stories imports (#4974) 
- Fix ParticipantChip
- Fix stories imports after some component have been moved to twenty UI
 2024-04-15 18:09:05 +02:00
Thaïs b6d0b8a895 refactor: move Checkmark, Avatar, Chip and Tooltip to twenty-ui (#4946) 
Split from https://github.com/twentyhq/twenty/pull/4518

Part of #4766
 2024-04-15 12:05:06 +02:00
Thaïs 9f83cc1426 refactor: move @/ui/display/icon to twenty-ui (#4820) 
Split from https://github.com/twentyhq/twenty/pull/4518

Part of https://github.com/twentyhq/twenty/issues/4766
 2024-04-12 15:30:48 +02:00
Lucas Bordeau b1242bb850 4087 refactor object metadata item hooks and utils (#4861) 
- Extracted each exported element from useObjectMetadataItem into its
own hook.
 2024-04-09 09:19:52 +02:00
Dmitriy Voytovich a95972f808 refactor(chore):3896-replace-lodash-debounce-to-useDebounce (#4814) 
Close: #3896 

## PR Details

Changed `lodash.debounce` to `useDebounce`.

Co-authored-by: VoitovychDM <voitovych.dm.m@gmail.com>
 2024-04-05 19:07:44 +02:00
Thaïs bf8ee99ebb chore: use common eslint config for most packages (#4705) 
Split from https://github.com/twentyhq/twenty/pull/4518

Related to #4766 

Mutualizes eslint config between projects.
I didn't include `twenty-server` in this PR as this was causing too many
lint errors.
 2024-04-04 12:05:26 +02:00
Thaïs 5d07b6347e refactor: move Tabler Icon exports to twenty-ui (#4727) 
Split from https://github.com/twentyhq/twenty/pull/4518
 2024-04-01 13:15:47 +02:00
Charles Bochet 02673a82af Feat/put target object identifier on use activities (#4682) 
When writing to the normalized cache (record), it's crucial to use _refs
for relationships to avoid many problems. Essentially, we only deal with
level 0 and generate all fields to be comfortable with their defaults.

When writing in queries (which should be very rare, the only cases are
prefetch and the case of activities due to the nested query; I've
reduced this to a single file for activities
usePrepareFindManyActivitiesQuery 🙂), it's important to use queryFields
to avoid bugs. I've implemented them on the side of query generation and
record generation.

When doing an updateOne / createOne, etc., it's necessary to distinguish
between optimistic writing (which we actually want to do with _refs) and
the server response without refs. This allows for a clean write in the
optimistic cache without worrying about nesting (as the first point).

To simplify the whole activities part, write to the normalized cache
first. Then, base queries on it in an idempotent manner. This way,
there's no need to worry about the current page or action. The
normalized cache is up-to-date, so I update the queries. Same idea as
for optimisticEffects, actually.

Finally, I've triggered optimisticEffects rather than the manual update
of many queries.

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-04-01 13:12:37 +02:00
Charles Bochet cfb0cce9b8 Refactor Views by cleaning the code, relying on apolloCache and improving performances (#4516) 
* Wip refactoring view

* Post merge conflicts

* Fix review

* Add create view capability

* Fix create object missing view

* Fix tests
 2024-03-20 14:21:58 +01:00
Charles Bochet afb9b3e375 Prefetching views and favorites (#4421) 
* wip

* Push

* Complete work on prefetch

* Add comment

* Fix

* Fix

* Fix

* Fix

* Remove dead code

* Simplify

* Fix tests

* Fix tests

* Fix according to review

* Fix according to review

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-03-15 18:35:40 +01:00
Lucas Bordeau 581dfafe11 Renamed nullable utils into isDefined and isUndefinedOrNull (#4402) 
* Renamed nullable utils into isDefined and isUndefinedOrNull
 2024-03-11 14:28:57 +01:00
Charles Bochet ec384cc791 Implement eager load relations on graphqlQueries (#4391) 
* Implement eager load relations on graphqlQueries

* Fix tests

* Fixes

* Fixes
 2024-03-10 23:42:23 +01:00
Charles Bochet 86c0f311f5 Introduce ComponentState (#4386) 
* Proof of concept ComponentState

* Migrate to createState and createFamilyState

* Refactor

* Fix

* Fix tests

* Fix lint

* Fix tests

* Re-enable coverage
 2024-03-09 11:31:00 +01:00
gitstart-app[bot] 17511be0cf TWNTY-3794 - ESLint rule: only take explicit boolean predicates in if statements (#4354) 
* ESLint rule: only take explicit boolean predicates in if statements

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Merge main

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix frontend linter errors

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix jest

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix lint on new code

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
 2024-03-09 10:48:19 +01:00
Thaïs 30df6c10ea test: improve utils coverage (#4230) 
* test: improve utils coverage

* refactor: review - rename isDefined to isNonNullable, update tests and return statement
 2024-02-29 17:03:52 +01:00
gitstart-app[bot] f543191552 TWNTY-3825 - ESLint rule: const naming (#4171) 
* ESLint rule: const naming

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>

* refactor: Reverts changes on `twenty-server`

Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>
 2024-02-25 13:52:48 +01:00
Charles Bochet f68de1a299 Board improvements (#3694) 
* New board improvements

* Improve board

* Fix
 2024-01-30 15:24:03 +01:00
Thomas Trompette 511627ccb8 Fix count avatar color + align thread preview items (#3695) 
Fix count avatar and align items

Co-authored-by: Thomas Trompette <thomast@twenty.com>
 2024-01-30 15:01:12 +01:00
Thaïs 49f33bbe2e fix: fix record deletion optimistic effect (#3683) 
* fix: fix record deletion optimistic effect

* fix: fix renamed method after rebase

* Re-add evict

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
 2024-01-30 09:33:28 +01:00
Lucas Bordeau 3b458d5207 Activity injection into Apollo cache (#3665) 
- Created addRecordInCache to inject a record in Apollo cache and inject single read query on this record
- Created createOneRecordInCache and createManyRecordsInCache that uses this addRecordInCache
- Created useOpenCreateActivityDrawerV2 hook to create an activity in cache and inject it into all other relevant requests in the app before opening activity drawer
- Refactored DEFAULT_SEARCH_REQUEST_LIMIT constant and hardcoded arbitrary request limits
- Added Apollo dev logs to see errors in the console when manipulating cache
 2024-01-29 16:12:52 +01:00
Thaïs a58b4cf437 refactor: apply relation optimistic effects on record update (#3556) 
* refactor: apply relation optimistic effects on record update

Related to #3509

* refactor: remove need to pass relation id field to create and update mutations

* fix: fix tests

* fix: fix SingleEntitySelect glitch

* fix: fix usePersistField tests

* fix: fix wrong import after rebase

* fix: fix several tests

* fix: fix test types
 2024-01-29 08:00:00 -03:00
Charles Bochet 6eca6dc780 Fix Opportunities page (#3660) 
* Fix Opportunities page

* Fix

* Fix tests
 2024-01-28 23:33:36 +01:00
Charles Bochet ada8f55574 Refactor Field Inputs (#3658) 
* Rename field to record-field folder

* Simplify FieldInput

* Fix perfs

* Fixes

* Fixes

* Fix tests

* Fix tests
 2024-01-27 23:42:39 +01:00
Thaïs 014f11fb6f perf: apply record optimistic effects with cache.modify on mutation (#3540) 
* perf: apply record optimistic effects with cache.modify on mutation

Closes #3509

* refactor: return early when created records do not match filter

* fix: fix id generation on record creation

* fix: comment filtering behavior on record creation

* Fixed typing error

* refactor: review - use ??

* refactor: review - add variables in readFieldValueToSort

* docs: review - add comments for variables.first in triggerUpdateRecordOptimisticEffect

* refactor: review - add intermediary variable for 'not' filter in useMultiObjectSearchMatchesSearchFilterAndToSelectQuery

* refactor: review - add filter utils

* fix: fix tests

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-01-23 18:13:00 +01:00
gitstart-app[bot] 8d206fd2c8 TWNTY-3480 - Add tests for modules/object-record/relation-picker/hooks (#3547) 
Add tests for `modules/object-record/relation-picker/hooks`

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>
 2024-01-19 12:38:21 +01:00
Thaïs 2d929c3b91 feat: display label identifier table cell as chip with link to Record… (#3503) 
* feat: display label identifier table cell as chip with link to RecordShowPage

Closes #3502

* Fix test

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
 2024-01-17 17:44:36 +01:00
Lucas Bordeau bbfe62df9a Implemented useListenClickOutside V2 (#3507) 
* Implemented useListenClickOutside V2

* Removed lock and implemented a toggle instead
 2024-01-17 16:22:22 +01:00
Charles Bochet f3f20ad974 Improve opportunity behavior (#3487) 
* Fix opportunity relation

* Fix

* Fix

* Fix tests

* Fix

* Fix

* Fix opportunities

* Fix Opportunity standard object and apply maxWidth to text ellipsis

* Update packages/twenty-front/src/modules/ui/field/display/components/EllipsisDisplay.tsx

Co-authored-by: Thaïs <guigon.thais@gmail.com>

* Fix

---------

Co-authored-by: Thaïs <guigon.thais@gmail.com>
 2024-01-16 15:43:19 +01:00
Charles Bochet fb93bb69fb Fix opportunity relation (#3478) 
* Fix opportunity relation

* Fix

* Fix

* Fix tests

* Fix

* Fix
 2024-01-16 14:39:48 +01:00
Charles Bochet 16a24c5f0c Rework relations (#3431) 
* Rework relations

* Fix tests
 2024-01-15 12:07:23 +01:00
gitstart-twenty 299bed511f Filter the opportunities "Point of contact" field (#3191) 
* Filter the opportunities "Point of contact" field

Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-01-11 20:26:11 +01:00
Charles Bochet 99247fb689 Fix activity target bug (#3390) 2024-01-11 20:18:54 +01:00
gitstart-twenty ebe8698910 Increase test coverage for /modules/ui (#3314) 
* Increase test coverage for `/modules/ui`

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: FellipeMTX <fellipefacdir@gmail.com>
Co-authored-by: Fellipe Montes <102544529+FellipeMTX@users.noreply.github.com>

* Merge main

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: FellipeMTX <fellipefacdir@gmail.com>
Co-authored-by: Fellipe Montes <102544529+FellipeMTX@users.noreply.github.com>

* Fix tests

* Fix tests

* Fix

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: FellipeMTX <fellipefacdir@gmail.com>
Co-authored-by: Fellipe Montes <102544529+FellipeMTX@users.noreply.github.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
 2024-01-11 08:51:36 +01:00
Thaïs ed06cc0310 feat: add Relation Field Card plus button in Show Page (#3229) 
Closes #3124
 2024-01-09 10:29:01 +01:00
Lucas Bordeau dc94d26997 Fixed create task bug (#3308) 2024-01-08 20:56:38 +01:00
Charles Bochet 96264e264c Refactor recoil v4 (#3266) 
* Refactor recoil v4

* Fix ci
 2024-01-05 19:18:22 +01:00
Lucas Bordeau b112b74022 Feat/activities custom objects (#3213) 
* WIP

* WIP - MultiObjectSearch

* WIP

* WIP

* Finished working version

* Fix

* Fixed and cleaned

* Fix

* Disabled files and emails for custom objects

* Cleaned console.log

* Fixed attachment

* Fixed

* fix lint

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
 2024-01-05 09:08:33 +01:00
gitstart-twenty 801177531b Fix and enhance storybook:modules:tests (#3107) 
* Fix and enhance storybook:modules:tests

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>

* Fix and enhance storybook:modules:tests

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>

* Fix and enhance storybook:modules:tests

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>

* Remove unnecessary changes

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>

* Fix email thread story

* Re-enable storybook:modules

* Fix

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
 2023-12-21 19:45:47 +01:00
Charles Bochet e9bc13b5fa Refactor recoil scope states (#3097) 
* Refactor recoil scope states

* Complete refactoring

* Fix
 2023-12-21 14:25:18 +01:00
gitstart-twenty af9d3fb217 On RecordTable, if I have no records, the Record Table Layout is not broken (#2911) 
* On RecordTable, if I have no records, the Record Table Layout is not broken

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>

* Revert scrollbar changes

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>

* fix + button

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>

* Revert unwanted changes

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>

* Merge main

Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>

* On RecordTable, if I have no records, the Record Table Layout is not broken

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>

* Add bottom border

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>

* Always show + button

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>

* Fix according to PR

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: RubensRafael <rubensrafael2@live.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2023-12-15 10:35:26 +01:00
Charles Bochet e22b242ef8 Fix multiselect on activities 2023-12-14 19:05:10 +01:00
Lucas Bordeau 468744298b Fix hook bug (#2995) 
* Fix hook bug

* Fix

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
 2023-12-14 18:54:23 +01:00
Kanav Arora ed2cd408bf Use SelectableList in RelationPicker, SingleEntitySelectBase and MultipleEntitySelect (#2949) 
* 2747-fix: conditional updation of selectedItemId

* 2747-fix: bug in toggling

* 2747-feat: SingleEntitySelectBase list changed to SelectableList

* 2747-feat: MultipleEntitySelect use SelectableList

* Fix lint

* 2747-fix: onEnter property fix for SingleEntitySelectBase

* 2747-fix: onEnter property fix for MultipleEntitySelect

* yarn fix in twenty-front

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
 2023-12-14 12:10:58 +01:00
Charles Bochet 5bdca9de6c Migrate to a monorepo structure (#2909) 2023-12-10 18:10:54 +01:00