Move tools/eslint-rules to packages/twenty-eslint-rules (#17203)

## Summary

Moves the custom ESLint rules from `tools/eslint-rules` to
`packages/twenty-eslint-rules` for better organization within the
monorepo packages structure.

## Changes

- Move `eslint-rules` from `tools/` to `packages/twenty-eslint-rules`
- Use `loadWorkspaceRules` from `@nx/eslint-plugin` to load custom rules
- Update all ESLint configs to use the `twenty/` rule prefix instead of
`@nx/workspace-`
- Update `project.json`, `jest.config.mjs` with new paths
- Update `package.json` workspaces and `nx.json` cache inputs
- Update Dockerfile reference

## Technical Details

The custom ESLint rules are now loaded using Nx's `loadWorkspaceRules`
utility which:
- Handles TypeScript transpilation automatically
- Allows loading workspace rules from any directory
- Provides a cleaner approach than the previous `@nx/workspace-`
convention

## Testing

- Verified all 17 custom ESLint rules load correctly from the new
location
- Verified linting works on dependent packages (twenty-front,
twenty-server, etc.)
This commit is contained in:
Félix Malfait
2026-01-17 07:37:17 +01:00
committed by GitHub
parent a429bc922d
commit c737028dd6
225 changed files with 622 additions and 4600 deletions
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, within } from 'storybook/test';
import { type StepFilterGroup, StepLogicalOperator } from 'twenty-shared/types';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { WorkspaceDecorator } from '~/testing/decorators/WorkspaceDecorator';
@@ -31,7 +30,6 @@ const meta: Meta<typeof WorkflowStepFilterAddFilterRuleSelect> = {
WorkflowStepDecorator,
ComponentDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
WorkflowStepFilterDecorator,
],
};
@@ -3,7 +3,6 @@ import { WorkflowStepFilterDecorator } from '@/workflow/workflow-steps/workflow-
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, within } from 'storybook/test';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { WorkspaceDecorator } from '~/testing/decorators/WorkspaceDecorator';
@@ -21,7 +20,6 @@ const meta: Meta<typeof WorkflowStepFilterAddRootStepFilterButton> = {
WorkflowStepDecorator,
ComponentDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
WorkflowStepFilterDecorator,
],
};
@@ -8,7 +8,6 @@ import {
ViewFilterOperand,
} from 'twenty-shared/types';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { WorkspaceDecorator } from '~/testing/decorators/WorkspaceDecorator';
@@ -45,7 +44,6 @@ const meta: Meta<typeof WorkflowStepFilterColumn> = {
WorkflowStepDecorator,
ComponentDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
WorkflowStepFilterDecorator,
],
};
@@ -3,7 +3,6 @@ import { WorkflowStepFilterDecorator } from '@/workflow/workflow-steps/workflow-
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { type StepFilter, ViewFilterOperand } from 'twenty-shared/types';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { WorkspaceDecorator } from '~/testing/decorators/WorkspaceDecorator';
@@ -33,7 +32,6 @@ const meta: Meta<typeof WorkflowStepFilterFieldSelect> = {
WorkflowStepDecorator,
ComponentDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
WorkflowStepFilterDecorator,
],
};
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, within } from 'storybook/test';
import { type StepFilterGroup, StepLogicalOperator } from 'twenty-shared/types';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { WorkspaceDecorator } from '~/testing/decorators/WorkspaceDecorator';
@@ -38,7 +37,6 @@ const meta: Meta<typeof WorkflowStepFilterLogicalOperatorCell> = {
WorkflowStepDecorator,
ComponentDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
WorkflowStepFilterDecorator,
],
};
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, within } from 'storybook/test';
import { type StepFilter, ViewFilterOperand } from 'twenty-shared/types';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { WorkspaceDecorator } from '~/testing/decorators/WorkspaceDecorator';
@@ -44,7 +43,6 @@ const meta: Meta<typeof WorkflowStepFilterOperandSelect> = {
WorkflowStepDecorator,
ComponentDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
WorkflowStepFilterDecorator,
],
};
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, within } from 'storybook/test';
import { type StepFilter, ViewFilterOperand } from 'twenty-shared/types';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { WorkspaceDecorator } from '~/testing/decorators/WorkspaceDecorator';
@@ -44,7 +43,6 @@ const meta: Meta<typeof WorkflowStepFilterValueInput> = {
WorkflowStepDecorator,
ComponentDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
WorkflowStepFilterDecorator,
],
};
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { graphql, HttpResponse } from 'msw';
import { fn } from 'storybook/test';
import { ComponentDecorator, RouterDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
@@ -134,7 +133,6 @@ const meta: Meta<typeof WorkflowEditActionServerlessFunction> = {
SnackBarDecorator,
RouterDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
],
};
@@ -2,7 +2,6 @@ import { WorkflowEditActionCreateRecord } from '@/workflow/workflow-steps/workfl
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, fn, userEvent, within } from 'storybook/test';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
@@ -47,7 +46,6 @@ const meta: Meta<typeof WorkflowEditActionCreateRecord> = {
ObjectMetadataItemsDecorator,
SnackBarDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
],
};
@@ -3,7 +3,6 @@ import { WorkflowEditActionDeleteRecord } from '@/workflow/workflow-steps/workfl
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, fn, userEvent, within } from 'storybook/test';
import { ComponentDecorator, RouterDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
@@ -52,7 +51,6 @@ const meta: Meta<typeof WorkflowEditActionDeleteRecord> = {
SnackBarDecorator,
RouterDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
],
};
@@ -3,7 +3,6 @@ import { WorkflowEditActionFindRecords } from '@/workflow/workflow-steps/workflo
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, fn, userEvent, within } from 'storybook/test';
import { ComponentDecorator, RouterDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
@@ -51,7 +50,6 @@ const meta: Meta<typeof WorkflowEditActionFindRecords> = {
SnackBarDecorator,
RouterDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
],
};
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { graphql, HttpResponse } from 'msw';
import { expect, fn, within } from 'storybook/test';
import { ComponentDecorator, RouterDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
@@ -95,7 +94,6 @@ const meta: Meta<typeof WorkflowEditActionSendEmail> = {
SnackBarDecorator,
RouterDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
],
};
@@ -3,7 +3,6 @@ import { WorkflowEditActionUpdateRecord } from '@/workflow/workflow-steps/workfl
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, fn, userEvent, within } from 'storybook/test';
import { ComponentDecorator, RouterDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
@@ -65,7 +64,6 @@ const meta: Meta<typeof WorkflowEditActionUpdateRecord> = {
SnackBarDecorator,
RouterDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
],
};
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { fn } from 'storybook/test';
import { StepLogicalOperator, ViewFilterOperand } from 'twenty-shared/types';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { WorkspaceDecorator } from '~/testing/decorators/WorkspaceDecorator';
@@ -87,7 +86,6 @@ const meta: Meta<typeof WorkflowEditActionFilter> = {
WorkflowStepDecorator,
ComponentDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
],
};
@@ -4,7 +4,6 @@ import { WorkflowEditActionFilterBody } from '@/workflow/workflow-steps/workflow
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { fn } from 'storybook/test';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { WorkspaceDecorator } from '~/testing/decorators/WorkspaceDecorator';
@@ -51,7 +50,6 @@ const meta: Meta<typeof WorkflowEditActionFilterBody> = {
WorkflowStepDecorator,
ComponentDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
WorkflowStepFilterDecorator,
],
};
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, fn, userEvent, waitFor, within } from 'storybook/test';
import { FieldMetadataType } from 'twenty-shared/types';
import { ComponentDecorator, RouterDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
@@ -61,7 +60,6 @@ const meta: Meta<typeof WorkflowEditActionFormBuilder> = {
WorkflowStepDecorator,
ComponentDecorator,
RouterDecorator,
I18nFrontDecorator,
ObjectMetadataItemsDecorator,
],
};
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, fn, userEvent, within } from 'storybook/test';
import { FieldMetadataType } from 'twenty-shared/types';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
@@ -14,7 +13,6 @@ const meta: Meta<typeof WorkflowEditActionFormFieldSettings> = {
decorators: [
WorkflowStepActionDrawerDecorator,
ComponentDecorator,
I18nFrontDecorator,
ObjectMetadataItemsDecorator,
],
};
@@ -4,7 +4,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, within } from 'storybook/test';
import { FieldMetadataType } from 'twenty-shared/types';
import { ComponentDecorator, RouterDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
@@ -21,7 +20,6 @@ const meta: Meta<typeof WorkflowEditActionFormFiller> = {
decorators: [
WorkflowStepActionDrawerDecorator,
ComponentDecorator,
I18nFrontDecorator,
WorkflowStepDecorator,
RouterDecorator,
ObjectMetadataItemsDecorator,
@@ -1,7 +1,6 @@
import { WorkflowFormEmptyMessage } from '@/workflow/workflow-steps/workflow-actions/form-action/components/WorkflowFormEmptyMessage';
import type { Meta, StoryObj } from '@storybook/react-vite';
import { expect, within } from 'storybook/test';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
const meta: Meta<typeof WorkflowFormEmptyMessage> = {
title: 'Modules/Workflow/Actions/Form/WorkflowFormEmptyMessage',
@@ -9,7 +8,7 @@ const meta: Meta<typeof WorkflowFormEmptyMessage> = {
parameters: {
layout: 'centered',
},
decorators: [I18nFrontDecorator],
decorators: [],
};
export default meta;
@@ -2,7 +2,6 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, within } from 'storybook/test';
import { ComponentDecorator } from 'twenty-ui/testing';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
import { HttpRequestExecutionResult } from '@/workflow/workflow-steps/workflow-actions/http-request-action/components/HttpRequestExecutionResult';
@@ -11,7 +10,7 @@ import type { HttpRequestTestData } from '@/workflow/workflow-steps/workflow-act
const meta: Meta<typeof HttpRequestExecutionResult> = {
title: 'Modules/Workflow/Actions/HttpRequest/ExecutionResult',
component: HttpRequestExecutionResult,
decorators: [ComponentDecorator, SnackBarDecorator, I18nFrontDecorator],
decorators: [ComponentDecorator, SnackBarDecorator],
parameters: {
layout: 'fullscreen',
},
@@ -3,7 +3,6 @@ import { WorkflowEditActionHttpRequest } from '@/workflow/workflow-steps/workflo
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, fn, waitFor, within } from 'storybook/test';
import { ComponentWithRouterDecorator } from '~/testing/decorators/ComponentWithRouterDecorator';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
import { WorkflowStepActionDrawerDecorator } from '~/testing/decorators/WorkflowStepActionDrawerDecorator';
@@ -84,7 +83,6 @@ const meta: Meta<typeof WorkflowEditActionHttpRequest> = {
ComponentWithRouterDecorator,
SnackBarDecorator,
WorkspaceDecorator,
I18nFrontDecorator,
ObjectMetadataItemsDecorator,
],
};