houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix server level impersonation (#14909)

Browse Source
This commit is contained in:
Etienne
2025-10-06 14:18:20 +02:00
committed by GitHub
parent 6f4c12922b
commit c1671c6ff6
3 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-server/src/engine/core-modules/auth/auth.resolver.ts
+1 -1
View File
@@ -707,7 +707,7 @@ export class AuthResolver {
const hasServerLevelImpersonatePermission =
impersonatorUserWorkspace.user.canImpersonate === true &&
impersonatorUserWorkspace.workspace.allowImpersonation === true;
toImpersonateUserWorkspace.workspace.allowImpersonation === true;
if (isServerLevelImpersonation) {
if (!hasServerLevelImpersonatePermission) {
packages/twenty-server/src/engine/core-modules/auth/strategies/jwt.auth.strategy.ts
+3 -9
View File
@@ -124,10 +124,7 @@ export class JwtAuthStrategy extends PassportStrategy(Strategy, 'jwt') {
}
if (payload.isImpersonating === true) {
context.impersonationContext = await this.validateImpersonation(
payload,
workspace,
);
context.impersonationContext = await this.validateImpersonation(payload);
}
const userId = payload.sub ?? payload.userId;
@@ -179,10 +176,7 @@ export class JwtAuthStrategy extends PassportStrategy(Strategy, 'jwt') {
return context;
}
private async validateImpersonation(
payload: AccessTokenJwtPayload,
workspace: Workspace,
) {
private async validateImpersonation(payload: AccessTokenJwtPayload) {
// Validate required impersonation fields
if (
!payload.impersonatorUserWorkspaceId ||
@@ -239,7 +233,7 @@ export class JwtAuthStrategy extends PassportStrategy(Strategy, 'jwt') {
const hasServerLevelImpersonatePermission =
impersonatorUserWorkspace.user.canImpersonate === true &&
workspace.allowImpersonation === true;
impersonatedUserWorkspace.workspace.allowImpersonation === true;
if (isServerLevelImpersonation) {
if (!hasServerLevelImpersonatePermission)
packages/twenty-server/src/engine/core-modules/impersonation/services/impersonation.service.ts
+1 -1
View File
@@ -69,7 +69,7 @@ export class ImpersonationService {
const hasServerLevelImpersonatePermission =
impersonatorUserWorkspace.user.canImpersonate === true &&
impersonatorUserWorkspace.workspace.allowImpersonation === true;
toImpersonateUserWorkspace.workspace.allowImpersonation === true;
if (isServerLevelImpersonation) {
if (!hasServerLevelImpersonatePermission) {