houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix REST API Delete and Destroy (#15806)

Browse Source 
Fixes https://github.com/twentyhq/twenty/issues/15801
This commit is contained in:
Raphaël Bosi
2025-11-13 18:14:32 +01:00
committed by GitHub
parent 9bc5486d0d
commit 56b3a0e8a5
3 changed files with 58 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-server/src/engine/api/rest/core/handlers/rest-api-delete-many.handler.ts
+10 -2
View File
@@ -1,10 +1,11 @@
import { Injectable } from '@nestjs/common';
import { BadRequestException, Injectable } from '@nestjs/common';
import isEmpty from 'lodash.isempty';
import { ObjectRecord } from 'twenty-shared/types';
import { capitalize } from 'twenty-shared/utils';
import { RestApiBaseHandler } from 'src/engine/api/rest/core/handlers/rest-api-base.handler';
import { CommonDeleteManyQueryRunnerService } from 'src/engine/api/common/common-query-runners/common-delete-many-query-runner.service';
import { RestApiBaseHandler } from 'src/engine/api/rest/core/handlers/rest-api-base.handler';
import { parseFilterRestRequest } from 'src/engine/api/rest/input-request-parsers/filter-parser-utils/parse-filter-rest-request.util';
import { AuthenticatedRequest } from 'src/engine/api/rest/types/authenticated-request';
import { workspaceQueryRunnerRestApiExceptionHandler } from 'src/engine/api/rest/utils/workspace-query-runner-rest-api-exception-handler.util';
@@ -23,6 +24,13 @@ export class RestApiDeleteManyHandler extends RestApiBaseHandler {
};
}> {
const { filter } = this.parseRequestArgs(request);
if (isEmpty(filter)) {
throw new BadRequestException(
'Filters are mandatory for bulk delete operations. Please provide at least one filter to prevent accidental deletion of all records.',
);
}
const { authContext, objectMetadataItemWithFieldMaps, objectMetadataMaps } =
await this.buildCommonOptions(request);
packages/twenty-server/src/engine/api/rest/core/handlers/rest-api-destroy-many.handler.ts
+10 -2
View File
@@ -1,10 +1,11 @@
import { Injectable } from '@nestjs/common';
import { BadRequestException, Injectable } from '@nestjs/common';
import isEmpty from 'lodash.isempty';
import { ObjectRecord } from 'twenty-shared/types';
import { capitalize } from 'twenty-shared/utils';
import { RestApiBaseHandler } from 'src/engine/api/rest/core/handlers/rest-api-base.handler';
import { CommonDestroyManyQueryRunnerService } from 'src/engine/api/common/common-query-runners/common-destroy-many-query-runner.service';
import { RestApiBaseHandler } from 'src/engine/api/rest/core/handlers/rest-api-base.handler';
import { parseFilterRestRequest } from 'src/engine/api/rest/input-request-parsers/filter-parser-utils/parse-filter-rest-request.util';
import { AuthenticatedRequest } from 'src/engine/api/rest/types/authenticated-request';
import { workspaceQueryRunnerRestApiExceptionHandler } from 'src/engine/api/rest/utils/workspace-query-runner-rest-api-exception-handler.util';
@@ -23,6 +24,13 @@ export class RestApiDestroyManyHandler extends RestApiBaseHandler {
};
}> {
const { filter } = this.parseRequestArgs(request);
if (isEmpty(filter)) {
throw new BadRequestException(
'Filters are mandatory for bulk destroy operations. Please provide at least one filter to prevent accidental deletion of all records.',
);
}
const { authContext, objectMetadataItemWithFieldMaps, objectMetadataMaps } =
await this.buildCommonOptions(request);