Fix for Invalid URL Error when creating new user (#13689)

Closes #13676

---------

Co-authored-by: Félix Malfait <felix.malfait@gmail.com>
Co-authored-by: Félix Malfait <felix@twenty.com>
This commit is contained in:
Thomas Mol
2025-08-06 16:27:43 +02:00
committed by GitHub
parent ca3383cd86
commit 3db6d49e86
2 changed files with 32 additions and 1 deletions
@@ -279,6 +279,37 @@ describe('UserWorkspaceService', () => {
pictureUrl: undefined,
});
expect(userWorkspaceRepository.save).toHaveBeenCalledWith(userWorkspace);
expect(result).toEqual(userWorkspace);
});
it("should create a user workspace without a default avatar url if it's a new user with an empty picture url", async () => {
const userId = 'user-id';
const workspaceId = 'workspace-id';
const userWorkspace = { userId, workspaceId } as UserWorkspace;
jest
.spyOn(userWorkspaceRepository, 'create')
.mockReturnValue(userWorkspace);
jest
.spyOn(userWorkspaceRepository, 'save')
.mockResolvedValue(userWorkspace);
const uploadImageFromUrlSpy = jest
.spyOn(fileUploadService, 'uploadImageFromUrl')
.mockResolvedValue({
files: [{ path: 'path/to/file', token: 'token' }],
} as SignedFilesResult);
const result = await service.create({
userId,
workspaceId,
isExistingUser: false,
pictureUrl: '',
});
expect(uploadImageFromUrlSpy).not.toHaveBeenCalled();
expect(userWorkspaceRepository.create).toHaveBeenCalledWith({
userId,
workspaceId,
@@ -362,7 +362,7 @@ export class UserWorkspaceService extends TypeOrmQueryService<UserWorkspace> {
}
}
if (!isDefined(pictureUrl)) return;
if (!isDefined(pictureUrl) || pictureUrl === '') return;
const { files } = await this.fileUploadService.uploadImageFromUrl({
imageUrl: pictureUrl,