e7ebf51e50
## Overview This PR replaces the dynamic agent handoff system with a more predictable planning-based router that decides upfront how to handle multi-agent coordination. ## Major Changes ### 🔄 Architecture Shift: Handoffs → Planning **Removed:** - `AgentHandoffEntity` and handoff tracking system - `AgentHandoffService` and `AgentHandoffExecutorService` - Dynamic agent-to-agent transfers during execution - Handoff tool generation and description templates **Added:** - `AiRouterService` with two strategies: `simple` (single agent) and `planned` (multi-agent) - `AgentPlanExecutorService` for executing multi-step plans - Plan validation (cycle detection, dependency resolution) - `UnifiedRouterResult` type with discriminated union ### 🤖 New Standard Agents Added two new specialized agents: - **Researcher Agent**: Web search, fact-finding, competitive intelligence - **Code Agent**: TypeScript function generation for serverless workflows ### 🏗️ Router Refactoring (Latest) Split router responsibilities into focused services: - `AiRouterStrategyDeciderService`: Decides simple vs planned strategy - `AiRouterPlanGeneratorService`: Generates and validates execution plans - `AiRouterService`: Coordinates between services (reduced from 426→275 lines) ### ⚙️ Configuration Improvements - Added `outputStrategy` to agent definitions (`direct` vs `synthesize`) - Removed hardcoded special cases for workflow-builder - Added `plannerModel` field to workspace entity - Increased `MAX_STEPS` from 10 to 25 for complex workflows ### 📝 Agent Prompt Refinements Significantly simplified prompts for better clarity: - Workflow Builder: 51→36 lines - Helper: 49→28 lines - Data Manipulator: Enhanced with sorting guidance ### 🔍 Enhanced Debugging - Plan reasoning and step count in data message parts - Router debug info with token usage tracking - Better logging throughout execution pipeline ## Benefits 1. **Simpler Mental Model**: Router decides upfront vs dynamic transfers 2. **Better Predictability**: Users see the plan before execution 3. **Cleaner Architecture**: SRP with focused services 4. **Configuration Over Code**: Agent behavior via config, not hardcoded logic 5. **Plan Validation**: Catches invalid dependencies and cycles ## Migration Notes - Database migration removes `agentHandoff` table - Adds `plannerModel` column to workspace table - No API breaking changes (agent endpoints unchanged) ## Testing - Integration tests updated to remove handoff dependencies - Agent tool test utilities simplified - Plan validation covered by new logic ## Next Steps (Future PRs) - Parallel execution of independent plan steps - Dynamic re-planning based on results - Plan caching for common routing patterns - Error recovery strategies in plan executor
219 lines
7.8 KiB
TypeScript
219 lines
7.8 KiB
TypeScript
import { msg } from '@lingui/core/macro';
|
|
import {
|
|
ActorMetadata,
|
|
FieldMetadataType,
|
|
RelationOnDeleteAction,
|
|
type RichTextV2Metadata,
|
|
} from 'twenty-shared/types';
|
|
import { STANDARD_OBJECT_IDS } from 'twenty-shared/metadata';
|
|
|
|
import { RelationType } from 'src/engine/metadata-modules/field-metadata/interfaces/relation-type.interface';
|
|
import { Relation } from 'src/engine/workspace-manager/workspace-sync-metadata/interfaces/relation.interface';
|
|
|
|
import { SEARCH_VECTOR_FIELD } from 'src/engine/metadata-modules/search-field-metadata/constants/search-vector-field.constants';
|
|
import { IndexType } from 'src/engine/metadata-modules/index-metadata/types/indexType.types';
|
|
import { BaseWorkspaceEntity } from 'src/engine/twenty-orm/base.workspace-entity';
|
|
import { WorkspaceEntity } from 'src/engine/twenty-orm/decorators/workspace-entity.decorator';
|
|
import { WorkspaceFieldIndex } from 'src/engine/twenty-orm/decorators/workspace-field-index.decorator';
|
|
import { WorkspaceField } from 'src/engine/twenty-orm/decorators/workspace-field.decorator';
|
|
import { WorkspaceIsFieldUIReadOnly } from 'src/engine/twenty-orm/decorators/workspace-is-field-ui-readonly.decorator';
|
|
import { WorkspaceIsNullable } from 'src/engine/twenty-orm/decorators/workspace-is-nullable.decorator';
|
|
import { WorkspaceIsSearchable } from 'src/engine/twenty-orm/decorators/workspace-is-searchable.decorator';
|
|
import { WorkspaceIsSystem } from 'src/engine/twenty-orm/decorators/workspace-is-system.decorator';
|
|
import { WorkspaceJoinColumn } from 'src/engine/twenty-orm/decorators/workspace-join-column.decorator';
|
|
import { WorkspaceRelation } from 'src/engine/twenty-orm/decorators/workspace-relation.decorator';
|
|
import { TASK_STANDARD_FIELD_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
|
|
import { STANDARD_OBJECT_ICONS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-icons';
|
|
import {
|
|
type FieldTypeAndNameMetadata,
|
|
getTsVectorColumnExpressionFromFields,
|
|
} from 'src/engine/workspace-manager/workspace-sync-metadata/utils/get-ts-vector-column-expression.util';
|
|
import { AttachmentWorkspaceEntity } from 'src/modules/attachment/standard-objects/attachment.workspace-entity';
|
|
import { FavoriteWorkspaceEntity } from 'src/modules/favorite/standard-objects/favorite.workspace-entity';
|
|
import { TaskTargetWorkspaceEntity } from 'src/modules/task/standard-objects/task-target.workspace-entity';
|
|
import { TimelineActivityWorkspaceEntity } from 'src/modules/timeline/standard-objects/timeline-activity.workspace-entity';
|
|
import { WorkspaceMemberWorkspaceEntity } from 'src/modules/workspace-member/standard-objects/workspace-member.workspace-entity';
|
|
|
|
const TITLE_FIELD_NAME = 'title';
|
|
|
|
const BODY_V2_FIELD_NAME = 'bodyV2';
|
|
|
|
export const SEARCH_FIELDS_FOR_TASKS: FieldTypeAndNameMetadata[] = [
|
|
{ name: TITLE_FIELD_NAME, type: FieldMetadataType.TEXT },
|
|
{ name: BODY_V2_FIELD_NAME, type: FieldMetadataType.RICH_TEXT_V2 },
|
|
];
|
|
|
|
@WorkspaceEntity({
|
|
standardId: STANDARD_OBJECT_IDS.task,
|
|
|
|
namePlural: 'tasks',
|
|
labelSingular: msg`Task`,
|
|
labelPlural: msg`Tasks`,
|
|
description: msg`A task`,
|
|
icon: STANDARD_OBJECT_ICONS.task,
|
|
shortcut: 'T',
|
|
labelIdentifierStandardId: TASK_STANDARD_FIELD_IDS.title,
|
|
})
|
|
@WorkspaceIsSearchable()
|
|
export class TaskWorkspaceEntity extends BaseWorkspaceEntity {
|
|
@WorkspaceField({
|
|
standardId: TASK_STANDARD_FIELD_IDS.position,
|
|
type: FieldMetadataType.POSITION,
|
|
label: msg`Position`,
|
|
description: msg`Task record position`,
|
|
icon: 'IconHierarchy2',
|
|
defaultValue: 0,
|
|
})
|
|
@WorkspaceIsSystem()
|
|
position: number;
|
|
|
|
@WorkspaceField({
|
|
standardId: TASK_STANDARD_FIELD_IDS.title,
|
|
type: FieldMetadataType.TEXT,
|
|
label: msg`Title`,
|
|
description: msg`Task title`,
|
|
icon: 'IconNotes',
|
|
})
|
|
@WorkspaceIsNullable()
|
|
title: string;
|
|
|
|
@WorkspaceField({
|
|
standardId: TASK_STANDARD_FIELD_IDS.bodyV2,
|
|
type: FieldMetadataType.RICH_TEXT_V2,
|
|
label: msg`Body`,
|
|
description: msg`Task body`,
|
|
icon: 'IconFilePencil',
|
|
})
|
|
@WorkspaceIsNullable()
|
|
bodyV2: RichTextV2Metadata | null;
|
|
|
|
@WorkspaceField({
|
|
standardId: TASK_STANDARD_FIELD_IDS.dueAt,
|
|
type: FieldMetadataType.DATE_TIME,
|
|
label: msg`Due Date`,
|
|
description: msg`Task due date`,
|
|
icon: 'IconCalendarEvent',
|
|
})
|
|
@WorkspaceIsNullable()
|
|
dueAt: Date | null;
|
|
|
|
@WorkspaceField({
|
|
standardId: TASK_STANDARD_FIELD_IDS.status,
|
|
type: FieldMetadataType.SELECT,
|
|
label: msg`Status`,
|
|
description: msg`Task status`,
|
|
icon: 'IconCheck',
|
|
defaultValue: "'TODO'",
|
|
options: [
|
|
{ value: 'TODO', label: 'To do', position: 0, color: 'sky' },
|
|
{
|
|
value: 'IN_PROGRESS',
|
|
label: 'In progress',
|
|
position: 1,
|
|
color: 'purple',
|
|
},
|
|
{
|
|
value: 'DONE',
|
|
label: 'Done',
|
|
position: 2,
|
|
color: 'green',
|
|
},
|
|
],
|
|
})
|
|
@WorkspaceIsNullable()
|
|
status: string | null;
|
|
|
|
@WorkspaceField({
|
|
standardId: TASK_STANDARD_FIELD_IDS.createdBy,
|
|
type: FieldMetadataType.ACTOR,
|
|
label: msg`Created by`,
|
|
icon: 'IconCreativeCommonsSa',
|
|
description: msg`The creator of the record`,
|
|
})
|
|
@WorkspaceIsFieldUIReadOnly()
|
|
createdBy: ActorMetadata;
|
|
|
|
@WorkspaceRelation({
|
|
standardId: TASK_STANDARD_FIELD_IDS.taskTargets,
|
|
label: msg`Relations`,
|
|
description: msg`Task targets`,
|
|
icon: 'IconArrowUpRight',
|
|
type: RelationType.ONE_TO_MANY,
|
|
inverseSideTarget: () => TaskTargetWorkspaceEntity,
|
|
onDelete: RelationOnDeleteAction.SET_NULL,
|
|
})
|
|
@WorkspaceIsNullable()
|
|
@WorkspaceIsSystem()
|
|
taskTargets: Relation<TaskTargetWorkspaceEntity[]>;
|
|
|
|
@WorkspaceRelation({
|
|
standardId: TASK_STANDARD_FIELD_IDS.attachments,
|
|
label: msg`Attachments`,
|
|
description: msg`Task attachments`,
|
|
icon: 'IconFileImport',
|
|
type: RelationType.ONE_TO_MANY,
|
|
inverseSideTarget: () => AttachmentWorkspaceEntity,
|
|
onDelete: RelationOnDeleteAction.SET_NULL,
|
|
})
|
|
@WorkspaceIsNullable()
|
|
@WorkspaceIsSystem()
|
|
attachments: Relation<AttachmentWorkspaceEntity[]>;
|
|
|
|
@WorkspaceRelation({
|
|
standardId: TASK_STANDARD_FIELD_IDS.assignee,
|
|
label: msg`Assignee`,
|
|
description: msg`Task assignee`,
|
|
icon: 'IconUserCircle',
|
|
type: RelationType.MANY_TO_ONE,
|
|
inverseSideTarget: () => WorkspaceMemberWorkspaceEntity,
|
|
inverseSideFieldKey: 'assignedTasks',
|
|
onDelete: RelationOnDeleteAction.SET_NULL,
|
|
})
|
|
@WorkspaceIsNullable()
|
|
assignee: Relation<WorkspaceMemberWorkspaceEntity> | null;
|
|
|
|
@WorkspaceJoinColumn('assignee')
|
|
assigneeId: string | null;
|
|
|
|
@WorkspaceRelation({
|
|
standardId: TASK_STANDARD_FIELD_IDS.timelineActivities,
|
|
type: RelationType.ONE_TO_MANY,
|
|
label: msg`Timeline Activities`,
|
|
description: msg`Timeline Activities linked to the task.`,
|
|
icon: 'IconTimelineEvent',
|
|
inverseSideTarget: () => TimelineActivityWorkspaceEntity,
|
|
onDelete: RelationOnDeleteAction.SET_NULL,
|
|
})
|
|
@WorkspaceIsNullable()
|
|
@WorkspaceIsSystem()
|
|
timelineActivities: Relation<TimelineActivityWorkspaceEntity[]>;
|
|
|
|
@WorkspaceRelation({
|
|
standardId: TASK_STANDARD_FIELD_IDS.favorites,
|
|
type: RelationType.ONE_TO_MANY,
|
|
label: msg`Favorites`,
|
|
description: msg`Favorites linked to the task`,
|
|
icon: 'IconHeart',
|
|
inverseSideTarget: () => FavoriteWorkspaceEntity,
|
|
onDelete: RelationOnDeleteAction.CASCADE,
|
|
})
|
|
@WorkspaceIsSystem()
|
|
favorites: Relation<FavoriteWorkspaceEntity[]>;
|
|
|
|
@WorkspaceField({
|
|
standardId: TASK_STANDARD_FIELD_IDS.searchVector,
|
|
type: FieldMetadataType.TS_VECTOR,
|
|
label: SEARCH_VECTOR_FIELD.label,
|
|
description: SEARCH_VECTOR_FIELD.description,
|
|
icon: 'IconUser',
|
|
generatedType: 'STORED',
|
|
asExpression: getTsVectorColumnExpressionFromFields(
|
|
SEARCH_FIELDS_FOR_TASKS,
|
|
),
|
|
})
|
|
@WorkspaceIsNullable()
|
|
@WorkspaceIsSystem()
|
|
@WorkspaceFieldIndex({ indexType: IndexType.GIN })
|
|
searchVector: string;
|
|
}
|