d81f006979
## Summary Rename all Jotai-based state management hooks and utilities to a consistent naming convention that: 1. Removes legacy Recoil naming (`useRecoilXxxV2`, `createXxxV2`) 2. Always includes `Atom` in the name to distinguish from jotai native hooks 3. Follows a consistent ordering: `Atom` → `Component` → `Family` → `Type` (`State`/`Selector`) 4. Includes the type qualifier (`State` or `Selector`) in all value-reading hooks to avoid naming conflicts with jotai's native `useAtomValue` ## Naming Convention **Hooks**: `use[Set]Atom[Component][Family][State|Selector][Value|State|CallbackState]` **Utils**: `createAtom[Component][Family][State|Selector]` ## Changes ### Hooks renamed (definition files + all usages across ~1,500 files): | Old Name (Recoil) | Intermediate (Atom) | Final Name | |---|---|---| | `useRecoilValueV2` | `useAtomValue` | **`useAtomStateValue`** | | `useRecoilStateV2` | `useAtomState` | `useAtomState` | | `useSetRecoilStateV2` | `useSetAtomState` | `useSetAtomState` | | `useFamilyRecoilValueV2` | `useFamilyAtomValue` | **`useAtomFamilyStateValue`** | | `useSetFamilyRecoilStateV2` | `useSetFamilyAtomState` | **`useSetAtomFamilyState`** | | `useFamilySelectorValueV2` | `useFamilySelectorValue` | **`useAtomFamilySelectorValue`** | | `useFamilySelectorStateV2` | `useFamilySelectorState` | **`useAtomFamilySelectorState`** | | `useRecoilComponentValueV2` | `useAtomComponentValue` | **`useAtomComponentStateValue`** | | `useRecoilComponentStateV2` | `useAtomComponentState` | `useAtomComponentState` | | `useSetRecoilComponentStateV2` | `useSetAtomComponentState` | `useSetAtomComponentState` | | `useRecoilComponentFamilyValueV2` | `useAtomComponentFamilyValue` | **`useAtomComponentFamilyStateValue`** | | `useRecoilComponentFamilyStateV2` | `useAtomComponentFamilyState` | `useAtomComponentFamilyState` | | `useSetRecoilComponentFamilyStateV2` | `useSetAtomComponentFamilyState` | `useSetAtomComponentFamilyState` | | `useRecoilComponentSelectorValueV2` | `useAtomComponentSelectorValue` | `useAtomComponentSelectorValue` | | `useRecoilComponentFamilySelectorValueV2` | `useAtomComponentFamilySelectorValue` | `useAtomComponentFamilySelectorValue` | | `useRecoilComponentStateCallbackStateV2` | `useAtomComponentStateCallbackState` | `useAtomComponentStateCallbackState` | | `useRecoilComponentSelectorCallbackStateV2` | `useAtomComponentSelectorCallbackState` | `useAtomComponentSelectorCallbackState` | | `useRecoilComponentFamilyStateCallbackStateV2` | `useAtomComponentFamilyStateCallbackState` | `useAtomComponentFamilyStateCallbackState` | | `useRecoilComponentFamilySelectorCallbackStateV2` | `useAtomComponentFamilySelectorCallbackState` | `useAtomComponentFamilySelectorCallbackState` | ### Utilities renamed: | Old Name (Recoil) | Final Name | |---|---| | `createStateV2` | **`createAtomState`** | | `createFamilyStateV2` | **`createAtomFamilyState`** | | `createSelectorV2` | **`createAtomSelector`** | | `createFamilySelectorV2` | **`createAtomFamilySelector`** | | `createWritableSelectorV2` | **`createAtomWritableSelector`** | | `createWritableFamilySelectorV2` | **`createAtomWritableFamilySelector`** | | `createComponentStateV2` | **`createAtomComponentState`** | | `createComponentFamilyStateV2` | **`createAtomComponentFamilyState`** | | `createComponentSelectorV2` | **`createAtomComponentSelector`** | | `createComponentFamilySelectorV2` | **`createAtomComponentFamilySelector`** | ## Details - All definition files renamed to match new convention - All import paths and usages updated across the entire `twenty-front` package - Jotai's native `useAtomValue` is aliased as `useJotaiAtomValue` in the wrapper hook to avoid collision - Legacy Recoil files in `state/utils/` and `component-state/utils/` left untouched (separate naming scope) - Typecheck passes cleanly
128 lines
4.2 KiB
TypeScript
128 lines
4.2 KiB
TypeScript
import styled from '@emotion/styled';
|
|
|
|
import { SkeletonLoader } from '@/activities/components/SkeletonLoader';
|
|
import { useOpenCreateActivityDrawer } from '@/activities/hooks/useOpenCreateActivityDrawer';
|
|
import { useTasks } from '@/activities/tasks/hooks/useTasks';
|
|
import { type ActivityTargetableObject } from '@/activities/types/ActivityTargetableEntity';
|
|
import { type Task } from '@/activities/types/Task';
|
|
import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
|
|
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
|
|
import { useObjectPermissionsForObject } from '@/object-record/hooks/useObjectPermissionsForObject';
|
|
import { activeTabIdComponentState } from '@/ui/layout/tab-list/states/activeTabIdComponentState';
|
|
import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';
|
|
import { t } from '@lingui/core/macro';
|
|
import groupBy from 'lodash.groupby';
|
|
import { IconPlus } from 'twenty-ui/display';
|
|
import { Button } from 'twenty-ui/input';
|
|
import {
|
|
AnimatedPlaceholder,
|
|
AnimatedPlaceholderEmptyContainer,
|
|
AnimatedPlaceholderEmptySubTitle,
|
|
AnimatedPlaceholderEmptyTextContainer,
|
|
AnimatedPlaceholderEmptyTitle,
|
|
EMPTY_PLACEHOLDER_TRANSITION_PROPS,
|
|
} from 'twenty-ui/layout';
|
|
import { AddTaskButton } from './AddTaskButton';
|
|
import { TaskList } from './TaskList';
|
|
|
|
const StyledContainer = styled.div`
|
|
display: flex;
|
|
flex-direction: column;
|
|
width: 100%;
|
|
`;
|
|
|
|
type TaskGroupsProps = {
|
|
filterDropdownId?: string;
|
|
targetableObject: ActivityTargetableObject;
|
|
};
|
|
|
|
export const TaskGroups = ({ targetableObject }: TaskGroupsProps) => {
|
|
const { tasks, tasksLoading } = useTasks({
|
|
targetableObjects: [targetableObject],
|
|
});
|
|
|
|
const { objectMetadataItem } = useObjectMetadataItem({
|
|
objectNameSingular: targetableObject.targetObjectNameSingular,
|
|
});
|
|
|
|
const objectPermissions = useObjectPermissionsForObject(
|
|
objectMetadataItem.id,
|
|
);
|
|
|
|
const hasObjectUpdatePermissions = objectPermissions.canUpdateObjectRecords;
|
|
|
|
const openCreateActivity = useOpenCreateActivityDrawer({
|
|
activityObjectNameSingular: CoreObjectNameSingular.Task,
|
|
});
|
|
|
|
const activeTabId = useAtomComponentStateValue(activeTabIdComponentState);
|
|
|
|
const isLoading =
|
|
(activeTabId !== 'done' && tasksLoading) ||
|
|
(activeTabId === 'done' && tasksLoading);
|
|
|
|
const isTasksEmpty =
|
|
(activeTabId !== 'done' && tasks?.length === 0) ||
|
|
(activeTabId === 'done' && tasks?.length === 0);
|
|
|
|
if (isLoading && isTasksEmpty) {
|
|
return <SkeletonLoader />;
|
|
}
|
|
|
|
if (isTasksEmpty) {
|
|
return (
|
|
<AnimatedPlaceholderEmptyContainer
|
|
// eslint-disable-next-line react/jsx-props-no-spreading
|
|
{...EMPTY_PLACEHOLDER_TRANSITION_PROPS}
|
|
>
|
|
<AnimatedPlaceholder type="noTask" />
|
|
<AnimatedPlaceholderEmptyTextContainer>
|
|
<AnimatedPlaceholderEmptyTitle>
|
|
{t`Mission accomplished!`}
|
|
</AnimatedPlaceholderEmptyTitle>
|
|
<AnimatedPlaceholderEmptySubTitle>
|
|
{t`All tasks addressed. Maintain the momentum.`}
|
|
</AnimatedPlaceholderEmptySubTitle>
|
|
</AnimatedPlaceholderEmptyTextContainer>
|
|
{hasObjectUpdatePermissions && (
|
|
<Button
|
|
Icon={IconPlus}
|
|
title={t`New task`}
|
|
variant="secondary"
|
|
onClick={() =>
|
|
openCreateActivity({
|
|
targetableObjects: [targetableObject],
|
|
})
|
|
}
|
|
/>
|
|
)}
|
|
</AnimatedPlaceholderEmptyContainer>
|
|
);
|
|
}
|
|
|
|
const sortedTasksByStatus = Object.entries(
|
|
groupBy(tasks, ({ status }) => status),
|
|
).sort(([statusA], [statusB]) => statusB.localeCompare(statusA));
|
|
|
|
const hasTodoStatus = sortedTasksByStatus.some(
|
|
([status]) => status === 'TODO',
|
|
);
|
|
|
|
return (
|
|
<StyledContainer>
|
|
{sortedTasksByStatus.map(([status, tasksByStatus]: [string, Task[]]) => (
|
|
<TaskList
|
|
key={status}
|
|
title={status}
|
|
tasks={tasksByStatus}
|
|
button={
|
|
(status === 'TODO' || !hasTodoStatus) && (
|
|
<AddTaskButton activityTargetableObject={targetableObject} />
|
|
)
|
|
}
|
|
/>
|
|
))}
|
|
</StyledContainer>
|
|
);
|
|
};
|