d5c974054d
In this PR: ## Improve recompute metadata cache performance. We are aiming for ~100ms Deleting relationMetadata table and FKs pointing on it Fetching indexMetadata and indexFieldMetadata in a separate query as typeorm is suboptimizing ## Remove caching lock As recomputing the metadata cache is lighter, we try to stop preventing multiple concurrent computations. This also simplifies interfaces ## Introduce self recovery mecanisms to recompute cache automatically if corrupted Aka getFreshObjectMetadataMaps ## custom object resolver performance improvement: 1sec to 200ms Double check queries and indexes used while creating a custom object Remove the queries to db to use the cached objectMetadataMap ## reduce objectMetadataMaps to 500kb <img width="222" alt="image" src="https://github.com/user-attachments/assets/2370dc80-49b6-4b63-8d5e-30c5ebdaa062" /> We used to stored 3 fieldMetadataMaps (byId, byName, byJoinColumnName). While this is great for devXP, this is not great for performances. Using the same mecanisme as for objectMetadataMap: we only keep byIdMap and introduce two otherMaps to idByName, idByJoinColumnName to make the bridge ## Add dataloader on IndexMetadata (aka indexMetadataList in the API) ## Improve field resolver performances too ## Deprecate ClientConfig
258 lines
10 KiB
TypeScript
258 lines
10 KiB
TypeScript
import { Inject, Injectable } from '@nestjs/common';
|
|
|
|
import graphqlFields from 'graphql-fields';
|
|
import { PermissionsOnAllObjectRecords } from 'twenty-shared/constants';
|
|
import { capitalize, isDefined } from 'twenty-shared/utils';
|
|
import { ObjectLiteral } from 'typeorm';
|
|
|
|
import { ObjectRecord } from 'src/engine/api/graphql/workspace-query-builder/interfaces/object-record.interface';
|
|
import { IConnection } from 'src/engine/api/graphql/workspace-query-runner/interfaces/connection.interface';
|
|
import { IEdge } from 'src/engine/api/graphql/workspace-query-runner/interfaces/edge.interface';
|
|
import { WorkspaceQueryRunnerOptions } from 'src/engine/api/graphql/workspace-query-runner/interfaces/query-runner-option.interface';
|
|
import {
|
|
ResolverArgs,
|
|
ResolverArgsType,
|
|
WorkspaceResolverBuilderMethodNames,
|
|
} from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
|
|
|
|
import { OBJECTS_WITH_SETTINGS_PERMISSIONS_REQUIREMENTS } from 'src/engine/api/graphql/graphql-query-runner/constants/objects-with-settings-permissions-requirements';
|
|
import { GraphqlQuerySelectedFieldsResult } from 'src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query-selected-fields/graphql-selected-fields.parser';
|
|
import { GraphqlQueryParser } from 'src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser';
|
|
import { ProcessNestedRelationsHelper } from 'src/engine/api/graphql/graphql-query-runner/helpers/process-nested-relations.helper';
|
|
import { ApiEventEmitterService } from 'src/engine/api/graphql/graphql-query-runner/services/api-event-emitter.service';
|
|
import { QueryResultGettersFactory } from 'src/engine/api/graphql/workspace-query-runner/factories/query-result-getters/query-result-getters.factory';
|
|
import { QueryRunnerArgsFactory } from 'src/engine/api/graphql/workspace-query-runner/factories/query-runner-args.factory';
|
|
import { workspaceQueryRunnerGraphqlApiExceptionHandler } from 'src/engine/api/graphql/workspace-query-runner/utils/workspace-query-runner-graphql-api-exception-handler.util';
|
|
import { WorkspaceQueryHookService } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/workspace-query-hook.service';
|
|
import { RESOLVER_METHOD_NAMES } from 'src/engine/api/graphql/workspace-resolver-builder/constants/resolver-method-names';
|
|
import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
|
|
import { workspaceValidator } from 'src/engine/core-modules/workspace/workspace.validate';
|
|
import { SettingPermissionType } from 'src/engine/metadata-modules/permissions/constants/setting-permission-type.constants';
|
|
import {
|
|
PermissionsException,
|
|
PermissionsExceptionCode,
|
|
PermissionsExceptionMessage,
|
|
} from 'src/engine/metadata-modules/permissions/permissions.exception';
|
|
import { PermissionsService } from 'src/engine/metadata-modules/permissions/permissions.service';
|
|
import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';
|
|
import { WorkspaceDataSource } from 'src/engine/twenty-orm/datasource/workspace.datasource';
|
|
import { WorkspaceRepository } from 'src/engine/twenty-orm/repository/workspace.repository';
|
|
import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.manager';
|
|
|
|
export type GraphqlQueryResolverExecutionArgs<Input extends ResolverArgs> = {
|
|
args: Input;
|
|
options: WorkspaceQueryRunnerOptions;
|
|
workspaceDataSource: WorkspaceDataSource;
|
|
repository: WorkspaceRepository<ObjectLiteral>;
|
|
graphqlQueryParser: GraphqlQueryParser;
|
|
graphqlQuerySelectedFieldsResult: GraphqlQuerySelectedFieldsResult;
|
|
isExecutedByApiKey: boolean;
|
|
roleId?: string;
|
|
};
|
|
|
|
@Injectable()
|
|
export abstract class GraphqlQueryBaseResolverService<
|
|
Input extends ResolverArgs,
|
|
Response extends
|
|
| ObjectRecord
|
|
| ObjectRecord[]
|
|
| IConnection<ObjectRecord, IEdge<ObjectRecord>>
|
|
| IConnection<ObjectRecord, IEdge<ObjectRecord>>[],
|
|
> {
|
|
@Inject()
|
|
protected readonly workspaceQueryHookService: WorkspaceQueryHookService;
|
|
@Inject()
|
|
protected readonly queryRunnerArgsFactory: QueryRunnerArgsFactory;
|
|
@Inject()
|
|
protected readonly queryResultGettersFactory: QueryResultGettersFactory;
|
|
@Inject()
|
|
protected readonly apiEventEmitterService: ApiEventEmitterService;
|
|
@Inject()
|
|
protected readonly twentyORMGlobalManager: TwentyORMGlobalManager;
|
|
@Inject()
|
|
protected readonly processNestedRelationsHelper: ProcessNestedRelationsHelper;
|
|
@Inject()
|
|
protected readonly permissionsService: PermissionsService;
|
|
@Inject()
|
|
protected readonly userRoleService: UserRoleService;
|
|
|
|
public async execute(
|
|
args: Input,
|
|
options: WorkspaceQueryRunnerOptions,
|
|
operationName: WorkspaceResolverBuilderMethodNames,
|
|
): Promise<Response | undefined> {
|
|
try {
|
|
const { authContext, objectMetadataItemWithFieldMaps } = options;
|
|
|
|
const workspace = authContext.workspace;
|
|
|
|
workspaceValidator.assertIsDefinedOrThrow(workspace);
|
|
|
|
await this.validate(args, options);
|
|
|
|
const workspaceDataSource =
|
|
await this.twentyORMGlobalManager.getDataSourceForWorkspace({
|
|
workspaceId: workspace.id,
|
|
});
|
|
|
|
const featureFlagsMap = workspaceDataSource.featureFlagMap;
|
|
|
|
if (objectMetadataItemWithFieldMaps.isSystem === true) {
|
|
await this.validateSettingsPermissionsOnObjectOrThrow(options);
|
|
}
|
|
|
|
const hookedArgs =
|
|
await this.workspaceQueryHookService.executePreQueryHooks(
|
|
authContext,
|
|
objectMetadataItemWithFieldMaps.nameSingular,
|
|
operationName,
|
|
args,
|
|
);
|
|
|
|
const computedArgs = (await this.queryRunnerArgsFactory.create(
|
|
hookedArgs,
|
|
options,
|
|
// @ts-expect-error legacy noImplicitAny
|
|
ResolverArgsType[capitalize(operationName)],
|
|
)) as Input;
|
|
|
|
const roleId = await this.userRoleService.getRoleIdForUserWorkspace({
|
|
userWorkspaceId: authContext.userWorkspaceId,
|
|
workspaceId: workspace.id,
|
|
});
|
|
|
|
const executedByApiKey = isDefined(authContext.apiKey);
|
|
const shouldBypassPermissionChecks = executedByApiKey;
|
|
|
|
const repository = workspaceDataSource.getRepository(
|
|
objectMetadataItemWithFieldMaps.nameSingular,
|
|
shouldBypassPermissionChecks,
|
|
roleId,
|
|
);
|
|
|
|
const graphqlQueryParser = new GraphqlQueryParser(
|
|
objectMetadataItemWithFieldMaps,
|
|
options.objectMetadataMaps,
|
|
);
|
|
|
|
const selectedFields = graphqlFields(options.info);
|
|
|
|
const graphqlQuerySelectedFieldsResult =
|
|
graphqlQueryParser.parseSelectedFields(
|
|
objectMetadataItemWithFieldMaps,
|
|
selectedFields,
|
|
);
|
|
|
|
const graphqlQueryResolverExecutionArgs = {
|
|
args: computedArgs,
|
|
options,
|
|
workspaceDataSource,
|
|
repository,
|
|
graphqlQueryParser,
|
|
graphqlQuerySelectedFieldsResult,
|
|
isExecutedByApiKey: executedByApiKey,
|
|
roleId,
|
|
};
|
|
|
|
const results = await this.resolve(
|
|
graphqlQueryResolverExecutionArgs,
|
|
featureFlagsMap,
|
|
);
|
|
|
|
const resultWithGetters = await this.queryResultGettersFactory.create(
|
|
results,
|
|
objectMetadataItemWithFieldMaps,
|
|
workspace.id,
|
|
options.objectMetadataMaps,
|
|
);
|
|
|
|
await this.workspaceQueryHookService.executePostQueryHooks(
|
|
authContext,
|
|
objectMetadataItemWithFieldMaps.nameSingular,
|
|
operationName,
|
|
resultWithGetters,
|
|
);
|
|
|
|
return resultWithGetters;
|
|
} catch (error) {
|
|
workspaceQueryRunnerGraphqlApiExceptionHandler(error, options);
|
|
}
|
|
}
|
|
|
|
private async validateSettingsPermissionsOnObjectOrThrow(
|
|
options: WorkspaceQueryRunnerOptions,
|
|
) {
|
|
const { authContext, objectMetadataItemWithFieldMaps } = options;
|
|
|
|
const workspace = authContext.workspace;
|
|
|
|
workspaceValidator.assertIsDefinedOrThrow(workspace);
|
|
|
|
if (
|
|
Object.keys(OBJECTS_WITH_SETTINGS_PERMISSIONS_REQUIREMENTS).includes(
|
|
objectMetadataItemWithFieldMaps.nameSingular,
|
|
)
|
|
) {
|
|
const permissionRequired: SettingPermissionType =
|
|
// @ts-expect-error legacy noImplicitAny
|
|
OBJECTS_WITH_SETTINGS_PERMISSIONS_REQUIREMENTS[
|
|
objectMetadataItemWithFieldMaps.nameSingular
|
|
];
|
|
|
|
const userHasPermission =
|
|
await this.permissionsService.userHasWorkspaceSettingPermission({
|
|
userWorkspaceId: authContext.userWorkspaceId,
|
|
setting: permissionRequired,
|
|
workspaceId: workspace.id,
|
|
isExecutedByApiKey: isDefined(authContext.apiKey),
|
|
});
|
|
|
|
if (!userHasPermission) {
|
|
throw new PermissionsException(
|
|
PermissionsExceptionMessage.PERMISSION_DENIED,
|
|
PermissionsExceptionCode.PERMISSION_DENIED,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
private getRequiredPermissionForMethod(
|
|
operationName: WorkspaceResolverBuilderMethodNames,
|
|
) {
|
|
switch (operationName) {
|
|
case RESOLVER_METHOD_NAMES.FIND_MANY:
|
|
case RESOLVER_METHOD_NAMES.FIND_ONE:
|
|
case RESOLVER_METHOD_NAMES.FIND_DUPLICATES:
|
|
return PermissionsOnAllObjectRecords.READ_ALL_OBJECT_RECORDS;
|
|
case RESOLVER_METHOD_NAMES.CREATE_MANY:
|
|
case RESOLVER_METHOD_NAMES.CREATE_ONE:
|
|
case RESOLVER_METHOD_NAMES.UPDATE_MANY:
|
|
case RESOLVER_METHOD_NAMES.UPDATE_ONE:
|
|
return PermissionsOnAllObjectRecords.UPDATE_ALL_OBJECT_RECORDS;
|
|
case RESOLVER_METHOD_NAMES.DELETE_MANY:
|
|
case RESOLVER_METHOD_NAMES.DELETE_ONE:
|
|
case RESOLVER_METHOD_NAMES.RESTORE_MANY:
|
|
case RESOLVER_METHOD_NAMES.RESTORE_ONE:
|
|
return PermissionsOnAllObjectRecords.SOFT_DELETE_ALL_OBJECT_RECORDS;
|
|
case RESOLVER_METHOD_NAMES.DESTROY_MANY:
|
|
case RESOLVER_METHOD_NAMES.DESTROY_ONE:
|
|
return PermissionsOnAllObjectRecords.DESTROY_ALL_OBJECT_RECORDS;
|
|
default:
|
|
throw new PermissionsException(
|
|
PermissionsExceptionMessage.UNKNOWN_OPERATION_NAME,
|
|
PermissionsExceptionCode.UNKNOWN_OPERATION_NAME,
|
|
);
|
|
}
|
|
}
|
|
|
|
protected abstract resolve(
|
|
executionArgs: GraphqlQueryResolverExecutionArgs<Input>,
|
|
featureFlagsMap: Record<FeatureFlagKey, boolean>,
|
|
): Promise<Response>;
|
|
|
|
protected abstract validate(
|
|
args: Input,
|
|
options: WorkspaceQueryRunnerOptions,
|
|
): Promise<void>;
|
|
}
|