Etienne
d562a384c2
Bug fixes exposed by always-on direct execution
1. GraphQL spec compliance — data[field] = null on resolver error
direct-execution.service.ts — Changed from Promise.allSettled (which
lost the responseKey on rejection) to Promise.all with per-field
try/catch; errors now set data[responseKey] = null per spec
2. Empty object arguments skipped (extractArgumentsFromAst)
extract-arguments-from-ast.util.ts — Removed isEmptyObject check;
filter: {}, data: {} now correctly passed to resolvers instead of
silently dropped (which caused permissions to never be checked)
3. orderBy: {} factory default treated as "no ordering"
direct-execution.service.ts — Before calling the resolver, strips
orderBy: {} and orderByForRecords: {} (empty-object factory defaults
that mean "no ordering")
assert-find-many-args.util.ts / assert-group-by-args.util.ts — Accept {}
for orderBy without throwing
4. orderBy: { field: '...' } object auto-coerced to [{ field: '...' }]
array
direct-execution.service.ts — Applies GraphQL list coercion: a
non-array, non-empty orderBy object is wrapped in an array before
assertion and resolver call
5. totalCount and aggregate fields returned as strings from PostgreSQL
graphql-format-result-from-selected-fields.util.ts — Added
coerceAggregateValue that parses numeric strings to numbers for
totalCount, sum*, avg*, min*, max*, count*, percentageOf* fields
Test updates
nested-relation-queries.integration-spec.ts — Updated expected error
message from Yoga schema-validation message to direct execution resolver
message
~30 snapshot files — Updated to reflect direct execution's error
messages (different from Yoga schema-validation messages for input type
errors)
43 lines
1.5 KiB
TypeScript
43 lines
1.5 KiB
TypeScript
import { isObject } from 'class-validator';
|
|
|
|
import { STANDARD_ERROR_MESSAGE } from 'src/engine/api/common/common-query-runners/errors/standard-error-message.constant';
|
|
import {
|
|
GraphqlDirectExecutionException,
|
|
GraphqlDirectExecutionExceptionCode,
|
|
} from 'src/engine/api/graphql/direct-execution/errors/graphql-direct-execution.exception';
|
|
import { type DestroyManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
|
|
|
|
export function assertDestroyManyArgs(
|
|
args: unknown,
|
|
): asserts args is DestroyManyResolverArgs {
|
|
if (!isObject(args)) {
|
|
throw new GraphqlDirectExecutionException(
|
|
'Invalid argument: it must be an object',
|
|
GraphqlDirectExecutionExceptionCode.INVALID_QUERY_INPUT,
|
|
{ userFriendlyMessage: STANDARD_ERROR_MESSAGE },
|
|
);
|
|
}
|
|
|
|
const argKeys = Object.keys(args);
|
|
|
|
const allowedKeys = new Set(['filter']);
|
|
|
|
for (const key of argKeys) {
|
|
if (!allowedKeys.has(key)) {
|
|
throw new GraphqlDirectExecutionException(
|
|
`Argument not allowed: ${key}`,
|
|
GraphqlDirectExecutionExceptionCode.INVALID_QUERY_INPUT,
|
|
{ userFriendlyMessage: STANDARD_ERROR_MESSAGE },
|
|
);
|
|
}
|
|
}
|
|
|
|
if (!('filter' in args) || !isObject(args.filter)) {
|
|
throw new GraphqlDirectExecutionException(
|
|
'Missing required argument: "filter" (object)',
|
|
GraphqlDirectExecutionExceptionCode.INVALID_QUERY_INPUT,
|
|
{ userFriendlyMessage: STANDARD_ERROR_MESSAGE },
|
|
);
|
|
}
|
|
}
|