59fbe35a8c
# Introduction Preparing view-filter and view-group introduction in v2 core engine Moving view from `core-modules` to `metadata-modules` ## What happened ### Created dedicated modules for each view entity: - ViewFieldModule - ViewFilterModule - ViewFilterGroupModule - ViewGroupModule - ViewSortModule ### Each module is now completely independent with its own: - Controller - Resolver - Service - Entity ### Created dedicated abstraction metadata module folder for: - flat-view-field - flat-view ### Dependencies - Eleminated circular dep on ViewModule to all others ones - Granular import not importing the whole viewModule anymore everywhere close https://github.com/twentyhq/core-team-issues/issues/1703
137 lines
4.8 KiB
TypeScript
137 lines
4.8 KiB
TypeScript
import { createOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata.util';
|
|
import { deleteOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/delete-one-field-metadata.util';
|
|
import { updateOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/update-one-field-metadata.util';
|
|
import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
|
|
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
|
|
import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';
|
|
import { updateFeatureFlag } from 'test/integration/metadata/suites/utils/update-feature-flag.util';
|
|
import {
|
|
createTestViewWithRestApi,
|
|
findViewByIdWithRestApi,
|
|
} from 'test/integration/rest/utils/view-rest-api.util';
|
|
import { generateRecordName } from 'test/integration/utils/generate-record-name';
|
|
import { FieldMetadataType } from 'twenty-shared/types';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
import { AggregateOperations } from 'src/engine/api/graphql/graphql-query-runner/constants/aggregate-operations.constant';
|
|
import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
|
|
import { ViewType } from 'src/engine/metadata-modules/view/enums/view-type.enum';
|
|
|
|
describe('deleteOne', () => {
|
|
beforeAll(async () => {
|
|
await updateFeatureFlag({
|
|
expectToFail: false,
|
|
featureFlag: FeatureFlagKey.IS_WORKSPACE_MIGRATION_V2_ENABLED,
|
|
value: false,
|
|
});
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await updateFeatureFlag({
|
|
expectToFail: false,
|
|
featureFlag: FeatureFlagKey.IS_WORKSPACE_MIGRATION_V2_ENABLED,
|
|
value: true,
|
|
});
|
|
});
|
|
describe('Kanban aggregate operation', () => {
|
|
let listingObjectId = '';
|
|
let testFieldId = '';
|
|
let viewId = '';
|
|
|
|
beforeEach(async () => {
|
|
const { data } = await createOneObjectMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
nameSingular: 'listingv2',
|
|
namePlural: 'listingsv2',
|
|
labelSingular: 'Listing',
|
|
labelPlural: 'Listings',
|
|
icon: 'IconBuildingSkyscraper',
|
|
},
|
|
});
|
|
|
|
listingObjectId = data.createOneObject.id;
|
|
const { data: createdFieldData } = await createOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
name: 'house',
|
|
type: FieldMetadataType.TEXT,
|
|
label: 'House',
|
|
objectMetadataId: listingObjectId,
|
|
},
|
|
});
|
|
|
|
testFieldId = createdFieldData.createOneField.id;
|
|
|
|
const createdView = await createTestViewWithRestApi({
|
|
name: generateRecordName('By Type'),
|
|
objectMetadataId: listingObjectId,
|
|
type: ViewType.KANBAN,
|
|
kanbanAggregateOperationFieldMetadataId: testFieldId,
|
|
kanbanAggregateOperation: AggregateOperations.MAX,
|
|
icon: 'IconLayoutKanban',
|
|
});
|
|
|
|
viewId = createdView.id;
|
|
});
|
|
afterEach(async () => {
|
|
await updateOneObjectMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
idToUpdate: listingObjectId,
|
|
updatePayload: {
|
|
isActive: false,
|
|
},
|
|
},
|
|
});
|
|
await deleteOneObjectMetadata({
|
|
expectToFail: false,
|
|
input: { idToDelete: listingObjectId },
|
|
});
|
|
});
|
|
|
|
it('should reset kanban aggregate operation when deleting a field used as kanbanAggregateOperationFieldMetadataId', async () => {
|
|
const viewThatShouldBeUpdated = await findViewByIdWithRestApi(viewId);
|
|
|
|
if (!isDefined(viewThatShouldBeUpdated)) {
|
|
throw new Error('View not found, this should not happen');
|
|
}
|
|
|
|
expect(
|
|
viewThatShouldBeUpdated.kanbanAggregateOperationFieldMetadataId,
|
|
).toBe(testFieldId);
|
|
expect(viewThatShouldBeUpdated.kanbanAggregateOperation).toBe('MAX');
|
|
|
|
await updateOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
idToUpdate: testFieldId,
|
|
updatePayload: { isActive: false },
|
|
},
|
|
gqlFields: `
|
|
id
|
|
isActive
|
|
`,
|
|
});
|
|
|
|
const { data } = await deleteOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: { idToDelete: testFieldId },
|
|
});
|
|
|
|
expect(data.deleteOneField.id).toBe(testFieldId);
|
|
|
|
const updatedViewResponse = await findViewByIdWithRestApi(viewId);
|
|
|
|
if (!isDefined(updatedViewResponse)) {
|
|
throw new Error('View not found, this should not happen');
|
|
}
|
|
|
|
expect(
|
|
updatedViewResponse.kanbanAggregateOperationFieldMetadataId,
|
|
).toBeNull();
|
|
expect(updatedViewResponse.kanbanAggregateOperation).toBe(null);
|
|
});
|
|
});
|
|
});
|