59fbe35a8c
# Introduction Preparing view-filter and view-group introduction in v2 core engine Moving view from `core-modules` to `metadata-modules` ## What happened ### Created dedicated modules for each view entity: - ViewFieldModule - ViewFilterModule - ViewFilterGroupModule - ViewGroupModule - ViewSortModule ### Each module is now completely independent with its own: - Controller - Resolver - Service - Entity ### Created dedicated abstraction metadata module folder for: - flat-view-field - flat-view ### Dependencies - Eleminated circular dep on ViewModule to all others ones - Granular import not importing the whole viewModule anymore everywhere close https://github.com/twentyhq/core-team-issues/issues/1703
146 lines
4.2 KiB
TypeScript
146 lines
4.2 KiB
TypeScript
import {
|
|
type ViewFieldTestSetup,
|
|
cleanupViewFieldTestV2,
|
|
setupViewFieldTestV2,
|
|
} from 'test/integration/graphql/suites/view/utils/setup-view-field-test-v2.util';
|
|
import { createOneCoreViewField } from 'test/integration/metadata/suites/view-field/utils/create-one-core-view-field.util';
|
|
import { deleteOneCoreViewField } from 'test/integration/metadata/suites/view-field/utils/delete-one-core-view-field.util';
|
|
import { destroyOneCoreViewField } from 'test/integration/metadata/suites/view-field/utils/destroy-one-core-view-field.util';
|
|
import { assertViewFieldStructure } from 'test/integration/utils/view-test.util';
|
|
import {
|
|
type EachTestingContext,
|
|
eachTestingContextFilter,
|
|
} from 'twenty-shared/testing';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
import { type CreateViewFieldInput } from 'src/engine/metadata-modules/view-field/dtos/inputs/create-view-field.input';
|
|
import { type ViewFieldDTO } from 'src/engine/metadata-modules/view-field/dtos/view-field.dto';
|
|
|
|
type TestContext = {
|
|
viewFieldInput: (testSetup: ViewFieldTestSetup) => CreateViewFieldInput;
|
|
expected: Partial<ViewFieldDTO>;
|
|
};
|
|
|
|
describe('View Field Resolver - Successful Create Operations - v2', () => {
|
|
let testSetup: ViewFieldTestSetup;
|
|
let createdViewFieldId: string | undefined;
|
|
|
|
beforeAll(async () => {
|
|
testSetup = await setupViewFieldTestV2();
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await cleanupViewFieldTestV2(testSetup.testObjectMetadataId);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
if (isDefined(createdViewFieldId)) {
|
|
const {
|
|
data: { deleteCoreViewField },
|
|
} = await deleteOneCoreViewField({
|
|
expectToFail: false,
|
|
input: {
|
|
id: createdViewFieldId,
|
|
},
|
|
});
|
|
|
|
expect(deleteCoreViewField.deletedAt).not.toBeNull();
|
|
await destroyOneCoreViewField({
|
|
expectToFail: false,
|
|
input: {
|
|
id: createdViewFieldId,
|
|
},
|
|
});
|
|
createdViewFieldId = undefined;
|
|
}
|
|
});
|
|
|
|
const successfulTestCases: EachTestingContext<TestContext>[] = [
|
|
{
|
|
title: 'visible field with position and size',
|
|
context: {
|
|
viewFieldInput: (testSetup) => ({
|
|
fieldMetadataId: testSetup.testFieldMetadataId,
|
|
viewId: testSetup.testViewId,
|
|
position: 1,
|
|
isVisible: true,
|
|
size: 200,
|
|
}),
|
|
expected: {
|
|
position: 1,
|
|
isVisible: true,
|
|
size: 200,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'hidden field with position and size',
|
|
context: {
|
|
viewFieldInput: (testSetup) => ({
|
|
fieldMetadataId: testSetup.testFieldMetadataId,
|
|
viewId: testSetup.testViewId,
|
|
position: 2,
|
|
isVisible: false,
|
|
size: 100,
|
|
}),
|
|
expected: {
|
|
position: 2,
|
|
isVisible: false,
|
|
size: 100,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'field with minimum required properties',
|
|
context: {
|
|
viewFieldInput: (testSetup) => ({
|
|
fieldMetadataId: testSetup.testFieldMetadataId,
|
|
viewId: testSetup.testViewId,
|
|
}),
|
|
expected: {
|
|
position: 0,
|
|
isVisible: true,
|
|
size: 0,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'field with maximum size',
|
|
context: {
|
|
viewFieldInput: (testSetup) => ({
|
|
fieldMetadataId: testSetup.testFieldMetadataId,
|
|
viewId: testSetup.testViewId,
|
|
position: 3,
|
|
isVisible: true,
|
|
size: 1000,
|
|
}),
|
|
expected: {
|
|
position: 3,
|
|
isVisible: true,
|
|
size: 1000,
|
|
},
|
|
},
|
|
},
|
|
];
|
|
|
|
test.each(eachTestingContextFilter(successfulTestCases))(
|
|
'Create $title',
|
|
async ({ context: { viewFieldInput, expected } }) => {
|
|
const response = await createOneCoreViewField({
|
|
input: viewFieldInput(testSetup),
|
|
expectToFail: false,
|
|
});
|
|
|
|
expect(response.errors).toBeUndefined();
|
|
expect(response.data.createCoreViewField).toBeDefined();
|
|
createdViewFieldId = response.data.createCoreViewField.id;
|
|
|
|
assertViewFieldStructure(response.data.createCoreViewField, {
|
|
fieldMetadataId: testSetup.testFieldMetadataId,
|
|
viewId: testSetup.testViewId,
|
|
...expected,
|
|
});
|
|
},
|
|
);
|
|
});
|