6c40c7b91a
# Introduction Close twentyhq/core-team-issues#2641 Auto-provisioned field metadata used to get its `universalIdentifier` from three unrelated sources: random `v4()` on the server when creating custom objects, hardcoded values in `STANDARD_OBJECTS`, and an ad-hoc `v5` derivation in the SDK manifest build. This PR unifies all of them behind the shared `getFieldUniversalIdentifier` derivation: ``` universalIdentifier = f(applicationUniversalIdentifier, objectUniversalIdentifier, fieldName) ``` ## Ownership model The rollout is built on an explicit split of who owns a field's universal identifier: - **The 8 system fields** (`id`, `createdAt`, `updatedAt`, `deletedAt`, `createdBy`, `updatedBy`, `position`, `searchVector`) are **server-owned**. Their universal identifiers are always the deterministic derivation, on **every** application (standard, workspace-custom, installed). Clients cannot provide custom values: a temporary check in `validateObjectMetadataSystemFieldsIntegrity` rejects any non-derived system field identifier at migration build time. This check stands in until system fields are generated exclusively server side by the metadata side-effect engine and stripped from client inputs — at which point it becomes structurally impossible to send one. - **`name` is a default field, not a system field**: it is auto-provisioned when absent (server side for custom objects, SDK side for application objects) but authors can define their own. It is only derived where it is guaranteed to be auto-provisioned. In particular, standard objects keep their **historical hardcoded** `name` identifiers: the standard app authors its `name` fields like any installed app would, and moving those identifiers would break every installed application referencing them (e.g. views on `opportunity.name`). - **User-created and author-provided fields** keep random / explicit identifiers, untouched. ## Server - `validateObjectMetadataSystemFieldsIntegrity` now validates, on top of the existing type/`isSystem` checks, that each system field's `universalIdentifier` equals the deterministic derivation. Runs for every object creation going through the migration orchestrator: app sync, custom object creation, standard provisioning - `build-default-flat-field-metadatas-for-custom-object.util.ts` derives the system field identifiers (and the auto-provisioned `name`) with `getFieldUniversalIdentifier` instead of `v4()` - `build-default-relation-flat-field-metadatas-for-custom-object.util.ts` derives both the forward and the reverse default relation field identifiers deterministically - `generateMorphOrRelationFlatFieldMetadataPair` accepts optional `sourceFieldUniversalIdentifier` / `targetFieldUniversalIdentifier` so callers can inject deterministic values; user-created relations still default to `v4()` ## twenty-shared - `STANDARD_OBJECTS` system field identifiers (the 8) are now computed at module load via `buildStandardObjectSystemFields`; `name` and every other identifier keep their hardcoded values - New snapshot test pinning **every** universal identifier of `STANDARD_OBJECTS`: any identifier change now requires an explicit snapshot update and should ship with a coordinated backfill ## SDK (breaking, pre-GA) - `generateDefaultFieldUniversalIdentifier` delegates to `getFieldUniversalIdentifier` and now requires `applicationUniversalIdentifier` - Reverse default relation field identifiers are derived from the field's real coordinates (standard object UID + actual field name, e.g. `targetRocket` on `attachment`) instead of the legacy custom-object UID + synthetic `${fieldName}Inverse` hash input. Field *names* are unchanged - The manifest build threads the application universal identifier through default field injection (two-pass over object configs) - `twenty dev:add` now resolves the application universal identifier upfront and refuses to scaffold anything until `defineApplication` declares one — no more `fill-later` placeholder for the app UID in generated files ## Upgrade A 2.19 **workspace command** backfills existing `fieldMetadata.universalIdentifier` rows to the deterministic derivation. Coverage follows the ownership model: - **The 8 system fields**: taken over for **every application**, whatever value they currently hold. This is both safe and required now that sync rejects non-derived values — leaving a row unconverged would make its application unsyncable - **`name`**: workspace-custom app → always taken over (server-generated, no author to clobber); installed applications → only rows still carrying the legacy SDK derivation are recomputed, author-provided identifiers are never touched; standard app → never touched (hardcoded in `STANDARD_OBJECTS`) - **Default relation fields**: workspace-custom app → forward fields on custom objects and reverse fields on the standard relation objects; installed applications → legacy-derivation probe only All identifiers of a workspace are updated inside a single transaction, then the command flushes the field-metadata-related workspace caches and bumps the metadata version. Stored `applicationRegistration.manifest` snapshots are intentionally **not** rewritten: installs and upgrades always sync from the `manifest.json` inside the resolved package (npm/tarball), the stored column is only used for display/marketplace purposes. ## Breaking behavior for old packages (fail closed) Packages built with an older SDK carry legacy system field identifiers in their tarball `manifest.json`. Installing or upgrading such a package now fails with an explicit `INVALID_SYSTEM_FIELD` validation error ("universal identifier is not deterministic") instead of silently mismatching against the backfilled rows and triggering a destructive delete+create. The remediation is to rebuild the package with the new SDK; the backfill has already converged the installed rows, so the rebuilt manifest syncs cleanly. ## Test plan - [x] `twenty-sdk` unit tests (526 tests) and typecheck - [x] `twenty-shared` unit tests (1635 tests) including the `STANDARD_OBJECTS` snapshot; `name` identifiers verified byte-for-byte identical to `main` - [x] Lint and typecheck clean on all touched packages - [x] Integration: create a custom object and verify system + default relation field identifiers match the deterministic derivation (`create-one-object-metadata-deterministic-field-universal-identifiers`, 13 assertions passing) - [x] Integration: `failing-sync-application-object-system-fields` extended with a non-derived system field identifier case; all identifiers in the spec pinned deterministically so snapshots embedding expected/actual values are stable across runs (verified with a double run) - [x] Integration: all application sync suites pass with the derived system field identifiers now required by the `buildDefaultObjectManifest` test helper (9 suites, 20 tests) - [x] Full test-database reset: standard app provisioning and seeded workspaces pass the new validation - [x] SDK manifest build verified on the postcard example app: all auto-generated default field identifiers match the derivation - [ ] Run `upgrade:2-19:backfill-deterministic-field-universal-identifiers` (dry-run then real) on a seeded workspace and verify identifier convergence with a rebuilt app manifest
149 lines
4.8 KiB
TypeScript
149 lines
4.8 KiB
TypeScript
import { buildBaseManifest } from 'test/integration/metadata/suites/application/utils/build-base-manifest.util';
|
|
import { cleanupApplicationAndAppRegistration } from 'test/integration/metadata/suites/application/utils/cleanup-application-and-app-registration.util';
|
|
import { setupApplicationForSync } from 'test/integration/metadata/suites/application/utils/setup-application-for-sync.util';
|
|
import { syncApplication } from 'test/integration/metadata/suites/application/utils/sync-application.util';
|
|
import {
|
|
type LogicFunctionManifest,
|
|
type Manifest,
|
|
} from 'twenty-shared/application';
|
|
import { v4 as uuidv4 } from 'uuid';
|
|
|
|
/**
|
|
* Performance harness for installing / updating many logic functions through
|
|
* application manifest sync. The goal is to find what could take >10s in prod
|
|
* (which trips the node-postgres `query_timeout` in core.datasource.ts and
|
|
* produces "Migration action 'update' for 'logicFunction' failed" + 504).
|
|
*
|
|
* IMPORTANT: the integration harness boots the NestJS app in-process with
|
|
* `fakeTimers.enableGlobally: true`. We call `jest.useRealTimers()` for the whole
|
|
* suite so timing (`performance.now()`) is real and cache-lock retry delays etc.
|
|
* do not hang.
|
|
*/
|
|
|
|
// Real timers for the whole suite — see note above.
|
|
jest.useRealTimers();
|
|
|
|
jest.setTimeout(120000);
|
|
|
|
const FN_COUNTS = [1, 8, 30];
|
|
|
|
// Stable universalIdentifiers across versions so the second sync exercises
|
|
// UPDATE (the actual incident), not CREATE+DELETE.
|
|
const buildManifest = ({
|
|
appId,
|
|
roleId,
|
|
universalIdentifiers,
|
|
checksumVersion,
|
|
}: {
|
|
appId: string;
|
|
roleId: string;
|
|
universalIdentifiers: string[];
|
|
checksumVersion: 'v1' | 'v2';
|
|
}): Manifest => {
|
|
const logicFunctions: LogicFunctionManifest[] = universalIdentifiers.map(
|
|
(universalIdentifier, i) => ({
|
|
universalIdentifier,
|
|
name: `PerfFn${i}`,
|
|
description: `Perf logic function ${i}`,
|
|
handlerName: 'handler',
|
|
sourceHandlerPath: `src/fn-${i}.ts`,
|
|
builtHandlerPath: `dist/fn-${i}.mjs`,
|
|
builtHandlerChecksum: `checksum-${i}-${checksumVersion}`,
|
|
httpRouteTriggerSettings: {
|
|
path: `/fn-${i}`,
|
|
httpMethod: 'GET',
|
|
isAuthRequired: true,
|
|
},
|
|
}),
|
|
);
|
|
|
|
return buildBaseManifest({
|
|
appId,
|
|
roleId,
|
|
overrides: { logicFunctions },
|
|
});
|
|
};
|
|
|
|
const timeSync = async (label: string, manifest: Manifest): Promise<number> => {
|
|
const start = performance.now();
|
|
|
|
await syncApplication({ manifest, expectToFail: false });
|
|
|
|
const ms = performance.now() - start;
|
|
|
|
// oxlint-disable-next-line no-console
|
|
console.log(`[install-perf][test] ${label} took ${ms.toFixed(1)}ms`);
|
|
|
|
return ms;
|
|
};
|
|
|
|
// TODO(install-perf): temporary manual perf harness, remove. Skipped in CI.
|
|
describe.skip('Logic function install performance', () => {
|
|
it.each(FN_COUNTS)(
|
|
'create + update sync with %i logic functions',
|
|
async (count) => {
|
|
const appId = uuidv4();
|
|
const roleId = uuidv4();
|
|
const universalIdentifiers = Array.from({ length: count }, () =>
|
|
uuidv4(),
|
|
);
|
|
|
|
await setupApplicationForSync({
|
|
applicationUniversalIdentifier: appId,
|
|
name: `Perf App ${count}`,
|
|
description: `Perf app with ${count} logic functions`,
|
|
sourcePath: `perf-app-${count}`,
|
|
});
|
|
|
|
jest.useRealTimers();
|
|
|
|
try {
|
|
// No built-handler file upload is needed: the migration create/update
|
|
// handlers never read the built file for LIVE functions (prebuilt
|
|
// install is skipped), and uploading N files would trip the file-upload
|
|
// rate limiter (30 per 30s). We only measure migration + cache cost.
|
|
|
|
// oxlint-disable-next-line no-console
|
|
console.log(
|
|
`[install-perf][test] ===== N=${count} : FIRST SYNC (create ${count} functions) =====`,
|
|
);
|
|
|
|
const createMs = await timeSync(
|
|
`N=${count} create sync`,
|
|
buildManifest({
|
|
appId,
|
|
roleId,
|
|
universalIdentifiers,
|
|
checksumVersion: 'v1',
|
|
}),
|
|
);
|
|
|
|
// oxlint-disable-next-line no-console
|
|
console.log(
|
|
`[install-perf][test] ===== N=${count} : SECOND SYNC (update ${count} functions, checksum v2) =====`,
|
|
);
|
|
|
|
const updateMs = await timeSync(
|
|
`N=${count} update sync`,
|
|
buildManifest({
|
|
appId,
|
|
roleId,
|
|
universalIdentifiers,
|
|
checksumVersion: 'v2',
|
|
}),
|
|
);
|
|
|
|
// oxlint-disable-next-line no-console
|
|
console.log(
|
|
`[install-perf][test] ===== N=${count} SUMMARY: create=${createMs.toFixed(1)}ms update=${updateMs.toFixed(1)}ms =====`,
|
|
);
|
|
} finally {
|
|
await cleanupApplicationAndAppRegistration({
|
|
applicationUniversalIdentifier: appId,
|
|
});
|
|
}
|
|
},
|
|
120000,
|
|
);
|
|
});
|