Charles Bochet
c53a13417e
## Summary
Eliminates all ~350 `styled(Component)` usages across `twenty-front` and
`twenty-ui` (212 files changed). Each was replaced following these
rules:
- **Margin/layout CSS** (margin, padding, flex, align-self, width) →
wrapped in a `styled.div`/`styled.span` parent container
- **Third-party components** (Link, TextareaAutosize,
ReactPhoneNumberInput, Handle, etc.) → parent container with child CSS
selectors (`> a`, `> textarea`, `> input`, etc.)
- **Intrinsic behavior via existing props** (TableRow
`gridTemplateColumns`, TableCell `color`/`align`) → replaced
`styled(TableRow)` / `styled(TableCell)` with direct prop usage
- **Other visual overrides on twenty-ui components** (Card, Section,
TabList, Button, MenuItem, ScrollWrapper, etc.) → parent wrappers with
`> div` / `> *` child selectors
- **Extending styled.div/span** → merged all CSS into a single
`styled.div`/`styled.span`
Also adds `overflow: hidden` to parent containers wrapping
`ScrollWrapper` so scroll activates correctly with the new wrapper
structure.
### Migration patterns
| Before | After |
|--------|-------|
| `styled(Avatar)` with `margin-right` | `<StyledAvatarContainer><Avatar
/></StyledAvatarContainer>` |
| `styled(Link)` with `text-decoration: none` |
`<StyledLinkContainer><Link /></StyledLinkContainer>` with `> a { ... }`
|
| `styled(TableRow)` with `grid-template-columns` | `<TableRow
gridTemplateColumns="..." />` |
| `styled(TableCell)` with `color` / `align` | `<TableCell color={...}
align="right" />` |
| `styled(Card)` with `margin-top` | `<StyledCardContainer><Card
/></StyledCardContainer>` |
| `styled(TabList)` with `background` |
`<StyledTabListContainer><TabList /></StyledTabListContainer>` with `>
div { ... }` |
| `styled(StyledBase)` extending a `styled.div` | Single merged
`styled.div` with all styles inlined |
49 lines
1.2 KiB
TypeScript
49 lines
1.2 KiB
TypeScript
import { styled } from '@linaria/react';
|
|
import { type ReactNode } from 'react';
|
|
|
|
import { StyledFormCardTitle } from '@/settings/data-model/fields/components/StyledFormCardTitle';
|
|
import { Trans } from '@lingui/react/macro';
|
|
import { Card, CardContent } from 'twenty-ui/layout';
|
|
import { themeCssVariables } from 'twenty-ui/theme-constants';
|
|
|
|
type SettingsDataModelPreviewFormCardProps = {
|
|
className?: string;
|
|
preview: ReactNode;
|
|
form?: ReactNode;
|
|
disabled?: boolean;
|
|
};
|
|
|
|
const StyledPreviewContainerWrapper = styled.div`
|
|
> * {
|
|
background-color: ${themeCssVariables.background.transparent.lighter};
|
|
}
|
|
`;
|
|
|
|
const StyledFormContainerWrapper = styled.div`
|
|
> * {
|
|
padding: 0;
|
|
}
|
|
`;
|
|
|
|
export const SettingsDataModelPreviewFormCard = ({
|
|
className,
|
|
preview,
|
|
form,
|
|
}: SettingsDataModelPreviewFormCardProps) => (
|
|
<Card className={className} fullWidth rounded>
|
|
<StyledPreviewContainerWrapper>
|
|
<CardContent divider={!!form}>
|
|
<StyledFormCardTitle>
|
|
<Trans>Preview</Trans>
|
|
</StyledFormCardTitle>
|
|
{preview}
|
|
</CardContent>
|
|
</StyledPreviewContainerWrapper>
|
|
{!!form && (
|
|
<StyledFormContainerWrapper>
|
|
<CardContent>{form}</CardContent>
|
|
</StyledFormContainerWrapper>
|
|
)}
|
|
</Card>
|
|
);
|