twenty/packages/twenty-front/src/modules at bea7857a1c578876169a7f406a49fd7cad82bd39 - twenty - Gitea: Git with a cup of tea

houseassassin/twenty

Files

T

History

Thomas des Francs bea7857a1c Fix settings page root overflow (#22207 )

## Summary

- Clamp the fixed app shell with `overflow: hidden` so long nested
settings scroll content no longer contributes to the document root
scroll range.
- Keeps the object permission page scrolling inside its existing
settings `ScrollWrapper` instead of letting the whole page slide under
the viewport.

## Screenshots

Before: root document can scroll under the bottom of the viewport and
exposes the gray app background.

![Before root
scroll](https://raw.githubusercontent.com/twentyhq/twenty/bonapara/pr-screenshots-settings-root-scroll-20260626/.github/pr-screenshots/fix-settings-root-scroll/before-object-permission-root-scroll.png)

After: the same root scroll attempt leaves the app shell fixed to the
viewport.

![After root
scroll](https://raw.githubusercontent.com/twentyhq/twenty/bonapara/pr-screenshots-settings-root-scroll-20260626/.github/pr-screenshots/fix-settings-root-scroll/after-object-permission-root-scroll.png)

## Browser Validation

Route tested:
`/settings/members/roles/78fa69cb-1237-43b5-bfa5-5a11a47bf781/object/5ab1a16b-7811-471f-ac53-940666c667dd`

- Before on `http://apple.localhost:3001`: `window.scrollTo(0, 9999)`
moved the root to `scrollY=244.5`; `htmlScrollHeight=1287`,
`htmlClientHeight=1043`.
- After on `http://apple.localhost:3002`: the same root scroll attempt
stayed at `scrollY=0`; `htmlScrollHeight=1043`, `htmlClientHeight=1043`.
- The settings content still scrolls internally: wrapper
`scrollHeight=1475`, `clientHeight=955`.

## Checks

- `git diff --check`
- `yarn oxfmt --check
packages/twenty-front/src/modules/ui/layout/page/components/DefaultLayout.tsx`
- `cd packages/twenty-front && npx oxlint --type-aware -c .oxlintrc.json
src/modules/ui/layout/page/components/DefaultLayout.tsx`


<!-- This is an auto-generated description by cubic. -->
<a
href="https://cubic.dev/pr/twentyhq/twenty/pull/22207?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>
<!-- End of auto-generated description by cubic. -->

2026-06-26 11:34:19 +02:00

..

messaging: gmail folder backfill (#21753 )

2026-06-19 01:59:35 +02:00

Remove custom widget from calendarEvent page layout (#22046 )

2026-06-24 08:59:14 +02:00

advanced-text-editor

Reorganize twenty-ui into best-practice component domains and per-component folders (#21745 )

2026-06-18 10:31:29 +02:00

fix(ai-chat) - improvements (#22193 )

2026-06-26 10:26:40 +02:00

…

fix(front): emit error instead of completing empty on failed token renewal (#21822 )

2026-06-19 10:24:31 +02:00

Add v2 onboarding loading screen while creating workspace (#22152 )

2026-06-26 08:46:34 +00:00

fix(front): restore loading state on third-party app command menu actions (#22073 )

2026-06-24 15:05:28 +02:00

Add v2 onboarding loading screen while creating workspace (#22152 )

2026-06-26 08:46:34 +00:00

blocknote-editor

fix(front): wrap long note/markdown text on mobile browsers (#21909 )

2026-06-25 16:49:11 +02:00

…

Add new onboarding login screen at /welcome-v2 (#22027 )

2026-06-24 12:13:55 +00:00

feat: serve HTTP logic functions on isolated *.withtwenty.com domain (#22045 )

2026-06-24 15:57:01 +02:00

Reorganize twenty-ui into best-practice component domains and per-component folders (#21745 )

2026-06-18 10:31:29 +02:00

command-menu-item

Close side panel after command menu actions (#22118 )

2026-06-24 19:15:01 +02:00

companies/types

Migrate Company and Person standard fields in preparation for the enrichment app (#21171 )

2026-06-04 15:54:04 +00:00

fix(front): mass update targets explicitly selected records (#21548 )

2026-06-14 19:11:46 +00:00

…

debug/components

…

Add v2 onboarding loading screen while creating workspace (#22152 )

2026-06-26 08:46:34 +00:00

dropdown-context-state-management/hooks

…

Reorganize twenty-ui into best-practice component domains and per-component folders (#21745 )

2026-06-18 10:31:29 +02:00

Reorganize twenty-ui into best-practice component domains and per-component folders (#21745 )

2026-06-18 10:31:29 +02:00

…

front-components

feat(apps): let front components open a record in the side panel (#22140 )

2026-06-25 10:47:39 +02:00

Remove twenty-ui-deprecated and migrate frontend to twenty-ui (#21596 )

2026-06-17 09:41:11 +00:00

information-banner

feat(billing): embed credit card form in the add-card trial-end modal (#22125 )

2026-06-25 04:49:31 +02:00

keyboard-shortcut-menu

Reorganize twenty-ui into best-practice component domains and per-component folders (#21745 )

2026-06-18 10:31:29 +02:00

layout-customization

Reorganize twenty-ui into best-practice component domains and per-component folders (#21745 )

2026-06-18 10:31:29 +02:00

Remove randomness from flaky twenty-front Storybook stories (#21594 )

2026-06-15 13:37:19 +02:00

logic-functions

Infer record pickers for record-typed logic function workflow inputs (#21494 )

2026-06-19 09:10:01 +02:00

Reorganize twenty-ui into best-practice component domains and per-component folders (#21745 )

2026-06-18 10:31:29 +02:00

Decouple twenty-ui Avatar from app server-URL config (#21968 )

2026-06-22 18:38:00 +02:00

metadata-error-handler

Wire up search field metadata (#21964 )

2026-06-23 16:27:13 +02:00

Add v2 onboarding loading screen while creating workspace (#22152 )

2026-06-26 08:46:34 +00:00

Use settings icon in settings drawer tab (#22204 )

2026-06-26 09:14:30 +00:00

navigation-menu-item

Add search to new sidebar item picker (#22041 )

2026-06-24 14:05:23 +02:00

object-metadata

Feat: group records by many to one relation (#22123 )

2026-06-25 13:55:50 +02:00

Set record card header height and calendar spacing (#22187 )

2026-06-26 10:19:24 +02:00

Reorganize twenty-ui into best-practice component domains and per-component folders (#21745 )

2026-06-18 10:31:29 +02:00

feat(front): allow advanced relation fields in FieldWidget selector (#22005 )

2026-06-24 10:30:42 +02:00

Migrate Company and Person standard fields in preparation for the enrichment app (#21171 )

2026-06-04 15:54:04 +00:00

fix(billing): widen embedded add-card modal and align its buttons (#22141 )

2026-06-25 06:52:49 +02:00

fix mobile side panel close (#22169 )

2026-06-25 14:55:04 +02:00

sign-in-background-mock

Decouple twenty-ui Avatar from app server-URL config (#21968 )

2026-06-22 18:38:00 +02:00

spreadsheet-import

Fix broken CSV import grid layout (#21867 )

2026-06-19 18:10:12 +02:00

…

perf(front): load Front chat during browser idle time (#21533 )

2026-06-13 17:53:09 +02:00

feat(auth): collect the workspace logo on the sign-up creation step (#21723 )

2026-06-18 17:56:14 +02:00

Fix settings page root overflow (#22207 )

2026-06-26 11:34:19 +02:00

feat(billing) - facilitate top up in ai chat (#21645 )

2026-06-17 16:20:11 +00:00

Feat: group records by many to one relation (#22123 )

2026-06-25 13:55:50 +02:00

[Workflows] Allow iterator to take whole item as variable (#22031 )

2026-06-26 09:26:11 +02:00

fix(domains): show custom domain DNS records and activation status without a page reload (#22037 )

2026-06-23 18:02:44 +02:00

workspace-invitation

…

workspace-member

fix: use correct userWorkspaceId for navigation menu comparisons (#21299 )

2026-06-08 09:17:07 +00:00