Files
twenty/packages/twenty-front/src/modules/views/hooks/internal/usePerformViewFieldGroupAPIPersist.ts
T
Charles Bochet ba9aa41bba refactor: metadata store cleanup, SSE unification, mock metadata loading & login redirect fix (#18651)
## Summary
- **SSE unification**: Replaced 11 individual SSE effect components with
a single generic `MetadataStoreSSEEffect`
- **Metadata store cleanup**: Merged `metadataCollectionHashesState`
into `metadataStoreState` (currentCollectionHash / draftCollectionHash
per entity), moved `objectMetadataItemsSelector` to `object-metadata`
domain, converted `navigationMenuItemsState` to a derived selector
- **Naming clarity**: Renamed `isAppMetadataReadyState` →
`isMinimalMetadataReadyState`, `MetadataGater` → `MinimalMetadataGater`,
`useIsLogged` → `useHasAccessTokenPair`,
`patchMetadataStoreFromSSEEvent` now takes named object params
- **Mock metadata loading**: Added `generate-navigation-menu-items.ts`
script, rewrote `useLoadMockedMinimalMetadata` to load full
objects/fields/indexes/views/navItems from generated mock data, enabling
proper sign-in background rendering (table columns, view picker,
navigation)
- **Login/logout transitions**: `MinimalMetadataLoadEffect` manages
mocked↔real metadata transitions based on auth state,
`MainContextStoreProvider` computes context on auth pages for view
picker support
- **Login redirect fix**: `handleLoadWorkspaceAfterAuthentication` now
re-enables `isAppEffectRedirectEnabled` after `loadCurrentUser()`
completes, fixing the blocked post-login navigation
- **Dead code removal**: Deleted `useRefreshPageLayouts`,
`useApplyPageLayouts`, `useStaleMetadataEntities`,
`metadataCollectionHashesState`, and all individual SSE effects

## Test plan
- [x] Login from welcome page redirects to companies page
- [x] Logout transitions cleanly to mocked metadata on welcome page
- [x] Sign-in background shows table columns, view picker, and
navigation items
- [x] SSE events still update metadata store entries correctly
- [x] Navigation menu items persist across page refreshes
- [ ] CI: lint, typecheck, tests pass
2026-03-16 00:38:11 +01:00

206 lines
6.1 KiB
TypeScript

import { useCallback } from 'react';
import { useMetadataErrorHandler } from '@/metadata-error-handler/hooks/useMetadataErrorHandler';
import { type MetadataRequestResult } from '@/object-metadata/types/MetadataRequestResult.type';
import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
import { CREATE_MANY_CORE_VIEW_FIELD_GROUPS } from '@/views/graphql/mutations/createManyCoreViewFieldGroups';
import { DELETE_CORE_VIEW_FIELD_GROUP } from '@/views/graphql/mutations/deleteCoreViewFieldGroup';
import { UPDATE_CORE_VIEW_FIELD_GROUP } from '@/views/graphql/mutations/updateCoreViewFieldGroup';
import { useMutation } from '@apollo/client/react';
import { CombinedGraphQLErrors } from '@apollo/client/errors';
import { t } from '@lingui/core/macro';
import { CrudOperationType } from 'twenty-shared/types';
import { isDefined } from 'twenty-shared/utils';
import {
type CoreViewFieldGroup,
type MutationCreateManyCoreViewFieldGroupsArgs,
type MutationDeleteCoreViewFieldGroupArgs,
type MutationUpdateCoreViewFieldGroupArgs,
} from '~/generated-metadata/graphql';
type CreateManyCoreViewFieldGroupsMutationResult = {
createManyCoreViewFieldGroups: CoreViewFieldGroup[];
};
type UpdateCoreViewFieldGroupMutationResult = {
updateCoreViewFieldGroup: CoreViewFieldGroup;
};
type DeleteCoreViewFieldGroupMutationResult = {
deleteCoreViewFieldGroup: CoreViewFieldGroup;
};
export const usePerformViewFieldGroupAPIPersist = () => {
const [createManyCoreViewFieldGroupsMutation] = useMutation<
CreateManyCoreViewFieldGroupsMutationResult,
MutationCreateManyCoreViewFieldGroupsArgs
>(CREATE_MANY_CORE_VIEW_FIELD_GROUPS);
const [updateCoreViewFieldGroupMutation] = useMutation<
UpdateCoreViewFieldGroupMutationResult,
MutationUpdateCoreViewFieldGroupArgs
>(UPDATE_CORE_VIEW_FIELD_GROUP);
const [deleteCoreViewFieldGroupMutation] = useMutation<
DeleteCoreViewFieldGroupMutationResult,
MutationDeleteCoreViewFieldGroupArgs
>(DELETE_CORE_VIEW_FIELD_GROUP);
const { handleMetadataError } = useMetadataErrorHandler();
const { enqueueErrorSnackBar } = useSnackBar();
const performViewFieldGroupAPICreate = useCallback(
async (
createCoreViewFieldGroupInputs: MutationCreateManyCoreViewFieldGroupsArgs,
): Promise<
MetadataRequestResult<CreateManyCoreViewFieldGroupsMutationResult | null>
> => {
if (
!Array.isArray(createCoreViewFieldGroupInputs.inputs) ||
createCoreViewFieldGroupInputs.inputs.length === 0
) {
return {
status: 'successful',
response: null,
};
}
try {
const result = await createManyCoreViewFieldGroupsMutation({
variables: createCoreViewFieldGroupInputs,
});
return {
status: 'successful',
response: result.data ?? null,
};
} catch (error) {
if (CombinedGraphQLErrors.is(error)) {
handleMetadataError(error, {
primaryMetadataName: 'viewFieldGroup',
operationType: CrudOperationType.CREATE,
});
} else {
enqueueErrorSnackBar({ message: t`An error occurred.` });
}
return {
status: 'failed',
error,
};
}
},
[
createManyCoreViewFieldGroupsMutation,
handleMetadataError,
enqueueErrorSnackBar,
],
);
const performViewFieldGroupAPIUpdate = useCallback(
async (
updateCoreViewFieldGroupInputs: MutationUpdateCoreViewFieldGroupArgs[],
): Promise<
MetadataRequestResult<UpdateCoreViewFieldGroupMutationResult[] | null>
> => {
if (updateCoreViewFieldGroupInputs.length === 0) {
return {
status: 'successful',
response: [],
};
}
try {
const results = await Promise.all(
updateCoreViewFieldGroupInputs.map((variables) =>
updateCoreViewFieldGroupMutation({
variables,
}),
),
);
return {
status: 'successful',
response: results
.map((r) => r.data)
.filter(isDefined) as UpdateCoreViewFieldGroupMutationResult[],
};
} catch (error) {
if (CombinedGraphQLErrors.is(error)) {
handleMetadataError(error, {
primaryMetadataName: 'viewFieldGroup',
operationType: CrudOperationType.UPDATE,
});
} else {
enqueueErrorSnackBar({ message: t`An error occurred.` });
}
return {
status: 'failed',
error,
};
}
},
[
updateCoreViewFieldGroupMutation,
handleMetadataError,
enqueueErrorSnackBar,
],
);
const performViewFieldGroupAPIDelete = useCallback(
async (
deleteCoreViewFieldGroupInputs: MutationDeleteCoreViewFieldGroupArgs[],
): Promise<
MetadataRequestResult<DeleteCoreViewFieldGroupMutationResult[] | null>
> => {
if (deleteCoreViewFieldGroupInputs.length === 0) {
return {
status: 'successful',
response: [],
};
}
try {
const results = await Promise.all(
deleteCoreViewFieldGroupInputs.map((variables) =>
deleteCoreViewFieldGroupMutation({
variables,
}),
),
);
return {
status: 'successful',
response: results
.map((r) => r.data)
.filter(isDefined) as DeleteCoreViewFieldGroupMutationResult[],
};
} catch (error) {
if (CombinedGraphQLErrors.is(error)) {
handleMetadataError(error, {
primaryMetadataName: 'viewFieldGroup',
operationType: CrudOperationType.DELETE,
});
} else {
enqueueErrorSnackBar({ message: t`An error occurred.` });
}
return {
status: 'failed',
error,
};
}
},
[
deleteCoreViewFieldGroupMutation,
handleMetadataError,
enqueueErrorSnackBar,
],
);
return {
performViewFieldGroupAPICreate,
performViewFieldGroupAPIUpdate,
performViewFieldGroupAPIDelete,
};
};