fefb6cdb94
## Context Closes #21522 Large values in the dashboard **Number** widget are always abbreviated (e.g. `1300090` → `1.3m`) with no way to display the full number. Following a discussion with the core team who were interested in this feature (https://discordapp.com/channels/1130383047699738754/1509604545381142649) , this adds a **Format** option in the **Style** section of the Number (aggregate chart) widget, letting users choose between **Short** (abbreviated, current behavior) and **Full** (complete number with thousand separators). Only the displayed value of the Number widget is affected — axes, labels and tooltips of other chart types are intentionally left untouched. ## What's inside **Server** - New `ChartNumberFormat` GraphQL enum (`SHORT` / `FULL`), following the `AxisNameDisplay` pattern - The existing — and previously unused — `format` field on `AggregateChartConfigurationDTO` is now typed with this enum and validated with `@IsEnum` - The dashboard AI tool schema (`widget.schema.ts`) accepts the new `format` option - Regenerated GraphQL types and the `twenty-client-sdk` metadata client to reflect the enum **Front** - New **Format** setting in the Style section of the Number widget settings, with a Short/Full selection dropdown (same pattern as the Axis name setting) - `transformAggregateRawValueIntoAggregateDisplayValue` takes an optional `numberFormat`: - `FULL` → full number via `formatNumber` (currency values keep up to 2 decimals) - `SHORT` → abbreviated via `formatToShortNumber` - not set → behavior unchanged (currency short, number full), so existing widgets and the record table/board footers render exactly as before ## Screenshots | Full UI Look | <img width="1917" height="955" alt="Twenty_Showcas_FullShort" src="https://github.com/user-attachments/assets/05d05779-395d-4e1a-8ff0-964f6fbef182" /> | Menu UI Look | <img width="291" height="308" alt="Screenshot_2" src="https://github.com/user-attachments/assets/82b5a1de-32fe-46ec-a9b8-add11ab4c6cd" /> ## Tests - Extended `transformAggregateRawValueIntoAggregateDisplayValue` unit tests with SHORT/FULL cases for currency and number fields - Updated the page-layout-widget creation/update integration tests and snapshots to use `ChartNumberFormat.SHORT` <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/21521?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> --------- Co-authored-by: Charles Bochet <charles@twenty.com>
95 lines
2.6 KiB
TypeScript
95 lines
2.6 KiB
TypeScript
import { builtinModules } from 'node:module';
|
|
|
|
import { lingui } from '@lingui/vite-plugin';
|
|
import react from '@vitejs/plugin-react-swc';
|
|
import * as path from 'path';
|
|
import { APP_LOCALES } from 'twenty-shared/translations';
|
|
import { defineConfig, type Plugin } from 'vite';
|
|
import tsconfigPaths from 'vite-tsconfig-paths';
|
|
|
|
// twenty-emails bundles its deps (the Node server that consumes it doesn't have
|
|
// @react-email et al.) but runs in Node. A plain client/lib build under Vite 8
|
|
// (rolldown) resolves node builtins to browser stubs that throw at runtime
|
|
// (e.g. object-inspect reading util.inspect.custom), crashing the server on
|
|
// import. Vite only externalizes builtins as real `require('node:*')` in an
|
|
// SSR/node build, so this is built with `build.ssr` + `ssr.target: 'node'`,
|
|
// while `ssr.noExternal: true` keeps the npm deps bundled in. React stays
|
|
// external as the host app provides it.
|
|
const EXTERNAL_DEPENDENCIES = ['react', 'react-dom', 'react/jsx-runtime'];
|
|
|
|
const nodeBuiltins = new Set([
|
|
...builtinModules,
|
|
...builtinModules.map((moduleName) => `node:${moduleName}`),
|
|
]);
|
|
|
|
const externalizeNodeBuiltins = (): Plugin => ({
|
|
name: 'externalize-node-builtins',
|
|
enforce: 'pre',
|
|
resolveId(source) {
|
|
const specifier = source.startsWith('node:') ? source : `node:${source}`;
|
|
|
|
if (nodeBuiltins.has(source) || nodeBuiltins.has(specifier)) {
|
|
return { id: specifier, external: true };
|
|
}
|
|
|
|
return null;
|
|
},
|
|
});
|
|
|
|
export default defineConfig({
|
|
root: __dirname,
|
|
cacheDir: '../../node_modules/.vite/packages/twenty-emails',
|
|
|
|
resolve: {
|
|
alias: {
|
|
'@/': path.resolve(__dirname, 'src') + '/',
|
|
'src/': path.resolve(__dirname, 'src') + '/',
|
|
},
|
|
},
|
|
|
|
ssr: {
|
|
target: 'node',
|
|
noExternal: true,
|
|
external: EXTERNAL_DEPENDENCIES,
|
|
},
|
|
|
|
plugins: [
|
|
externalizeNodeBuiltins(),
|
|
react({
|
|
plugins: [['@lingui/swc-plugin', {}]],
|
|
}),
|
|
lingui({
|
|
configPath: path.resolve(__dirname, './lingui.config.ts'),
|
|
}),
|
|
tsconfigPaths({
|
|
root: __dirname,
|
|
}),
|
|
],
|
|
|
|
build: {
|
|
outDir: './dist',
|
|
ssr: true,
|
|
reportCompressedSize: false,
|
|
commonjsOptions: {
|
|
transformMixedEsModules: true,
|
|
},
|
|
lib: {
|
|
entry: {
|
|
index: 'src/index.ts',
|
|
...Object.values(APP_LOCALES).reduce(
|
|
(acc, locale) => ({
|
|
...acc,
|
|
[`locales/generated/${locale}`]: `src/locales/generated/${locale}.ts`,
|
|
}),
|
|
{},
|
|
),
|
|
},
|
|
name: 'twenty-emails',
|
|
formats: ['es', 'cjs'],
|
|
},
|
|
rollupOptions: {
|
|
external: EXTERNAL_DEPENDENCIES,
|
|
},
|
|
},
|
|
});
|