Charles Bochet
ef499b6d47
## Summary - Re-enable one lint rule that was temporarily disabled during the ESLint-to-Oxlint migration: - **`twenty/sort-css-properties-alphabetically`** in twenty-front — 578 violations auto-fixed across 390 files - Document why **`typescript/consistent-type-imports`** cannot be auto-fixed in twenty-server: NestJS relies on `emitDecoratorMetadata` for DI, so converting constructor parameter imports to `import type` erases them at compile time and breaks dependency injection at runtime - Right-size CI runners, reducing 8-core usage from 18 jobs to 3: | Change | Jobs | Rationale | |--------|------|-----------| | **Keep 8-core** | `ci-merge-queue/e2e-test`, `ci-front/front-sb-build`, `ci-front/front-build` | Heavy builds needing max CPU + memory (10GB NODE_OPTIONS, full Storybook webpack bundling) | | **8-core → 4-core** | `ci-server` (build, lint-typecheck, validation, test, integration-test), `ci-front/front-sb-test`, `ci-zapier/server-setup`, `ci-sdk/sdk-e2e-test` | Already sharded into 10-12 parallel instances, I/O-bound (DB/Redis), or moderate single builds | | **8-core → 2-core** | `ci-emails/emails-test` | Trivially lightweight (build + curl health check) | | **Removed** | `ci-front/front-chromatic-deployment` | Dead code — permanently disabled with `if: false` | - Fix merge queue CI issues: - **Concurrency**: Use `merge_group.base_ref` instead of unique merge group ref so new queue entries cancel previous runs - **Required status checks**: Add `merge_group` trigger to all 6 required CI workflows (front, server, shared, website, docker-compose, sdk) with `changed-files-check` auto-skipped for merge_group events — status check jobs auto-pass without re-running full CI - **Build caching**: Add Nx build cache restore/save to E2E test job with fallback to `main` branch cache for faster frontend and server builds ## Test plan - [ ] CI passes on this PR (verifies lint rule auto-fix works) - [ ] Verify 4-core runner jobs complete within their 30-minute timeouts - [ ] Verify merge queue status checks auto-pass (ci-front-status-check, ci-server-status-check, etc.) - [ ] Verify merge queue E2E concurrency cancels previous runs when a new PR enters the queue
72 lines
2.5 KiB
TypeScript
72 lines
2.5 KiB
TypeScript
import { SummaryCard } from '@/object-record/record-show/components/SummaryCard';
|
|
import { PageLayoutContent } from '@/page-layout/components/PageLayoutContent';
|
|
import { PageLayoutContentProvider } from '@/page-layout/contexts/PageLayoutContentContext';
|
|
import { useCurrentPageLayout } from '@/page-layout/hooks/useCurrentPageLayout';
|
|
import { usePageLayoutTabWithVisibleWidgetsOrThrow } from '@/page-layout/hooks/usePageLayoutTabWithVisibleWidgetsOrThrow';
|
|
import { getTabLayoutMode } from '@/page-layout/utils/getTabLayoutMode';
|
|
import { useLayoutRenderingContext } from '@/ui/layout/contexts/LayoutRenderingContext';
|
|
import { useTargetRecord } from '@/ui/layout/contexts/useTargetRecord';
|
|
import { ScrollWrapper } from '@/ui/utilities/scroll/components/ScrollWrapper';
|
|
import { styled } from '@linaria/react';
|
|
import { PageLayoutType } from '~/generated-metadata/graphql';
|
|
import { themeCssVariables } from 'twenty-ui/theme-constants';
|
|
|
|
const StyledContainer = styled.div`
|
|
background: ${themeCssVariables.background.secondary};
|
|
border-bottom-left-radius: 8px;
|
|
border-right: 1px solid ${themeCssVariables.border.color.medium};
|
|
border-top-left-radius: 8px;
|
|
box-sizing: border-box;
|
|
display: grid;
|
|
grid-template-columns: minmax(0, 1fr);
|
|
grid-template-rows: auto 1fr;
|
|
height: 100%;
|
|
`;
|
|
|
|
type PageLayoutLeftPanelProps = {
|
|
pinnedLeftTabId: string;
|
|
};
|
|
|
|
export const PageLayoutLeftPanel = ({
|
|
pinnedLeftTabId,
|
|
}: PageLayoutLeftPanelProps) => {
|
|
const { currentPageLayout } = useCurrentPageLayout();
|
|
const targetRecordIdentifier = useTargetRecord();
|
|
const { isInSidePanel } = useLayoutRenderingContext();
|
|
const pinnedTab = usePageLayoutTabWithVisibleWidgetsOrThrow(pinnedLeftTabId);
|
|
|
|
if (currentPageLayout?.type !== PageLayoutType.RECORD_PAGE) {
|
|
return null;
|
|
}
|
|
|
|
const layoutMode = getTabLayoutMode({
|
|
tab: pinnedTab,
|
|
pageLayoutType: currentPageLayout.type,
|
|
});
|
|
|
|
return (
|
|
<StyledContainer>
|
|
<SummaryCard
|
|
objectNameSingular={targetRecordIdentifier.targetObjectNameSingular}
|
|
objectRecordId={targetRecordIdentifier.id}
|
|
isInSidePanel={isInSidePanel}
|
|
/>
|
|
|
|
<PageLayoutContentProvider
|
|
value={{
|
|
tabId: pinnedLeftTabId,
|
|
layoutMode,
|
|
}}
|
|
>
|
|
<ScrollWrapper
|
|
componentInstanceId={`page-layout-left-panel-${pinnedLeftTabId}`}
|
|
defaultEnableXScroll={false}
|
|
defaultEnableYScroll={true}
|
|
>
|
|
<PageLayoutContent />
|
|
</ScrollWrapper>
|
|
</PageLayoutContentProvider>
|
|
</StyledContainer>
|
|
);
|
|
};
|