9d57bc39e5
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
259 lines
6.6 KiB
TypeScript
259 lines
6.6 KiB
TypeScript
import { isDate, isNumber, isString } from '@sniptt/guards';
|
|
import {
|
|
differenceInCalendarDays,
|
|
differenceInDays,
|
|
differenceInYears,
|
|
format,
|
|
formatDistance,
|
|
formatDistanceToNow,
|
|
isToday,
|
|
isValid,
|
|
parseISO,
|
|
type Locale,
|
|
} from 'date-fns';
|
|
|
|
import { DateFormat } from '@/localization/constants/DateFormat';
|
|
import { TimeFormat } from '@/localization/constants/TimeFormat';
|
|
import { CustomError, isDefined } from 'twenty-shared/utils';
|
|
|
|
import { i18n } from '@lingui/core';
|
|
import { plural, t } from '@lingui/core/macro';
|
|
import { logError } from './logError';
|
|
|
|
// TODO: review all of this with Temporal
|
|
// - also break down this into small files
|
|
export const parseDate = (dateToParse: Date | string | number): Date => {
|
|
if (dateToParse === 'now') return new Date();
|
|
|
|
let formattedDate: Date | null = null;
|
|
|
|
if (dateToParse === '' || dateToParse === 0) {
|
|
throw new CustomError(
|
|
`Invalid date passed to formatPastDate: "${dateToParse}"`,
|
|
'INVALID_DATE_FORMAT',
|
|
);
|
|
} else if (isString(dateToParse)) {
|
|
formattedDate = parseISO(dateToParse);
|
|
} else if (isDate(dateToParse)) {
|
|
formattedDate = dateToParse;
|
|
} else if (isNumber(dateToParse)) {
|
|
formattedDate = new Date(dateToParse);
|
|
}
|
|
|
|
if (!formattedDate) {
|
|
throw new CustomError(
|
|
`Invalid date passed to formatPastDate: "${dateToParse}"`,
|
|
'INVALID_DATE_FORMAT',
|
|
);
|
|
}
|
|
|
|
if (!isValid(formattedDate)) {
|
|
throw new CustomError(
|
|
`Invalid date passed to formatPastDate: "${dateToParse}"`,
|
|
'INVALID_DATE_FORMAT',
|
|
);
|
|
}
|
|
|
|
return formattedDate;
|
|
};
|
|
|
|
export const formatDate = (
|
|
dateToFormat: Date | string | number,
|
|
formatString: string,
|
|
) => {
|
|
try {
|
|
const parsedDate = parseDate(dateToFormat);
|
|
return format(parsedDate, formatString);
|
|
} catch (error) {
|
|
logError(error);
|
|
return '';
|
|
}
|
|
};
|
|
|
|
export const beautifyExactDateTime = (
|
|
dateToBeautify: Date | string | number,
|
|
) => {
|
|
const parsedDate = parseDate(dateToBeautify);
|
|
const isTodayDate = isToday(parsedDate);
|
|
const dateFormat = isTodayDate ? 'HH:mm' : 'MMM d, yyyy · HH:mm';
|
|
return formatDate(dateToBeautify, dateFormat);
|
|
};
|
|
|
|
export const beautifyExactDate = (dateToBeautify: Date | string | number) => {
|
|
const parsedDate = parseDate(dateToBeautify);
|
|
const isTodayDate = isToday(parsedDate);
|
|
if (isTodayDate) {
|
|
return t`Today`;
|
|
}
|
|
return formatDate(dateToBeautify, 'MMM d, yyyy');
|
|
};
|
|
|
|
export const beautifyPastDateRelativeToNow = (
|
|
pastDate: Date | string | number,
|
|
locale?: Locale,
|
|
) => {
|
|
try {
|
|
const parsedDate = parseDate(pastDate);
|
|
const now = new Date();
|
|
const diffInSeconds = Math.abs(
|
|
(now.getTime() - parsedDate.getTime()) / 1000,
|
|
);
|
|
|
|
// For very recent times (less than 30 seconds), show "now"
|
|
if (diffInSeconds < 30) {
|
|
return t`now`;
|
|
}
|
|
|
|
return formatDistanceToNow(parsedDate, {
|
|
addSuffix: true,
|
|
locale,
|
|
includeSeconds: true,
|
|
});
|
|
} catch (error) {
|
|
logError(error);
|
|
return '';
|
|
}
|
|
};
|
|
|
|
export const beautifyPastDateRelativeToNowShort = (
|
|
pastDate: Date | string | number,
|
|
) => {
|
|
try {
|
|
const parsedDate = parseDate(pastDate);
|
|
const now = new Date();
|
|
const diffInSeconds = Math.abs(
|
|
(now.getTime() - parsedDate.getTime()) / 1000,
|
|
);
|
|
|
|
if (diffInSeconds < 60) return t`now`;
|
|
|
|
const diffInMinutes = Math.floor(diffInSeconds / 60);
|
|
if (diffInMinutes < 60) return `${diffInMinutes}m`;
|
|
|
|
const diffInHours = Math.floor(diffInMinutes / 60);
|
|
if (diffInHours < 24) return `${diffInHours}h`;
|
|
|
|
const diffInDays = Math.floor(diffInHours / 24);
|
|
if (diffInDays < 7) return `${diffInDays}d`;
|
|
|
|
const diffInWeeks = Math.floor(diffInDays / 7);
|
|
if (diffInWeeks < 5) return `${diffInWeeks}w`;
|
|
|
|
const diffInMonths = Math.floor(diffInDays / 30);
|
|
if (diffInMonths < 12) return `${diffInMonths}mo`;
|
|
|
|
const diffInYears = Math.floor(diffInDays / 365);
|
|
|
|
return `${diffInYears}y`;
|
|
} catch (error) {
|
|
logError(error);
|
|
|
|
return '';
|
|
}
|
|
};
|
|
|
|
export const hasDatePassed = (date: Date | string | number) => {
|
|
try {
|
|
const parsedDate = parseDate(date);
|
|
|
|
return differenceInCalendarDays(new Date(), parsedDate) >= 1;
|
|
} catch (error) {
|
|
logError(error);
|
|
return false;
|
|
}
|
|
};
|
|
|
|
export const beautifyDateDiff = (
|
|
date: string,
|
|
dateToCompareWith?: string,
|
|
short = false,
|
|
locale?: Locale,
|
|
) => {
|
|
// For simple cases, use date-fns which has excellent locale support
|
|
if (!short && isDefined(locale)) {
|
|
const fromDate = new Date(date);
|
|
const toDate = dateToCompareWith ? new Date(dateToCompareWith) : new Date();
|
|
return formatDistance(fromDate, toDate, { locale });
|
|
}
|
|
|
|
// Manual implementation for complex cases or when locale is not available
|
|
const fromDate = parseISO(date);
|
|
const toDate = dateToCompareWith ? parseISO(dateToCompareWith) : new Date();
|
|
|
|
const years = differenceInYears(fromDate, toDate);
|
|
// Calculate remaining days after accounting for full years
|
|
const startDateForDayCalculation = new Date(toDate);
|
|
startDateForDayCalculation.setFullYear(
|
|
startDateForDayCalculation.getFullYear() + years,
|
|
);
|
|
const days = differenceInDays(fromDate, startDateForDayCalculation);
|
|
|
|
let result = '';
|
|
|
|
if (years !== 0) {
|
|
result = plural(Math.abs(years), {
|
|
one: `${years} year`,
|
|
other: `${years} years`,
|
|
});
|
|
|
|
if (short) return result;
|
|
}
|
|
|
|
if (years !== 0 && days !== 0) {
|
|
result += ` ${t`and`} `;
|
|
}
|
|
|
|
if (days !== 0) {
|
|
const daysPart = plural(Math.abs(days), {
|
|
one: `${days} day`,
|
|
other: `${days} days`,
|
|
});
|
|
result += daysPart;
|
|
}
|
|
|
|
return result;
|
|
};
|
|
|
|
export const formatToHumanReadableDate = (date: Date | string) => {
|
|
const parsedJSDate = parseDate(date);
|
|
|
|
return i18n.date(parsedJSDate, { dateStyle: 'medium' });
|
|
};
|
|
|
|
const getTimePattern = (timeFormat: TimeFormat) => {
|
|
return timeFormat === TimeFormat.HOUR_12 ? 'hh:mm a' : 'HH:mm';
|
|
};
|
|
|
|
export const getDateTimeFormatStringFoDatePickerInputMask = ({
|
|
dateFormat,
|
|
timeFormat,
|
|
}: {
|
|
dateFormat: DateFormat;
|
|
timeFormat: TimeFormat;
|
|
}): string => {
|
|
const timePattern = getTimePattern(timeFormat);
|
|
switch (dateFormat) {
|
|
case DateFormat.DAY_FIRST:
|
|
return `dd/MM/yyyy ${timePattern}`;
|
|
case DateFormat.YEAR_FIRST:
|
|
return `yyyy-MM-dd ${timePattern}`;
|
|
case DateFormat.MONTH_FIRST:
|
|
default:
|
|
return `MM/dd/yyyy ${timePattern}`;
|
|
}
|
|
};
|
|
|
|
export const getDateFormatStringForDatePickerInputMask = (
|
|
dateFormat: DateFormat,
|
|
): string => {
|
|
switch (dateFormat) {
|
|
case DateFormat.DAY_FIRST:
|
|
return `dd/MM/yyyy`;
|
|
case DateFormat.YEAR_FIRST:
|
|
return `yyyy-MM-dd`;
|
|
case DateFormat.MONTH_FIRST:
|
|
default:
|
|
return `MM/dd/yyyy`;
|
|
}
|
|
};
|