Raphaël Bosi
abdab2fb7e
## Description - Introduces a new engine command execution model that replaces the previous approach of mapping `EngineComponentKey` to React components. Instead, engine commands are now mounted headlessly via `HeadlessEngineCommandMountRoot`, with their execution context populated synchronously before mounting. - Creates new headless command components - Moves error handling from the SDK layer to the host app by wrapping all mounted commands with a new `CommandMenuItemErrorBoundary` The new flow works as follows: - When a command menu item with an `engineComponentKey` is clicked, `useCommandMenuItemFrontComponentCommands` calls `useMountEngineCommand`, which synchronously reads the current context store (object metadata, selected records, filters, view ID, etc.) and writes a `MountedEngineCommandContext` into `mountedEngineCommandsState`. - The command is then mounted into `mountedEngineCommandsState`, which triggers `HeadlessEngineCommandMountRoot` to render the corresponding headless component from `ENGINE_COMPONENT_KEY_HEADLESS_COMPONENT_MAP`, wrapped in `CommandMenuItemErrorBoundary`, `ContextStoreComponentInstanceContext.Provider`, and `EngineCommandComponentInstanceContext.Provider`. - Each command component reads its execution context and delegates to one of the 4 execution patterns: `HeadlessEngineCommandWrapperEffect` (simple actions), `HeadlessConfirmationModalEngineCommandEffect` (destructive actions needing confirmation), `HeadlessNavigateEngineCommand` (GO_TO_* commands), or `HeadlessOpenSidePanelPageEngineCommand` (SEARCH_RECORDS, ASK_AI, VIEW_PREVIOUS_AI_CHATS). - After execution, the command self-unmounts via `useUnmountEngineCommand`, which removes the entry from `mountedEngineCommandsState` and stops rendering the component.
41 lines
1.1 KiB
TypeScript
41 lines
1.1 KiB
TypeScript
import {
|
|
CommandMenuContext,
|
|
type CommandMenuContextType,
|
|
} from '@/command-menu-item/contexts/CommandMenuContext';
|
|
import { useCommandMenuItemsFromBackend } from '@/command-menu-item/server-items/hooks/useCommandMenuItemsFromBackend';
|
|
import { type CommandMenuContextApi } from 'twenty-shared/types';
|
|
|
|
type CommandMenuContextProviderServerItemsContentProps = {
|
|
isInSidePanel: CommandMenuContextType['isInSidePanel'];
|
|
displayType: CommandMenuContextType['displayType'];
|
|
containerType: CommandMenuContextType['containerType'];
|
|
children: React.ReactNode;
|
|
};
|
|
|
|
export const CommandMenuContextProviderServerItemsContent = ({
|
|
isInSidePanel,
|
|
displayType,
|
|
containerType,
|
|
children,
|
|
commandMenuContextApi,
|
|
}: CommandMenuContextProviderServerItemsContentProps & {
|
|
commandMenuContextApi: CommandMenuContextApi;
|
|
}) => {
|
|
const commandMenuItems = useCommandMenuItemsFromBackend(
|
|
commandMenuContextApi,
|
|
);
|
|
|
|
return (
|
|
<CommandMenuContext.Provider
|
|
value={{
|
|
isInSidePanel,
|
|
displayType,
|
|
containerType,
|
|
commandMenuItems,
|
|
}}
|
|
>
|
|
{children}
|
|
</CommandMenuContext.Provider>
|
|
);
|
|
};
|