Charles Bochet
c53a13417e
## Summary
Eliminates all ~350 `styled(Component)` usages across `twenty-front` and
`twenty-ui` (212 files changed). Each was replaced following these
rules:
- **Margin/layout CSS** (margin, padding, flex, align-self, width) →
wrapped in a `styled.div`/`styled.span` parent container
- **Third-party components** (Link, TextareaAutosize,
ReactPhoneNumberInput, Handle, etc.) → parent container with child CSS
selectors (`> a`, `> textarea`, `> input`, etc.)
- **Intrinsic behavior via existing props** (TableRow
`gridTemplateColumns`, TableCell `color`/`align`) → replaced
`styled(TableRow)` / `styled(TableCell)` with direct prop usage
- **Other visual overrides on twenty-ui components** (Card, Section,
TabList, Button, MenuItem, ScrollWrapper, etc.) → parent wrappers with
`> div` / `> *` child selectors
- **Extending styled.div/span** → merged all CSS into a single
`styled.div`/`styled.span`
Also adds `overflow: hidden` to parent containers wrapping
`ScrollWrapper` so scroll activates correctly with the new wrapper
structure.
### Migration patterns
| Before | After |
|--------|-------|
| `styled(Avatar)` with `margin-right` | `<StyledAvatarContainer><Avatar
/></StyledAvatarContainer>` |
| `styled(Link)` with `text-decoration: none` |
`<StyledLinkContainer><Link /></StyledLinkContainer>` with `> a { ... }`
|
| `styled(TableRow)` with `grid-template-columns` | `<TableRow
gridTemplateColumns="..." />` |
| `styled(TableCell)` with `color` / `align` | `<TableCell color={...}
align="right" />` |
| `styled(Card)` with `margin-top` | `<StyledCardContainer><Card
/></StyledCardContainer>` |
| `styled(TabList)` with `background` |
`<StyledTabListContainer><TabList /></StyledTabListContainer>` with `>
div { ... }` |
| `styled(StyledBase)` extending a `styled.div` | Single merged
`styled.div` with all styles inlined |
48 lines
1.2 KiB
TypeScript
48 lines
1.2 KiB
TypeScript
import { styled } from '@linaria/react';
|
|
import { type IconComponent } from '@ui/display';
|
|
import { JsonNodeLabel } from '@ui/json-visualizer/components/internal/JsonNodeLabel';
|
|
import { JsonNodeValue } from '@ui/json-visualizer/components/internal/JsonNodeValue';
|
|
import { type JsonNodeHighlighting } from '@ui/json-visualizer/types/JsonNodeHighlighting';
|
|
import { themeCssVariables } from '@ui/theme-constants';
|
|
|
|
const StyledListItem = styled.li`
|
|
align-items: center;
|
|
column-gap: ${themeCssVariables.spacing[2]};
|
|
display: flex;
|
|
list-style-type: none;
|
|
white-space: nowrap;
|
|
`;
|
|
|
|
type JsonValueNodeProps = {
|
|
valueAsString: string;
|
|
highlighting: JsonNodeHighlighting | undefined;
|
|
} & (
|
|
| {
|
|
label: string;
|
|
Icon: IconComponent;
|
|
}
|
|
| {
|
|
label?: never;
|
|
Icon?: unknown;
|
|
}
|
|
);
|
|
|
|
export const JsonValueNode = (props: JsonValueNodeProps) => {
|
|
return (
|
|
<StyledListItem>
|
|
{props.label && (
|
|
<JsonNodeLabel
|
|
label={props.label}
|
|
Icon={props.Icon}
|
|
highlighting={props.highlighting}
|
|
/>
|
|
)}
|
|
|
|
<JsonNodeValue
|
|
valueAsString={props.valueAsString}
|
|
highlighting={props.highlighting}
|
|
/>
|
|
</StyledListItem>
|
|
);
|
|
};
|