Charles Bochet
3d49c21b51
## Summary - Reverts the `useSortedNavigationMenuItems` coupling in `ViewPickerOptionDropdown` introduced by #18791 - The viewPicker now uses `useNavigationMenuItemsData` directly for the `isFavorite` check, keeping view ordering and navigation menu item ordering independent ## Why PR #18791 replaced `useNavigationMenuItemsData` with `useSortedNavigationMenuItems` in the viewPicker for favorite detection. While the intent was to filter out stale/orphaned navigation items, this created an unnecessary coupling: `useSortedNavigationMenuItems` subscribes to `viewsSelector` and `objectMetadataItemsSelector`, making the viewPicker transitively dependent on the navigation menu item ordering system. View ordering in the picker (driven by `view.position`) and navigation menu item ordering (driven by `navigationMenuItem.position`) should remain decorrelated. ## Test plan - [ ] Open the viewPicker dropdown and verify views are listed in correct order - [ ] Drag-and-drop to reorder views in the viewPicker — confirm it works - [ ] Verify the "Add to Favorite" / "Manage favorite" label still correctly reflects favorite state - [ ] Reorder navigation menu items in the sidebar — confirm viewPicker order is unaffected Made with [Cursor](https://cursor.com)
Run yarn dev while server running on port 3000