9d57bc39e5
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
85 lines
3.5 KiB
TypeScript
85 lines
3.5 KiB
TypeScript
import { type MessageDescriptor } from '@lingui/core';
|
|
import { msg } from '@lingui/core/macro';
|
|
import { assertUnreachable } from 'twenty-shared/utils';
|
|
|
|
import { STANDARD_ERROR_MESSAGE } from 'src/engine/api/common/common-query-runners/errors/standard-error-message.constant';
|
|
import {
|
|
appendCommonExceptionCode,
|
|
CustomException,
|
|
} from 'src/utils/custom-exception';
|
|
|
|
export const FieldMetadataExceptionCode = appendCommonExceptionCode({
|
|
FIELD_METADATA_NOT_FOUND: 'FIELD_METADATA_NOT_FOUND',
|
|
INVALID_FIELD_INPUT: 'INVALID_FIELD_INPUT',
|
|
FIELD_MUTATION_NOT_ALLOWED: 'FIELD_MUTATION_NOT_ALLOWED',
|
|
FIELD_ALREADY_EXISTS: 'FIELD_ALREADY_EXISTS',
|
|
OBJECT_METADATA_NOT_FOUND: 'OBJECT_METADATA_NOT_FOUND',
|
|
APPLICATION_NOT_FOUND: 'APPLICATION_NOT_FOUND',
|
|
FIELD_METADATA_RELATION_NOT_ENABLED: 'FIELD_METADATA_RELATION_NOT_ENABLED',
|
|
FIELD_METADATA_RELATION_MALFORMED: 'FIELD_METADATA_RELATION_MALFORMED',
|
|
LABEL_IDENTIFIER_FIELD_METADATA_ID_NOT_FOUND:
|
|
'LABEL_IDENTIFIER_FIELD_METADATA_ID_NOT_FOUND',
|
|
UNCOVERED_FIELD_METADATA_TYPE_VALIDATION:
|
|
'UNCOVERED_FIELD_METADATA_TYPE_VALIDATION',
|
|
RESERVED_KEYWORD: 'RESERVED_KEYWORD',
|
|
NOT_AVAILABLE: 'NOT_AVAILABLE',
|
|
NAME_NOT_SYNCED_WITH_LABEL: 'NAME_NOT_SYNCED_WITH_LABEL',
|
|
} as const);
|
|
|
|
// oxlint-disable-next-line no-redeclare
|
|
export type FieldMetadataExceptionCode =
|
|
(typeof FieldMetadataExceptionCode)[keyof typeof FieldMetadataExceptionCode];
|
|
|
|
const getFieldMetadataExceptionUserFriendlyMessage = (
|
|
code: keyof typeof FieldMetadataExceptionCode,
|
|
) => {
|
|
switch (code) {
|
|
case FieldMetadataExceptionCode.FIELD_METADATA_NOT_FOUND:
|
|
return msg`Field not found.`;
|
|
case FieldMetadataExceptionCode.INVALID_FIELD_INPUT:
|
|
return msg`Invalid field input.`;
|
|
case FieldMetadataExceptionCode.FIELD_MUTATION_NOT_ALLOWED:
|
|
return msg`This field cannot be modified.`;
|
|
case FieldMetadataExceptionCode.FIELD_ALREADY_EXISTS:
|
|
return msg`A field with this name already exists.`;
|
|
case FieldMetadataExceptionCode.OBJECT_METADATA_NOT_FOUND:
|
|
return msg`Object not found.`;
|
|
case FieldMetadataExceptionCode.APPLICATION_NOT_FOUND:
|
|
return msg`Application not found.`;
|
|
case FieldMetadataExceptionCode.FIELD_METADATA_RELATION_NOT_ENABLED:
|
|
return msg`Relation is not enabled for this field.`;
|
|
case FieldMetadataExceptionCode.FIELD_METADATA_RELATION_MALFORMED:
|
|
return msg`Relation configuration is invalid.`;
|
|
case FieldMetadataExceptionCode.LABEL_IDENTIFIER_FIELD_METADATA_ID_NOT_FOUND:
|
|
return msg`Label identifier field not found.`;
|
|
case FieldMetadataExceptionCode.UNCOVERED_FIELD_METADATA_TYPE_VALIDATION:
|
|
return msg`Field type validation error.`;
|
|
case FieldMetadataExceptionCode.RESERVED_KEYWORD:
|
|
return msg`This name is a reserved keyword.`;
|
|
case FieldMetadataExceptionCode.NOT_AVAILABLE:
|
|
return msg`This field name is not available.`;
|
|
case FieldMetadataExceptionCode.NAME_NOT_SYNCED_WITH_LABEL:
|
|
return msg`Field name is not synced with label.`;
|
|
case FieldMetadataExceptionCode.INTERNAL_SERVER_ERROR:
|
|
return STANDARD_ERROR_MESSAGE;
|
|
default:
|
|
assertUnreachable(code);
|
|
}
|
|
};
|
|
|
|
export class FieldMetadataException extends CustomException<
|
|
keyof typeof FieldMetadataExceptionCode
|
|
> {
|
|
constructor(
|
|
message: string,
|
|
code: keyof typeof FieldMetadataExceptionCode,
|
|
{ userFriendlyMessage }: { userFriendlyMessage?: MessageDescriptor } = {},
|
|
) {
|
|
super(message, code, {
|
|
userFriendlyMessage:
|
|
userFriendlyMessage ??
|
|
getFieldMetadataExceptionUserFriendlyMessage(code),
|
|
});
|
|
}
|
|
}
|