Charles Bochet
9e21e55db4
## Fix resolver schema leaking between `/metadata` and `/graphql` endpoints ### Summary - Patch `@nestjs/graphql` to support a `resolverSchemaScope` option that filters resolvers at both schema generation and runtime, preventing cross-endpoint leaking - Introduce `@CoreResolver()` and `@MetadataResolver()` decorators to explicitly scope each resolver to its endpoint - Move most resolvers (auth, billing, workspace, user, etc.) to the metadata schema where the frontend expects them; only workflow and timeline calendar/messaging resolvers remain on `/graphql` - Fix frontend `SSEQuerySubscribeEffect` to use the default (metadata) Apollo client instead of the core client ### Problem NestJS GraphQL's module-based resolver discovery traverses transitive imports, causing resolvers from `/metadata` modules to leak into the `/graphql` schema and vice versa. This made the schemas unpredictable and tightly coupled to module import order. ### Approach - Added `resolverSchemaScope` to `GqlModuleOptions` via a patch on `@nestjs/graphql`, filtering in both `filterResolvers()` (runtime binding) and `getAllCtors()` (schema generation) - Each resolver is explicitly decorated with `@CoreResolver()` or `@MetadataResolver()` - Organized decorator, constant, and type files under `graphql-config/` following project conventions Core GQL Schema: (see: no more fields!) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/668f3f0f-485e-43f0-92be-4345aeccacb6" /> Metadata GQL Schema (see no more getTimelineCalendarEventsFromCompany) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/443913db-e5fe-4161-b0e7-4a971cc80a71" />
51 lines
2.4 KiB
TypeScript
51 lines
2.4 KiB
TypeScript
import { UseFilters, UseGuards, UsePipes } from '@nestjs/common';
|
|
import { Args, Query } from '@nestjs/graphql';
|
|
|
|
import { AuthContext } from 'src/engine/core-modules/auth/types/auth-context.type';
|
|
import { MetadataResolver } from 'src/engine/api/graphql/graphql-config/decorators/metadata-resolver.decorator';
|
|
import { ResolverValidationPipe } from 'src/engine/core-modules/graphql/pipes/resolver-validation.pipe';
|
|
import { UserEntity } from 'src/engine/core-modules/user/user.entity';
|
|
import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
|
|
import { AuthUserWorkspaceId } from 'src/engine/decorators/auth/auth-user-workspace-id.decorator';
|
|
import { AuthUser } from 'src/engine/decorators/auth/auth-user.decorator';
|
|
import { AuthWorkspaceMemberId } from 'src/engine/decorators/auth/auth-workspace-member-id.decorator';
|
|
import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
|
|
import { NoPermissionGuard } from 'src/engine/guards/no-permission.guard';
|
|
import { WorkspaceAuthGuard } from 'src/engine/guards/workspace-auth.guard';
|
|
import { BarChartDataInput } from 'src/modules/dashboard/chart-data/dtos/inputs/bar-chart-data.input';
|
|
import { BarChartDataOutputDTO } from 'src/modules/dashboard/chart-data/dtos/outputs/bar-chart-data-output.dto';
|
|
import { ChartDataGraphqlApiExceptionFilter } from 'src/modules/dashboard/chart-data/filters/chart-data-graphql-api-exception.filter';
|
|
import { BarChartDataService } from 'src/modules/dashboard/chart-data/services/bar-chart-data.service';
|
|
|
|
@MetadataResolver()
|
|
@UseFilters(ChartDataGraphqlApiExceptionFilter)
|
|
@UseGuards(WorkspaceAuthGuard)
|
|
@UsePipes(ResolverValidationPipe)
|
|
export class BarChartDataResolver {
|
|
constructor(private readonly barChartDataService: BarChartDataService) {}
|
|
|
|
@Query(() => BarChartDataOutputDTO)
|
|
@UseGuards(NoPermissionGuard)
|
|
async barChartData(
|
|
@Args('input') input: BarChartDataInput,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
@AuthUser() user: UserEntity,
|
|
@AuthWorkspaceMemberId() workspaceMemberId: string,
|
|
@AuthUserWorkspaceId() userWorkspaceId: string,
|
|
): Promise<BarChartDataOutputDTO> {
|
|
const authContext: AuthContext = {
|
|
user,
|
|
workspace,
|
|
workspaceMemberId,
|
|
userWorkspaceId,
|
|
};
|
|
|
|
return this.barChartDataService.getBarChartData({
|
|
objectMetadataId: input.objectMetadataId,
|
|
configuration: input.configuration,
|
|
workspaceId: workspace.id,
|
|
authContext,
|
|
});
|
|
}
|
|
}
|