9e21e55db4
## Fix resolver schema leaking between `/metadata` and `/graphql` endpoints ### Summary - Patch `@nestjs/graphql` to support a `resolverSchemaScope` option that filters resolvers at both schema generation and runtime, preventing cross-endpoint leaking - Introduce `@CoreResolver()` and `@MetadataResolver()` decorators to explicitly scope each resolver to its endpoint - Move most resolvers (auth, billing, workspace, user, etc.) to the metadata schema where the frontend expects them; only workflow and timeline calendar/messaging resolvers remain on `/graphql` - Fix frontend `SSEQuerySubscribeEffect` to use the default (metadata) Apollo client instead of the core client ### Problem NestJS GraphQL's module-based resolver discovery traverses transitive imports, causing resolvers from `/metadata` modules to leak into the `/graphql` schema and vice versa. This made the schemas unpredictable and tightly coupled to module import order. ### Approach - Added `resolverSchemaScope` to `GqlModuleOptions` via a patch on `@nestjs/graphql`, filtering in both `filterResolvers()` (runtime binding) and `getAllCtors()` (schema generation) - Each resolver is explicitly decorated with `@CoreResolver()` or `@MetadataResolver()` - Organized decorator, constant, and type files under `graphql-config/` following project conventions Core GQL Schema: (see: no more fields!) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/668f3f0f-485e-43f0-92be-4345aeccacb6" /> Metadata GQL Schema (see no more getTimelineCalendarEventsFromCompany) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/443913db-e5fe-4161-b0e7-4a971cc80a71" />
263 lines
9.5 KiB
TypeScript
263 lines
9.5 KiB
TypeScript
import { UseFilters, UseGuards } from '@nestjs/common';
|
|
import {
|
|
Args,
|
|
Context,
|
|
Mutation,
|
|
Parent,
|
|
Query,
|
|
ResolveField,
|
|
} from '@nestjs/graphql';
|
|
|
|
import { isArray } from '@sniptt/guards';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
import { I18nService } from 'src/engine/core-modules/i18n/i18n.service';
|
|
import { type I18nContext } from 'src/engine/core-modules/i18n/types/i18n-context.type';
|
|
import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
|
|
import { type IDataloaders } from 'src/engine/dataloaders/dataloader.interface';
|
|
import { AuthUserWorkspaceId } from 'src/engine/decorators/auth/auth-user-workspace-id.decorator';
|
|
import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
|
|
import { MetadataResolver } from 'src/engine/api/graphql/graphql-config/decorators/metadata-resolver.decorator';
|
|
import { CustomPermissionGuard } from 'src/engine/guards/custom-permission.guard';
|
|
import { NoPermissionGuard } from 'src/engine/guards/no-permission.guard';
|
|
import { WorkspaceAuthGuard } from 'src/engine/guards/workspace-auth.guard';
|
|
import { resolveObjectMetadataStandardOverride } from 'src/engine/metadata-modules/object-metadata/utils/resolve-object-metadata-standard-override.util';
|
|
import { ViewFieldDTO } from 'src/engine/metadata-modules/view-field/dtos/view-field.dto';
|
|
import { ViewFieldV2Service } from 'src/engine/metadata-modules/view-field/services/view-field-v2.service';
|
|
import { ViewFilterGroupDTO } from 'src/engine/metadata-modules/view-filter-group/dtos/view-filter-group.dto';
|
|
import { ViewFilterGroupService } from 'src/engine/metadata-modules/view-filter-group/services/view-filter-group.service';
|
|
import { ViewFilterDTO } from 'src/engine/metadata-modules/view-filter/dtos/view-filter.dto';
|
|
import { ViewFilterService } from 'src/engine/metadata-modules/view-filter/services/view-filter.service';
|
|
import { ViewGroupDTO } from 'src/engine/metadata-modules/view-group/dtos/view-group.dto';
|
|
import { ViewGroupService } from 'src/engine/metadata-modules/view-group/services/view-group.service';
|
|
import { CreateViewPermissionGuard } from 'src/engine/metadata-modules/view-permissions/guards/create-view-permission.guard';
|
|
import { DeleteViewPermissionGuard } from 'src/engine/metadata-modules/view-permissions/guards/delete-view-permission.guard';
|
|
import { DestroyViewPermissionGuard } from 'src/engine/metadata-modules/view-permissions/guards/destroy-view-permission.guard';
|
|
import { UpdateViewPermissionGuard } from 'src/engine/metadata-modules/view-permissions/guards/update-view-permission.guard';
|
|
import { ViewSortDTO } from 'src/engine/metadata-modules/view-sort/dtos/view-sort.dto';
|
|
import { ViewSortService } from 'src/engine/metadata-modules/view-sort/services/view-sort.service';
|
|
import { CreateViewInput } from 'src/engine/metadata-modules/view/dtos/inputs/create-view.input';
|
|
import { UpdateViewInput } from 'src/engine/metadata-modules/view/dtos/inputs/update-view.input';
|
|
import { ViewDTO } from 'src/engine/metadata-modules/view/dtos/view.dto';
|
|
import { ViewEntity } from 'src/engine/metadata-modules/view/entities/view.entity';
|
|
import { ViewVisibility } from 'src/engine/metadata-modules/view/enums/view-visibility.enum';
|
|
import { ViewService } from 'src/engine/metadata-modules/view/services/view.service';
|
|
import { ViewGraphqlApiExceptionFilter } from 'src/engine/metadata-modules/view/utils/view-graphql-api-exception.filter';
|
|
|
|
@MetadataResolver(() => ViewDTO)
|
|
@UseFilters(ViewGraphqlApiExceptionFilter)
|
|
@UseGuards(WorkspaceAuthGuard)
|
|
export class ViewResolver {
|
|
constructor(
|
|
private readonly viewService: ViewService,
|
|
private readonly viewFilterService: ViewFilterService,
|
|
private readonly viewFilterGroupService: ViewFilterGroupService,
|
|
private readonly viewSortService: ViewSortService,
|
|
private readonly viewGroupService: ViewGroupService,
|
|
private readonly i18nService: I18nService,
|
|
|
|
private readonly viewFieldV2Service: ViewFieldV2Service,
|
|
) {}
|
|
|
|
@ResolveField(() => String)
|
|
async name(
|
|
@Parent() view: ViewDTO,
|
|
@Context() context: { loaders: IDataloaders } & I18nContext,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
): Promise<string> {
|
|
if (view.name.includes('{objectLabelPlural}')) {
|
|
const objectMetadata = await context.loaders.objectMetadataLoader.load({
|
|
objectMetadataId: view.objectMetadataId,
|
|
workspaceId: workspace.id,
|
|
});
|
|
|
|
if (isDefined(objectMetadata)) {
|
|
const i18n = this.i18nService.getI18nInstance(context.req.locale);
|
|
const translatedObjectLabel = resolveObjectMetadataStandardOverride(
|
|
{
|
|
labelPlural: objectMetadata.labelPlural,
|
|
labelSingular: objectMetadata.labelSingular,
|
|
description: objectMetadata.description ?? undefined,
|
|
icon: objectMetadata.icon ?? undefined,
|
|
isCustom: objectMetadata.isCustom,
|
|
standardOverrides: objectMetadata.standardOverrides ?? undefined,
|
|
},
|
|
'labelPlural',
|
|
context.req.locale,
|
|
i18n,
|
|
);
|
|
|
|
return this.viewService.processViewNameWithTemplate(
|
|
view.name,
|
|
view.isCustom,
|
|
translatedObjectLabel,
|
|
context.req.locale,
|
|
);
|
|
}
|
|
}
|
|
|
|
return this.viewService.processViewNameWithTemplate(
|
|
view.name,
|
|
view.isCustom,
|
|
undefined,
|
|
context.req.locale,
|
|
);
|
|
}
|
|
|
|
@Query(() => [ViewDTO])
|
|
@UseGuards(CustomPermissionGuard)
|
|
async getCoreViews(
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
@AuthUserWorkspaceId() userWorkspaceId: string | undefined,
|
|
@Args('objectMetadataId', { type: () => String, nullable: true })
|
|
objectMetadataId?: string,
|
|
): Promise<ViewEntity[]> {
|
|
if (objectMetadataId) {
|
|
return this.viewService.findByObjectMetadataId(
|
|
workspace.id,
|
|
objectMetadataId,
|
|
userWorkspaceId,
|
|
);
|
|
}
|
|
|
|
return this.viewService.findByWorkspaceId(workspace.id, userWorkspaceId);
|
|
}
|
|
|
|
@Query(() => ViewDTO, { nullable: true })
|
|
@UseGuards(NoPermissionGuard)
|
|
async getCoreView(
|
|
@Args('id', { type: () => String }) id: string,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
): Promise<ViewDTO | null> {
|
|
const view = await this.viewService.findById(id, workspace.id);
|
|
|
|
if (!view) {
|
|
return null;
|
|
}
|
|
|
|
// Do not apply list visibility filtering here: unlisted views are accessible by link
|
|
return view;
|
|
}
|
|
|
|
@Mutation(() => ViewDTO)
|
|
@UseGuards(CreateViewPermissionGuard)
|
|
async createCoreView(
|
|
@Args('input') input: CreateViewInput,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
@AuthUserWorkspaceId() userWorkspaceId: string | undefined,
|
|
): Promise<ViewDTO> {
|
|
const visibility = input.visibility ?? ViewVisibility.WORKSPACE;
|
|
|
|
input.visibility = visibility;
|
|
|
|
return await this.viewService.createOne({
|
|
createViewInput: input,
|
|
workspaceId: workspace.id,
|
|
createdByUserWorkspaceId: userWorkspaceId,
|
|
});
|
|
}
|
|
|
|
@Mutation(() => ViewDTO)
|
|
@UseGuards(UpdateViewPermissionGuard)
|
|
async updateCoreView(
|
|
@Args('id', { type: () => String }) id: string,
|
|
@Args('input') input: UpdateViewInput,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
@AuthUserWorkspaceId() userWorkspaceId: string | undefined,
|
|
): Promise<ViewDTO> {
|
|
return await this.viewService.updateOne({
|
|
updateViewInput: { ...input, id },
|
|
workspaceId: workspace.id,
|
|
userWorkspaceId,
|
|
});
|
|
}
|
|
|
|
@Mutation(() => Boolean)
|
|
@UseGuards(DeleteViewPermissionGuard)
|
|
async deleteCoreView(
|
|
@Args('id', { type: () => String }) id: string,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
): Promise<boolean> {
|
|
const deletedView = await this.viewService.deleteOne({
|
|
deleteViewInput: { id },
|
|
workspaceId: workspace.id,
|
|
});
|
|
|
|
return isDefined(deletedView);
|
|
}
|
|
|
|
@Mutation(() => Boolean)
|
|
@UseGuards(DestroyViewPermissionGuard)
|
|
async destroyCoreView(
|
|
@Args('id', { type: () => String }) id: string,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
): Promise<boolean> {
|
|
const deletedView = await this.viewService.destroyOne({
|
|
destroyViewInput: { id },
|
|
workspaceId: workspace.id,
|
|
});
|
|
|
|
return isDefined(deletedView);
|
|
}
|
|
|
|
@ResolveField(() => [ViewFieldDTO])
|
|
async viewFields(
|
|
@Parent() view: ViewDTO,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
) {
|
|
if (isArray(view.viewFields)) {
|
|
return view.viewFields;
|
|
}
|
|
|
|
return this.viewFieldV2Service.findByViewId(workspace.id, view.id);
|
|
}
|
|
|
|
@ResolveField(() => [ViewFilterDTO])
|
|
async viewFilters(
|
|
@Parent() view: ViewDTO,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
) {
|
|
if (isArray(view.viewFilters)) {
|
|
return view.viewFilters;
|
|
}
|
|
|
|
return this.viewFilterService.findByViewId(workspace.id, view.id);
|
|
}
|
|
|
|
@ResolveField(() => [ViewFilterGroupDTO])
|
|
async viewFilterGroups(
|
|
@Parent() view: ViewDTO,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
) {
|
|
if (isArray(view.viewFilterGroups)) {
|
|
return view.viewFilterGroups;
|
|
}
|
|
|
|
return this.viewFilterGroupService.findByViewId(workspace.id, view.id);
|
|
}
|
|
|
|
@ResolveField(() => [ViewSortDTO])
|
|
async viewSorts(
|
|
@Parent() view: ViewDTO,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
) {
|
|
if (isArray(view.viewSorts)) {
|
|
return view.viewSorts;
|
|
}
|
|
|
|
return this.viewSortService.findByViewId(workspace.id, view.id);
|
|
}
|
|
|
|
@ResolveField(() => [ViewGroupDTO])
|
|
async viewGroups(
|
|
@Parent() view: ViewDTO,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
) {
|
|
if (isArray(view.viewGroups)) {
|
|
return view.viewGroups;
|
|
}
|
|
|
|
return this.viewGroupService.findByViewId(workspace.id, view.id);
|
|
}
|
|
}
|