Charles Bochet
9e21e55db4
## Fix resolver schema leaking between `/metadata` and `/graphql` endpoints ### Summary - Patch `@nestjs/graphql` to support a `resolverSchemaScope` option that filters resolvers at both schema generation and runtime, preventing cross-endpoint leaking - Introduce `@CoreResolver()` and `@MetadataResolver()` decorators to explicitly scope each resolver to its endpoint - Move most resolvers (auth, billing, workspace, user, etc.) to the metadata schema where the frontend expects them; only workflow and timeline calendar/messaging resolvers remain on `/graphql` - Fix frontend `SSEQuerySubscribeEffect` to use the default (metadata) Apollo client instead of the core client ### Problem NestJS GraphQL's module-based resolver discovery traverses transitive imports, causing resolvers from `/metadata` modules to leak into the `/graphql` schema and vice versa. This made the schemas unpredictable and tightly coupled to module import order. ### Approach - Added `resolverSchemaScope` to `GqlModuleOptions` via a patch on `@nestjs/graphql`, filtering in both `filterResolvers()` (runtime binding) and `getAllCtors()` (schema generation) - Each resolver is explicitly decorated with `@CoreResolver()` or `@MetadataResolver()` - Organized decorator, constant, and type files under `graphql-config/` following project conventions Core GQL Schema: (see: no more fields!) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/668f3f0f-485e-43f0-92be-4345aeccacb6" /> Metadata GQL Schema (see no more getTimelineCalendarEventsFromCompany) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/443913db-e5fe-4161-b0e7-4a971cc80a71" />
72 lines
3.3 KiB
TypeScript
72 lines
3.3 KiB
TypeScript
import { UseGuards, UseInterceptors } from '@nestjs/common';
|
|
import { Args, Mutation, Query } from '@nestjs/graphql';
|
|
|
|
import { PermissionFlagType } from 'twenty-shared/constants';
|
|
|
|
import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
|
|
import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
|
|
import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
|
|
import { MetadataResolver } from 'src/engine/api/graphql/graphql-config/decorators/metadata-resolver.decorator';
|
|
import { SettingsPermissionGuard } from 'src/engine/guards/settings-permission.guard';
|
|
import { WorkspaceAuthGuard } from 'src/engine/guards/workspace-auth.guard';
|
|
import { CreateWebhookInput } from 'src/engine/metadata-modules/webhook/dtos/create-webhook.input';
|
|
import { UpdateWebhookInput } from 'src/engine/metadata-modules/webhook/dtos/update-webhook.input';
|
|
import { WebhookDTO } from 'src/engine/metadata-modules/webhook/dtos/webhook.dto';
|
|
import { WebhookGraphqlApiExceptionInterceptor } from 'src/engine/metadata-modules/webhook/interceptors/webhook-graphql-api-exception.interceptor';
|
|
import { WebhookService } from 'src/engine/metadata-modules/webhook/webhook.service';
|
|
import { WorkspaceMigrationGraphqlApiExceptionInterceptor } from 'src/engine/workspace-manager/workspace-migration/interceptors/workspace-migration-graphql-api-exception.interceptor';
|
|
|
|
@UseGuards(WorkspaceAuthGuard)
|
|
@UseInterceptors(
|
|
WorkspaceMigrationGraphqlApiExceptionInterceptor,
|
|
WebhookGraphqlApiExceptionInterceptor,
|
|
)
|
|
@MetadataResolver(() => WebhookDTO)
|
|
export class WebhookResolver {
|
|
constructor(private readonly webhookService: WebhookService) {}
|
|
|
|
@Query(() => [WebhookDTO])
|
|
@UseGuards(SettingsPermissionGuard(PermissionFlagType.API_KEYS_AND_WEBHOOKS))
|
|
async webhooks(
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
): Promise<WebhookDTO[]> {
|
|
return await this.webhookService.findAll(workspace.id);
|
|
}
|
|
|
|
@Query(() => WebhookDTO, { nullable: true })
|
|
@UseGuards(SettingsPermissionGuard(PermissionFlagType.API_KEYS_AND_WEBHOOKS))
|
|
async webhook(
|
|
@Args('id', { type: () => UUIDScalarType }) id: string,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
): Promise<WebhookDTO | null> {
|
|
return await this.webhookService.findById(id, workspace.id);
|
|
}
|
|
|
|
@Mutation(() => WebhookDTO)
|
|
@UseGuards(SettingsPermissionGuard(PermissionFlagType.API_KEYS_AND_WEBHOOKS))
|
|
async createWebhook(
|
|
@Args('input') input: CreateWebhookInput,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
): Promise<WebhookDTO> {
|
|
return await this.webhookService.create(input, workspace.id);
|
|
}
|
|
|
|
@Mutation(() => WebhookDTO)
|
|
@UseGuards(SettingsPermissionGuard(PermissionFlagType.API_KEYS_AND_WEBHOOKS))
|
|
async updateWebhook(
|
|
@Args('input') input: UpdateWebhookInput,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
): Promise<WebhookDTO> {
|
|
return await this.webhookService.update(input, workspace.id);
|
|
}
|
|
|
|
@Mutation(() => WebhookDTO)
|
|
@UseGuards(SettingsPermissionGuard(PermissionFlagType.API_KEYS_AND_WEBHOOKS))
|
|
async deleteWebhook(
|
|
@Args('id', { type: () => UUIDScalarType }) id: string,
|
|
@AuthWorkspace() workspace: WorkspaceEntity,
|
|
): Promise<WebhookDTO> {
|
|
return await this.webhookService.delete(id, workspace.id);
|
|
}
|
|
}
|