9d57bc39e5
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
149 lines
4.5 KiB
TypeScript
149 lines
4.5 KiB
TypeScript
import { TextInput } from '@/ui/input/components/TextInput';
|
|
import { Dropdown } from '@/ui/layout/dropdown/components/Dropdown';
|
|
import { DropdownContent } from '@/ui/layout/dropdown/components/DropdownContent';
|
|
import { DropdownMenuItemsContainer } from '@/ui/layout/dropdown/components/DropdownMenuItemsContainer';
|
|
import { useCloseDropdown } from '@/ui/layout/dropdown/hooks/useCloseDropdown';
|
|
import { TableCell } from '@/ui/layout/table/components/TableCell';
|
|
import { TableRow } from '@/ui/layout/table/components/TableRow';
|
|
import { t } from '@lingui/core/macro';
|
|
import React, { useState } from 'react';
|
|
import {
|
|
IconCheck,
|
|
IconDotsVertical,
|
|
IconPencil,
|
|
IconTrash,
|
|
IconX,
|
|
OverflowingTextWithTooltip,
|
|
} from 'twenty-ui/display';
|
|
import { LightIconButton } from 'twenty-ui/input';
|
|
import { MenuItem } from 'twenty-ui/navigation';
|
|
import type { ApplicationVariable } from '~/generated-metadata/graphql';
|
|
|
|
const StyledEditModeTableRow = (
|
|
props: React.ComponentProps<typeof TableRow>,
|
|
) => (
|
|
<TableRow
|
|
gridTemplateColumns="180px auto 56px"
|
|
// oxlint-disable-next-line react/jsx-props-no-spreading
|
|
{...props}
|
|
/>
|
|
);
|
|
|
|
const StyledTableRow = (props: React.ComponentProps<typeof TableRow>) => (
|
|
<TableRow
|
|
gridTemplateColumns="180px 300px 32px"
|
|
// oxlint-disable-next-line react/jsx-props-no-spreading
|
|
{...props}
|
|
/>
|
|
);
|
|
|
|
export const SettingsLogicFunctionTabEnvironmentVariableTableRow = ({
|
|
envVariable,
|
|
onChange,
|
|
onDelete,
|
|
initialEditMode = false,
|
|
}: {
|
|
envVariable: ApplicationVariable;
|
|
onChange: (newEnvVariable: ApplicationVariable) => void;
|
|
onDelete: () => void;
|
|
initialEditMode?: boolean;
|
|
}) => {
|
|
const [editedEnvVariable, setEditedEnvVariable] = useState(envVariable);
|
|
const [editMode, setEditMode] = useState(initialEditMode);
|
|
const dropDownId = `settings-environment-variable-dropdown-${envVariable.id}`;
|
|
const { closeDropdown } = useCloseDropdown();
|
|
|
|
return editMode ? (
|
|
<StyledEditModeTableRow>
|
|
<TableCell>
|
|
<TextInput
|
|
autoFocus
|
|
value={editedEnvVariable.key}
|
|
onChange={(newKey) =>
|
|
setEditedEnvVariable({ ...editedEnvVariable, key: newKey })
|
|
}
|
|
placeholder={t`Name`}
|
|
fullWidth
|
|
/>
|
|
</TableCell>
|
|
<TableCell>
|
|
<TextInput
|
|
value={editedEnvVariable.value}
|
|
onChange={(newValue) =>
|
|
setEditedEnvVariable({ ...editedEnvVariable, value: newValue })
|
|
}
|
|
placeholder={t`Value`}
|
|
fullWidth
|
|
/>
|
|
</TableCell>
|
|
<TableCell>
|
|
<LightIconButton
|
|
accent="tertiary"
|
|
Icon={IconX}
|
|
onClick={() => {
|
|
if (envVariable.key === '' && envVariable.value === '') {
|
|
onDelete();
|
|
}
|
|
setEditedEnvVariable(envVariable);
|
|
setEditMode(false);
|
|
}}
|
|
/>
|
|
<LightIconButton
|
|
accent="tertiary"
|
|
Icon={IconCheck}
|
|
disabled={
|
|
editedEnvVariable.key === '' || editedEnvVariable.value === ''
|
|
}
|
|
onClick={() => {
|
|
onChange(editedEnvVariable);
|
|
setEditMode(false);
|
|
}}
|
|
/>
|
|
</TableCell>
|
|
</StyledEditModeTableRow>
|
|
) : (
|
|
<StyledTableRow onClick={() => setEditMode(true)}>
|
|
<TableCell>
|
|
<OverflowingTextWithTooltip text={envVariable.key} />
|
|
</TableCell>
|
|
<TableCell>
|
|
<OverflowingTextWithTooltip text={envVariable.value} />
|
|
</TableCell>
|
|
<TableCell>
|
|
<Dropdown
|
|
dropdownId={dropDownId}
|
|
clickableComponent={
|
|
<LightIconButton
|
|
aria-label={t`Env Variable Options`}
|
|
Icon={IconDotsVertical}
|
|
accent="tertiary"
|
|
/>
|
|
}
|
|
dropdownComponents={
|
|
<DropdownContent>
|
|
<DropdownMenuItemsContainer>
|
|
<MenuItem
|
|
text={t`Edit`}
|
|
LeftIcon={IconPencil}
|
|
onClick={() => {
|
|
setEditMode(true);
|
|
closeDropdown(dropDownId);
|
|
}}
|
|
/>
|
|
<MenuItem
|
|
text={t`Delete`}
|
|
LeftIcon={IconTrash}
|
|
onClick={() => {
|
|
onDelete();
|
|
closeDropdown(dropDownId);
|
|
}}
|
|
/>
|
|
</DropdownMenuItemsContainer>
|
|
</DropdownContent>
|
|
}
|
|
/>
|
|
</TableCell>
|
|
</StyledTableRow>
|
|
);
|
|
};
|