Marie
9c2b88870f
This PR attemps at improving sentry grouping and filtering by - Using the exceptionCode as the fingerprint when the error is a customException. For this to work in this PR we are now throwing customExceptions instead of internalServerError deprived of their code. They will still be converted to Internal server errors when sent back as response - Filtering 4xx issues where it was missing (for emailVerification because errors were not handled, for invalid captcha and billing errors because they are httpErrors and not graphqlErrors) --------- Co-authored-by: Félix Malfait <felix@twenty.com>
40 lines
1.3 KiB
TypeScript
40 lines
1.3 KiB
TypeScript
import {
|
|
ConflictError,
|
|
ForbiddenError,
|
|
NotFoundError,
|
|
UserInputError,
|
|
} from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
|
|
import {
|
|
ObjectMetadataException,
|
|
ObjectMetadataExceptionCode,
|
|
} from 'src/engine/metadata-modules/object-metadata/object-metadata.exception';
|
|
import { InvalidMetadataException } from 'src/engine/metadata-modules/utils/exceptions/invalid-metadata.exception';
|
|
|
|
export const objectMetadataGraphqlApiExceptionHandler = (error: Error) => {
|
|
if (error instanceof InvalidMetadataException) {
|
|
throw new UserInputError(error.message);
|
|
}
|
|
|
|
if (error instanceof ObjectMetadataException) {
|
|
switch (error.code) {
|
|
case ObjectMetadataExceptionCode.OBJECT_METADATA_NOT_FOUND:
|
|
throw new NotFoundError(error.message);
|
|
case ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT:
|
|
throw new UserInputError(error.message);
|
|
case ObjectMetadataExceptionCode.OBJECT_MUTATION_NOT_ALLOWED:
|
|
throw new ForbiddenError(error.message);
|
|
case ObjectMetadataExceptionCode.OBJECT_ALREADY_EXISTS:
|
|
throw new ConflictError(error.message);
|
|
case ObjectMetadataExceptionCode.MISSING_CUSTOM_OBJECT_DEFAULT_LABEL_IDENTIFIER_FIELD:
|
|
throw error;
|
|
default: {
|
|
const _exhaustiveCheck: never = error.code;
|
|
|
|
throw error;
|
|
}
|
|
}
|
|
}
|
|
|
|
throw error;
|
|
};
|