Raphaël Bosi
b11f77df2a
## PR Description - Uses `expr-eval` to enable front components (SDK plugins) to define conditional availability as declarative expressions. - Moves shared types and constants to `twenty-shared` - Introduces a `conditionalAvailabilityExpression` field on `CommandMenuItemEntity`, allowing command menu items to store an `expr-eval` compatible expression string that is evaluated against a CommandMenuContext to determine if the item should be shown. - Creates an esbuild transform plugin `conditional-availability-transform-plugin` in `twenty-sdk` that converts TypeScript conditional availability expressions into `expr-eval` compatible syntax at build time, so SDK developers can write natural TS expressions that get transformed to evaluable strings. - Removes deprecated `forceRegisteredActionsByKey` state and its usage. - Creates `useCommandMenuContext` hook that builds the full `CommandMenuContext` object from React state, which is then passed to `useCommandMenuItemFrontComponentActions` for evaluating conditional availability expressions.
105 lines
2.8 KiB
TypeScript
105 lines
2.8 KiB
TypeScript
import { faker } from '@faker-js/faker';
|
|
import { expectOneNotInternalServerErrorSnapshot } from 'test/integration/graphql/utils/expect-one-not-internal-server-error-snapshot.util';
|
|
import { updateFeatureFlag } from 'test/integration/metadata/suites/utils/update-feature-flag.util';
|
|
import { createCommandMenuItem } from 'test/integration/metadata/suites/command-menu-item/utils/create-command-menu-item.util';
|
|
import {
|
|
eachTestingContextFilter,
|
|
type EachTestingContext,
|
|
} from 'twenty-shared/testing';
|
|
import { FeatureFlagKey } from 'twenty-shared/types';
|
|
|
|
import { type CreateCommandMenuItemInput } from 'src/engine/metadata-modules/command-menu-item/dtos/create-command-menu-item.input';
|
|
|
|
type TestContext = {
|
|
input: CreateCommandMenuItemInput;
|
|
};
|
|
|
|
const failingCommandMenuItemCreationTestCases: EachTestingContext<TestContext>[] =
|
|
[
|
|
{
|
|
title: 'when creating with empty label',
|
|
context: {
|
|
input: {
|
|
workflowVersionId: faker.string.uuid(),
|
|
label: '',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'when creating with missing label',
|
|
context: {
|
|
input: {
|
|
workflowVersionId: faker.string.uuid(),
|
|
} as CreateCommandMenuItemInput,
|
|
},
|
|
},
|
|
{
|
|
title: 'when creating with missing workflowVersionId',
|
|
context: {
|
|
input: {
|
|
label: 'Test Label',
|
|
} as CreateCommandMenuItemInput,
|
|
},
|
|
},
|
|
{
|
|
title: 'when creating with empty workflowVersionId',
|
|
context: {
|
|
input: {
|
|
workflowVersionId: '',
|
|
label: 'Test Label',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'when creating with invalid workflowVersionId (not a UUID)',
|
|
context: {
|
|
input: {
|
|
workflowVersionId: 'not-a-valid-uuid',
|
|
label: 'Test Label',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'when creating with both workflowVersionId and frontComponentId',
|
|
context: {
|
|
input: {
|
|
workflowVersionId: faker.string.uuid(),
|
|
frontComponentId: faker.string.uuid(),
|
|
label: 'Test Label',
|
|
},
|
|
},
|
|
},
|
|
];
|
|
|
|
describe('CommandMenuItem creation should fail', () => {
|
|
beforeAll(async () => {
|
|
await updateFeatureFlag({
|
|
featureFlag: FeatureFlagKey.IS_COMMAND_MENU_ITEM_ENABLED,
|
|
value: true,
|
|
expectToFail: false,
|
|
});
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await updateFeatureFlag({
|
|
featureFlag: FeatureFlagKey.IS_COMMAND_MENU_ITEM_ENABLED,
|
|
value: false,
|
|
expectToFail: false,
|
|
});
|
|
});
|
|
|
|
it.each(eachTestingContextFilter(failingCommandMenuItemCreationTestCases))(
|
|
'$title',
|
|
async ({ context }) => {
|
|
const { errors } = await createCommandMenuItem({
|
|
expectToFail: true,
|
|
input: context.input,
|
|
});
|
|
|
|
expectOneNotInternalServerErrorSnapshot({
|
|
errors,
|
|
});
|
|
},
|
|
);
|
|
});
|