Charles Bochet
e4a0dfe262
## Problem
The merge queue is red. Two e2e tests fail consistently on `merge_group`
runs, both timing out while clicking `Settings`:
- `tests/create-kanban-view.spec.ts` ("Create Industry Select Field")
- `tests/authentication/signup_invite_email.spec.ts` ("Go to Settings
and copy invite link")
The earlier tokenPair localStorage fix (#21507 / e2e read in #21519)
restored login, so auth works again — but the navigation/settings polish
in #21523 then **moved the Settings entry out of the main app navigation
and into the workspace switcher dropdown** ("Moves Settings below
Support in the workspace switcher menu").
The e2e tests still looked for a top-level `getByRole('button', { name:
'Settings' })`, which no longer exists, so they timed out.
## Fix
Reach Settings the new way — open the workspace switcher dropdown, then
click the `Settings` link (it is now an `UndecoratedLink`/`MenuItem`,
role `link`, in `MultiWorkspaceDropdownDefaultComponents`):
- `lib/pom/leftMenu.ts`: `goToSettings()` now opens `workspace-dropdown`
first; `settingsTab` locator switched from `button` to `link`.
- `tests/create-kanban-view.spec.ts`: open the workspace dropdown before
clicking the Settings link.
- `tests/authentication/signup_invite_email.spec.ts`: the post-signup
"logged in" assertion now checks the `workspace-dropdown` is visible
instead of the removed Settings button.
## Testing
Triggering the merge-queue e2e suite via the `run-merge-queue` label on
this PR.
<!-- This is an auto-generated description by cubic. -->
<a
href="https://cubic.dev/pr/twentyhq/twenty/pull/21528?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>
<!-- End of auto-generated description by cubic. -->
56 lines
3.0 KiB
TypeScript
56 lines
3.0 KiB
TypeScript
import { expect, test } from '../lib/fixtures/screenshot';
|
|
test.describe.serial('Create Kanban View', () => {
|
|
test('Create Industry Select Field', async ({ page }) => {
|
|
await page.getByTestId('workspace-dropdown').click();
|
|
await page.getByRole('link', { name: 'Settings' }).click();
|
|
await page.getByRole('link', { name: 'Data model' }).click();
|
|
await page.getByRole('link', { name: 'Opportunities' }).click();
|
|
await expect(page.getByRole('button', { name: 'New Field' })).toBeVisible();
|
|
await page.getByRole('button', { name: 'New Field' }).click();
|
|
await page.getByRole('link', { name: 'Select', exact: true }).click();
|
|
await page.getByRole('textbox', { name: 'Employees' }).click();
|
|
await page.getByRole('textbox', { name: 'Employees' }).fill('Industry');
|
|
await page.getByRole('textbox').nth(1).click();
|
|
await page.getByRole('textbox').nth(1).press('ControlOrMeta+a');
|
|
await page.getByRole('textbox').nth(1).fill('Food');
|
|
await page.getByRole('button', { name: 'Add option' }).click();
|
|
await page.getByRole('button', { name: 'Option 2' }).getByRole('textbox').fill('Tech');
|
|
await page.getByRole('button', { name: 'Add option' }).click();
|
|
await page.getByRole('button', { name: 'Option 3' }).getByRole('textbox').fill('Travel');
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.waitForURL('**/objects/opportunities');
|
|
await page.waitForSelector('text=Industry');
|
|
await expect(page.getByText('Industry')).toBeVisible();
|
|
});
|
|
|
|
test('Create Kanban View from Industry Select Field', async ({ page }) => {
|
|
await page.getByRole('link', { name: 'Opportunities' }).click();
|
|
await page.getByRole('button', { name: /All Opportunities/ }).click();
|
|
await page.getByText('Add view').click();
|
|
await page.getByRole('textbox').press('ControlOrMeta+a');
|
|
await page.getByRole('textbox').fill('By industry');
|
|
await page.getByRole('button', { name: 'Table', exact: true }).click();
|
|
await page.getByText('Kanban').click();
|
|
await page.locator('[aria-controls="view-picker-kanban-field-options"]').click();
|
|
await page.getByRole('option', { name: 'Industry' }).click();
|
|
await page.getByRole('button', { name: 'Create new view' }).click();
|
|
await expect(page.getByText('Food')).toBeVisible({ timeout: 30000 });
|
|
await expect(page.getByText('Tech')).toBeVisible();
|
|
await expect(page.getByText('Travel')).toBeVisible();
|
|
await expect(page.getByText('No Value')).toBeVisible();
|
|
const byIndustryElements = await page.locator('text=By industry').all();
|
|
expect(byIndustryElements.length).toBeGreaterThanOrEqual(1);
|
|
for (const element of byIndustryElements) {
|
|
await expect(element).toBeVisible();
|
|
}
|
|
await page.getByText('Options').click();
|
|
await page.getByText('Group', { exact: true }).click();
|
|
await Promise.all([page.getByTestId('hide-group-').click(),
|
|
page.waitForRequest((req) => {
|
|
return req.url().includes('/metadata') &&
|
|
req.method() === 'POST';
|
|
})]);
|
|
await expect(page.getByText('No Value')).not.toBeVisible();
|
|
});
|
|
})
|