Files
twenty/packages/twenty-server/test/integration/secret-encryption/secret-encryption-rotation.integration-spec.ts
T
Charles Bochet 9988f98577 feat(server): idempotent CLI to rotate ENCRYPTION_KEY across enc:v2 rows (#20613)
## Summary
Adds the \`secret-encryption:rotate\` CLI command, which re-encrypts
every at-rest secret stored in an \`enc:v2:\` envelope under the current
\`ENCRYPTION_KEY\`. The command is **online** and **resumable**: a SQL
filter skips rows already on the current keyId, so interrupting it
(Ctrl-C, container restart, …) and re-running picks up where it left off
without re-rotating earlier rows.

### Sites covered (one handler each)
| Site | Table.column | Scope |
| --- | --- | --- |
| \`connected-account-tokens\` | \`connectedAccount.{accessToken,
refreshToken}\` | workspace |
| \`application-variable\` | \`applicationVariable.value\` (isSecret
only) | workspace |
| \`application-registration-variable\` |
\`applicationRegistrationVariable.encryptedValue\` | instance |
| \`signing-key-private-keys\` | \`signingKey.privateKey\` | instance |
| \`sensitive-config-storage\` | \`keyValuePair.value\` (isSensitive +
STRING configs) | instance |
| \`totp-secrets\` | \`twoFactorAuthenticationMethod.secret\` |
workspace |

Each handler:
- Filters at SQL level on \`value LIKE 'enc:v2:%' AND value NOT LIKE
'enc:v2:<primaryKeyId>:%'\` to enforce idempotency without re-decrypting
already-rotated rows.
- Uses cursor-based batching (default **200**, capped **5000**).
- Threads \`workspaceId\` into HKDF for workspace-scoped sites; runs
instance-scoped for the rest.

### CLI flags
| Flag | Description |
| --- | --- |
| \`-s, --site <site>\` | Limit to a single site. |
| \`-b, --batch-size <n>\` | Override per-batch row count. |
| \`-d, --dry-run\` | Decrypt + re-encrypt in memory, skip the
\`UPDATE\`. |

The runner logs progress via Nest \`Logger\` (per-site start,
completion, final summary) and exits non-zero when any site reports
\`errors > 0\`. \`FALLBACK_ENCRYPTION_KEY\` must be set to the previous
\`ENCRYPTION_KEY\` during rotation; the runner warns when it is unset.

Operator documentation lives in #20611 (docs PR).
2026-05-20 17:51:29 +00:00

129 lines
4.5 KiB
TypeScript

import crypto from 'crypto';
import { buildBaseManifest } from 'test/integration/metadata/suites/application/utils/build-base-manifest.util';
import { cleanupApplicationAndAppRegistration } from 'test/integration/metadata/suites/application/utils/cleanup-application-and-app-registration.util';
import { setupApplicationForSync } from 'test/integration/metadata/suites/application/utils/setup-application-for-sync.util';
import { syncApplication } from 'test/integration/metadata/suites/application/utils/sync-application.util';
import {
findOneApplicationIdByUniversalIdentifier,
findOneApplicationVariables,
} from 'test/integration/secret-encryption/utils/find-one-application.util';
import { runSecretEncryptionRotationCommand } from 'test/integration/secret-encryption/utils/run-secret-encryption-rotation-command.util';
import { updateOneApplicationVariable } from 'test/integration/secret-encryption/utils/update-one-application-variable.util';
import { SECRET_APPLICATION_VARIABLE_MASK } from 'src/engine/core-modules/application/application-variable/constants/secret-application-variable-mask.constant';
const ROTATION_VARIABLE_KEY = 'TEST_ROTATION_SECRET';
const buildExpectedMask = (plaintext: string): string => {
const visibleCharsCount = Math.min(5, Math.floor(plaintext.length / 10));
return `${plaintext.slice(0, visibleCharsCount)}${SECRET_APPLICATION_VARIABLE_MASK}`;
};
describe('secret-encryption:rotate command (integration)', () => {
let applicationUniversalIdentifier: string;
let applicationId: string;
const plaintext = 'secret-value-that-must-survive-key-rotation';
beforeAll(async () => {
applicationUniversalIdentifier = crypto.randomUUID();
const roleUniversalIdentifier = crypto.randomUUID();
const roleLabel = `Rotation Test Role ${crypto.randomUUID()}`;
await setupApplicationForSync({
applicationUniversalIdentifier,
name: 'Rotation Test Application',
description: 'Verifies secret-encryption:rotate keeps secrets readable',
sourcePath: 'test-secret-encryption-rotation',
});
await syncApplication({
manifest: buildBaseManifest({
appId: applicationUniversalIdentifier,
roleId: roleUniversalIdentifier,
overrides: {
application: {
universalIdentifier: applicationUniversalIdentifier,
defaultRoleUniversalIdentifier: roleUniversalIdentifier,
displayName: 'Rotation Test Application',
description:
'Verifies secret-encryption:rotate keeps secrets readable',
applicationVariables: {
[ROTATION_VARIABLE_KEY]: {
universalIdentifier: crypto.randomUUID(),
isSecret: true,
},
},
packageJsonChecksum: null,
yarnLockChecksum: null,
},
roles: [
{
universalIdentifier: roleUniversalIdentifier,
label: roleLabel,
description: 'A role for the secret encryption rotation test',
},
],
},
}),
expectToFail: false,
});
applicationId = await findOneApplicationIdByUniversalIdentifier({
universalIdentifier: applicationUniversalIdentifier,
});
await updateOneApplicationVariable({
key: ROTATION_VARIABLE_KEY,
value: plaintext,
applicationId,
});
}, 120000);
afterAll(async () => {
await cleanupApplicationAndAppRegistration({
applicationUniversalIdentifier,
});
});
it(
'keeps the secret applicationVariable decryptable via GraphQL after running the rotation',
async () => {
await runSecretEncryptionRotationCommand();
const variables = await findOneApplicationVariables({
id: applicationId,
});
const variable = variables.find(
(applicationVariable) =>
applicationVariable.key === ROTATION_VARIABLE_KEY,
);
expect(variable).toBeDefined();
expect(variable?.isSecret).toBe(true);
expect(variable?.value).toBe(buildExpectedMask(plaintext));
},
60000,
);
it(
'is idempotent: running rotation twice does not corrupt secrets',
async () => {
await runSecretEncryptionRotationCommand();
await runSecretEncryptionRotationCommand();
const variables = await findOneApplicationVariables({
id: applicationId,
});
const variable = variables.find(
(applicationVariable) =>
applicationVariable.key === ROTATION_VARIABLE_KEY,
);
expect(variable?.value).toBe(buildExpectedMask(plaintext));
},
90000,
);
});