Charles Bochet
647c32ff3e
## Summary
- **Eliminate `ICON_SIZES` / `ICON_STROKES` constants**: all icon
dimensions are now resolved at runtime via
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.X)`, ensuring
values always come from computed CSS variables
- **No more consumer imports from `twenty-ui/theme`**: moved
`ColorSchemeContext`, `ColorSchemeProvider`, `ThemeColor`,
`MAIN_COLOR_NAMES`, `getNextThemeColor`, `AnimationDuration` to
`twenty-ui/theme-constants`
- **Remove `ThemeContext` / `ThemeContextProvider` / `ThemeProvider` /
`ThemeType`**: replaced across ~300 files with `themeCssVariables` (for
CSS contexts) or `resolveThemeVariable` / `resolveThemeVariableAsNumber`
(for JS runtime values)
- **Simplify provider chain**: only `ColorSchemeProvider` remains — it
toggles `light`/`dark` class on `document.documentElement` and provides
`colorScheme` via React context
- **Fix pre-existing test failures**: `useIcons.test.ts`
(non-configurable ES module spy) and
`turnRecordFilterGroupIntoGqlOperationFilter.test.ts`
(`Omit<RecordFilter, 'id'>` type mismatch)
### Theme access pattern (before → after)
| Context | Before | After |
|---------|--------|-------|
| CSS (Linaria) | `${({ theme }) => theme.font.color.primary}` |
`${themeCssVariables.font.color.primary}` |
| JS runtime (icon size, animation) | `theme.icon.size.md` /
`ICON_SIZES.md` |
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.md)` |
| Color scheme check | `theme.name === 'dark'` |
`useContext(ColorSchemeContext).colorScheme === 'dark'` |
34 lines
1.1 KiB
TypeScript
34 lines
1.1 KiB
TypeScript
import { BLUR_DARK } from '@ui/theme/constants/BlurDark';
|
|
import { ILLUSTRATION_ICON_DARK } from '@ui/theme/constants/IllustrationIconDark';
|
|
import { COLOR_DARK } from './ColorsDark';
|
|
import { GRAY_SCALE_DARK } from './GrayScaleDark';
|
|
import { SNACK_BAR_DARK } from './SnackBarDark';
|
|
import { ACCENT_DARK } from './AccentDark';
|
|
import { BACKGROUND_DARK } from './BackgroundDark';
|
|
import { BORDER_DARK } from './BorderDark';
|
|
import { BOX_SHADOW_DARK } from './BoxShadowDark';
|
|
import { CODE_DARK } from './CodeDark';
|
|
import { FONT_DARK } from './FontDark';
|
|
import { TAG_DARK } from './TagDark';
|
|
import { THEME_COMMON } from './ThemeCommon';
|
|
import type { THEME_LIGHT } from './ThemeLight';
|
|
|
|
export const THEME_DARK: typeof THEME_LIGHT = {
|
|
...THEME_COMMON,
|
|
...{
|
|
accent: ACCENT_DARK,
|
|
background: BACKGROUND_DARK,
|
|
blur: BLUR_DARK,
|
|
border: BORDER_DARK,
|
|
boxShadow: BOX_SHADOW_DARK,
|
|
font: FONT_DARK,
|
|
name: 'dark',
|
|
snackBar: SNACK_BAR_DARK,
|
|
tag: TAG_DARK,
|
|
code: CODE_DARK,
|
|
IllustrationIcon: ILLUSTRATION_ICON_DARK,
|
|
grayScale: GRAY_SCALE_DARK,
|
|
color: COLOR_DARK,
|
|
},
|
|
};
|