Charles Bochet
647c32ff3e
## Summary
- **Eliminate `ICON_SIZES` / `ICON_STROKES` constants**: all icon
dimensions are now resolved at runtime via
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.X)`, ensuring
values always come from computed CSS variables
- **No more consumer imports from `twenty-ui/theme`**: moved
`ColorSchemeContext`, `ColorSchemeProvider`, `ThemeColor`,
`MAIN_COLOR_NAMES`, `getNextThemeColor`, `AnimationDuration` to
`twenty-ui/theme-constants`
- **Remove `ThemeContext` / `ThemeContextProvider` / `ThemeProvider` /
`ThemeType`**: replaced across ~300 files with `themeCssVariables` (for
CSS contexts) or `resolveThemeVariable` / `resolveThemeVariableAsNumber`
(for JS runtime values)
- **Simplify provider chain**: only `ColorSchemeProvider` remains — it
toggles `light`/`dark` class on `document.documentElement` and provides
`colorScheme` via React context
- **Fix pre-existing test failures**: `useIcons.test.ts`
(non-configurable ES module spy) and
`turnRecordFilterGroupIntoGqlOperationFilter.test.ts`
(`Omit<RecordFilter, 'id'>` type mismatch)
### Theme access pattern (before → after)
| Context | Before | After |
|---------|--------|-------|
| CSS (Linaria) | `${({ theme }) => theme.font.color.primary}` |
`${themeCssVariables.font.color.primary}` |
| JS runtime (icon size, animation) | `theme.icon.size.md` /
`ICON_SIZES.md` |
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.md)` |
| Color scheme check | `theme.name === 'dark'` |
`useContext(ColorSchemeContext).colorScheme === 'dark'` |
26 lines
844 B
TypeScript
26 lines
844 B
TypeScript
import { useContext } from 'react';
|
|
|
|
import IllustrationIconNumbersRaw from '@assets/icons/illustration-numbers.svg?react';
|
|
import { IllustrationIconWrapper } from '@ui/display/icon/components/IllustrationIconWrapper';
|
|
import { type IconComponentProps } from '@ui/display/icon/types/IconComponent';
|
|
import { ThemeContext } from '@ui/theme-constants';
|
|
|
|
type IllustrationIconNumbersProps = Pick<IconComponentProps, 'size'>;
|
|
|
|
export const IllustrationIconNumbers = (
|
|
props: IllustrationIconNumbersProps,
|
|
) => {
|
|
const { theme } = useContext(ThemeContext);
|
|
const size = props.size ?? theme.icon.size.lg;
|
|
return (
|
|
<IllustrationIconWrapper>
|
|
<IllustrationIconNumbersRaw
|
|
height={size}
|
|
width={size}
|
|
fill={theme.accent.accent3}
|
|
color={theme.accent.accent8}
|
|
/>
|
|
</IllustrationIconWrapper>
|
|
);
|
|
};
|