647c32ff3e
## Summary
- **Eliminate `ICON_SIZES` / `ICON_STROKES` constants**: all icon
dimensions are now resolved at runtime via
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.X)`, ensuring
values always come from computed CSS variables
- **No more consumer imports from `twenty-ui/theme`**: moved
`ColorSchemeContext`, `ColorSchemeProvider`, `ThemeColor`,
`MAIN_COLOR_NAMES`, `getNextThemeColor`, `AnimationDuration` to
`twenty-ui/theme-constants`
- **Remove `ThemeContext` / `ThemeContextProvider` / `ThemeProvider` /
`ThemeType`**: replaced across ~300 files with `themeCssVariables` (for
CSS contexts) or `resolveThemeVariable` / `resolveThemeVariableAsNumber`
(for JS runtime values)
- **Simplify provider chain**: only `ColorSchemeProvider` remains — it
toggles `light`/`dark` class on `document.documentElement` and provides
`colorScheme` via React context
- **Fix pre-existing test failures**: `useIcons.test.ts`
(non-configurable ES module spy) and
`turnRecordFilterGroupIntoGqlOperationFilter.test.ts`
(`Omit<RecordFilter, 'id'>` type mismatch)
### Theme access pattern (before → after)
| Context | Before | After |
|---------|--------|-------|
| CSS (Linaria) | `${({ theme }) => theme.font.color.primary}` |
`${themeCssVariables.font.color.primary}` |
| JS runtime (icon size, animation) | `theme.icon.size.md` /
`ICON_SIZES.md` |
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.md)` |
| Color scheme check | `theme.name === 'dark'` |
`useContext(ColorSchemeContext).colorScheme === 'dark'` |
111 lines
3.0 KiB
TypeScript
111 lines
3.0 KiB
TypeScript
import { Dropdown } from '@/ui/layout/dropdown/components/Dropdown';
|
|
import { type Placement } from '@floating-ui/react';
|
|
import {
|
|
type FunctionComponent,
|
|
type MouseEvent,
|
|
type ReactElement,
|
|
type ReactNode,
|
|
useContext,
|
|
} from 'react';
|
|
import {
|
|
IconChevronRight,
|
|
type IconComponent,
|
|
IconDotsVertical,
|
|
} from 'twenty-ui/display';
|
|
import { LightIconButton, type LightIconButtonProps } from 'twenty-ui/input';
|
|
import {
|
|
type MenuItemAccent,
|
|
MenuItemLeftContent,
|
|
StyledHoverableMenuItemBase,
|
|
StyledMenuItemLeftContent,
|
|
} from 'twenty-ui/navigation';
|
|
import { ThemeContext } from 'twenty-ui/theme-constants';
|
|
|
|
export type MenuItemIconButton = {
|
|
Wrapper?: FunctionComponent<{ iconButton: ReactElement }>;
|
|
Icon: IconComponent;
|
|
accent?: LightIconButtonProps['accent'];
|
|
onClick?: (event: MouseEvent<any>) => void;
|
|
};
|
|
|
|
export type MenuItemWithOptionDropdownProps = {
|
|
accent?: MenuItemAccent;
|
|
className?: string;
|
|
dropdownContent: ReactNode;
|
|
dropdownId: string;
|
|
isIconDisplayedOnHoverOnly?: boolean;
|
|
isTooltipOpen?: boolean;
|
|
LeftIcon?: IconComponent | null;
|
|
RightIcon?: IconComponent | null;
|
|
onClick?: (event: MouseEvent<HTMLDivElement>) => void;
|
|
onMouseEnter?: (event: MouseEvent<HTMLDivElement>) => void;
|
|
onMouseLeave?: (event: MouseEvent<HTMLDivElement>) => void;
|
|
testId?: string;
|
|
text: ReactNode;
|
|
hasSubMenu?: boolean;
|
|
dropdownPlacement?: Placement;
|
|
};
|
|
|
|
// TODO: refactor this
|
|
export const MenuItemWithOptionDropdown = ({
|
|
accent = 'default',
|
|
className,
|
|
isIconDisplayedOnHoverOnly = true,
|
|
dropdownContent,
|
|
dropdownId,
|
|
LeftIcon,
|
|
RightIcon,
|
|
onClick,
|
|
onMouseEnter,
|
|
onMouseLeave,
|
|
testId,
|
|
text,
|
|
hasSubMenu = false,
|
|
dropdownPlacement = 'bottom-end',
|
|
}: MenuItemWithOptionDropdownProps) => {
|
|
const { theme } = useContext(ThemeContext);
|
|
const handleMenuItemClick = (event: MouseEvent<HTMLDivElement>) => {
|
|
if (!onClick) return;
|
|
event.preventDefault();
|
|
event.stopPropagation();
|
|
|
|
onClick?.(event);
|
|
};
|
|
|
|
return (
|
|
<StyledHoverableMenuItemBase
|
|
data-testid={testId ?? undefined}
|
|
onClick={handleMenuItemClick}
|
|
className={className}
|
|
accent={accent}
|
|
isIconDisplayedOnHoverOnly={isIconDisplayedOnHoverOnly}
|
|
onMouseEnter={onMouseEnter}
|
|
onMouseLeave={onMouseLeave}
|
|
>
|
|
<StyledMenuItemLeftContent>
|
|
<MenuItemLeftContent LeftIcon={LeftIcon ?? undefined} text={text} />
|
|
</StyledMenuItemLeftContent>
|
|
<div className="hoverable-buttons">
|
|
<Dropdown
|
|
clickableComponent={
|
|
<LightIconButton
|
|
Icon={RightIcon ?? IconDotsVertical}
|
|
size="small"
|
|
accent="tertiary"
|
|
/>
|
|
}
|
|
dropdownPlacement={dropdownPlacement}
|
|
dropdownComponents={dropdownContent}
|
|
dropdownId={dropdownId}
|
|
/>
|
|
</div>
|
|
{hasSubMenu && (
|
|
<IconChevronRight
|
|
size={theme.icon.size.sm}
|
|
color={theme.font.color.tertiary}
|
|
/>
|
|
)}
|
|
</StyledHoverableMenuItemBase>
|
|
);
|
|
};
|