Charles Bochet
3bfdc2c83f
## Summary
Continues the Emotion → Linaria migration (PR 4-6 from the [migration
plan](docs/emotion-to-linaria-migration-plan.md)). Migrates **311
files** across four module groups:
| Module | Files |
|---|---|
| command-menu | 53 |
| workflow | 84 |
| page-layout | 84 |
| UI (partial - first ~80 files) | ~80 |
| twenty-ui (TEXT_INPUT_STYLE) | 1 |
| misc (hooks, keyboard-shortcut-menu, file-upload) | ~9 |
### Migration patterns applied
- `import styled from '@emotion/styled'` → `import { styled } from
'@linaria/react'`
- `import { useTheme } from '@emotion/react'` → `import { useContext }
from 'react'` + `import { ThemeContext } from 'twenty-ui/theme'`
- `${({ theme }) => theme.X.Y.Z}` → `${themeCssVariables.X.Y.Z}` (static
CSS variables)
- `theme.spacing(N)` → `themeCssVariables.spacing[N]`
- `styled(motion.div)` → `motion.create(StyledBase)` (11 components)
- `styled(Component)<TypeParams>` → wrapper div approach for non-HTML
elements
- Multi-declaration interpolations split into one CSS property per
interpolation
- Interpolation return types fixed (`&&` → ternary `? : ''`)
- `TEXT_INPUT_STYLE` converted from function to static string constant
(backward compatible)
- Emotion `<Global>` replaced with `useEffect` style injection
- Complex runtime-dependent styles use CSS custom properties via
`style={}` prop
### After this PR
- **Remaining files**: ~400 (object-record: ~160, settings: ~200, UI:
~44)
- **No breaking changes**: CSS variables resolve identically to the
previous Emotion theme values
78 lines
1.9 KiB
TypeScript
78 lines
1.9 KiB
TypeScript
import { DROPDOWN_MENU_ITEMS_CONTAINER_MAX_HEIGHT } from '@/ui/layout/dropdown/constants/DropdownMenuItemsContainerMaxHeight';
|
|
import { styled } from '@linaria/react';
|
|
import { themeCssVariables } from 'twenty-ui/theme-constants';
|
|
|
|
const StyledExternalContainer = styled.div<{
|
|
maxHeight?: number;
|
|
}>`
|
|
--padding: ${themeCssVariables.spacing[1]};
|
|
|
|
align-items: flex-start;
|
|
display: flex;
|
|
|
|
flex-direction: column;
|
|
max-height: ${({ maxHeight }) => (maxHeight ? `${maxHeight}px` : 'none')};
|
|
|
|
width: 100%;
|
|
|
|
height: fit-content;
|
|
|
|
padding: var(--padding);
|
|
box-sizing: border-box;
|
|
`;
|
|
|
|
const StyledScrollableContainer = styled.div<{ maxHeight?: number }>`
|
|
box-sizing: border-box;
|
|
|
|
display: flex;
|
|
max-height: ${({ maxHeight }) => (maxHeight ? `${maxHeight}px` : 'none')};
|
|
width: 100%;
|
|
|
|
overflow-y: auto;
|
|
scrollbar-color: ${themeCssVariables.border.color.medium} transparent;
|
|
scrollbar-width: 4px;
|
|
|
|
*::-webkit-scrollbar-thumb {
|
|
border-radius: ${themeCssVariables.border.radius.sm};
|
|
}
|
|
`;
|
|
|
|
const StyledInternalContainer = styled.div`
|
|
display: flex;
|
|
|
|
flex-direction: column;
|
|
gap: 2px;
|
|
|
|
height: 100%;
|
|
width: 100%;
|
|
`;
|
|
|
|
export const DropdownMenuItemsContainer = ({
|
|
children,
|
|
hasMaxHeight,
|
|
scrollable = true,
|
|
className,
|
|
}: {
|
|
children: React.ReactNode;
|
|
hasMaxHeight?: boolean;
|
|
scrollable?: boolean;
|
|
className?: string;
|
|
}) => {
|
|
return scrollable === true ? (
|
|
<StyledScrollableContainer
|
|
className={className}
|
|
maxHeight={
|
|
hasMaxHeight ? DROPDOWN_MENU_ITEMS_CONTAINER_MAX_HEIGHT : undefined
|
|
}
|
|
>
|
|
<StyledExternalContainer role="listbox">
|
|
<StyledInternalContainer>{children}</StyledInternalContainer>
|
|
</StyledExternalContainer>
|
|
</StyledScrollableContainer>
|
|
) : (
|
|
<StyledExternalContainer role="listbox" className={className}>
|
|
<StyledInternalContainer>{children}</StyledInternalContainer>
|
|
</StyledExternalContainer>
|
|
);
|
|
};
|