Files
twenty/packages/twenty-front/src/modules/page-layout/components/PageLayoutTabMenuItemSelectAvatar.tsx
T
Charles Bochet 647c32ff3e Deprecate runtime theme objects in favor of CSS variables (#18402)
## Summary

- **Eliminate `ICON_SIZES` / `ICON_STROKES` constants**: all icon
dimensions are now resolved at runtime via
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.X)`, ensuring
values always come from computed CSS variables
- **No more consumer imports from `twenty-ui/theme`**: moved
`ColorSchemeContext`, `ColorSchemeProvider`, `ThemeColor`,
`MAIN_COLOR_NAMES`, `getNextThemeColor`, `AnimationDuration` to
`twenty-ui/theme-constants`
- **Remove `ThemeContext` / `ThemeContextProvider` / `ThemeProvider` /
`ThemeType`**: replaced across ~300 files with `themeCssVariables` (for
CSS contexts) or `resolveThemeVariable` / `resolveThemeVariableAsNumber`
(for JS runtime values)
- **Simplify provider chain**: only `ColorSchemeProvider` remains — it
toggles `light`/`dark` class on `document.documentElement` and provides
`colorScheme` via React context
- **Fix pre-existing test failures**: `useIcons.test.ts`
(non-configurable ES module spy) and
`turnRecordFilterGroupIntoGqlOperationFilter.test.ts`
(`Omit<RecordFilter, 'id'>` type mismatch)

### Theme access pattern (before → after)

| Context | Before | After |
|---------|--------|-------|
| CSS (Linaria) | `${({ theme }) => theme.font.color.primary}` |
`${themeCssVariables.font.color.primary}` |
| JS runtime (icon size, animation) | `theme.icon.size.md` /
`ICON_SIZES.md` |
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.md)` |
| Color scheme check | `theme.name === 'dark'` |
`useContext(ColorSchemeContext).colorScheme === 'dark'` |
2026-03-05 14:39:01 +01:00

91 lines
2.5 KiB
TypeScript

import { styled } from '@linaria/react';
import { type MouseEvent, useContext, useState } from 'react';
import { TabAvatar } from '@/ui/layout/tab-list/components/TabAvatar';
import { type SingleTabProps } from '@/ui/layout/tab-list/types/SingleTabProps';
import { IconPencil } from 'twenty-ui/display';
import { LightIconButton } from 'twenty-ui/input';
import {
StyledHoverableMenuItemBase,
StyledMenuItemIconCheck,
StyledMenuItemLabel,
StyledMenuItemLeftContent,
} from 'twenty-ui/navigation';
import { themeCssVariables, ThemeContext } from 'twenty-ui/theme-constants';
const StyledTextContainer = styled.div`
display: flex;
align-items: center;
flex: 1 0 0;
gap: ${themeCssVariables.spacing[1]};
max-width: 100%;
text-overflow: ellipsis;
overflow: hidden;
`;
const StyledRightContent = styled.div`
display: flex;
align-items: center;
gap: ${themeCssVariables.spacing[1]};
`;
type PageLayoutTabMenuItemSelectAvatarProps = {
tab: SingleTabProps;
selected: boolean;
onClick?: (event?: MouseEvent) => void;
disabled?: boolean;
showEditButton?: boolean;
onEditClick?: (tabId: string) => void;
testId?: string;
};
export const PageLayoutTabMenuItemSelectAvatar = ({
tab,
selected,
onClick,
disabled,
showEditButton = false,
onEditClick,
testId,
}: PageLayoutTabMenuItemSelectAvatarProps) => {
const { theme } = useContext(ThemeContext);
const [isHovered, setIsHovered] = useState(false);
return (
<StyledHoverableMenuItemBase
onClick={onClick}
disabled={disabled}
data-testid={testId}
role="option"
aria-selected={selected}
aria-disabled={disabled}
isIconDisplayedOnHoverOnly={showEditButton}
onMouseEnter={() => setIsHovered(true)}
onMouseLeave={() => setIsHovered(false)}
>
<StyledMenuItemLeftContent>
<TabAvatar tab={tab} />
<StyledTextContainer>
<StyledMenuItemLabel>{tab.title}</StyledMenuItemLabel>
</StyledTextContainer>
</StyledMenuItemLeftContent>
<StyledRightContent>
{selected && !isHovered && (
<StyledMenuItemIconCheck size={theme.icon.size.md} />
)}
{isHovered && showEditButton && (
<div className="hoverable-buttons">
<LightIconButton
Icon={IconPencil}
size="small"
accent="tertiary"
onClick={() => onEditClick?.(tab.id)}
/>
</div>
)}
</StyledRightContent>
</StyledHoverableMenuItemBase>
);
};