Charles Bochet
647c32ff3e
## Summary
- **Eliminate `ICON_SIZES` / `ICON_STROKES` constants**: all icon
dimensions are now resolved at runtime via
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.X)`, ensuring
values always come from computed CSS variables
- **No more consumer imports from `twenty-ui/theme`**: moved
`ColorSchemeContext`, `ColorSchemeProvider`, `ThemeColor`,
`MAIN_COLOR_NAMES`, `getNextThemeColor`, `AnimationDuration` to
`twenty-ui/theme-constants`
- **Remove `ThemeContext` / `ThemeContextProvider` / `ThemeProvider` /
`ThemeType`**: replaced across ~300 files with `themeCssVariables` (for
CSS contexts) or `resolveThemeVariable` / `resolveThemeVariableAsNumber`
(for JS runtime values)
- **Simplify provider chain**: only `ColorSchemeProvider` remains — it
toggles `light`/`dark` class on `document.documentElement` and provides
`colorScheme` via React context
- **Fix pre-existing test failures**: `useIcons.test.ts`
(non-configurable ES module spy) and
`turnRecordFilterGroupIntoGqlOperationFilter.test.ts`
(`Omit<RecordFilter, 'id'>` type mismatch)
### Theme access pattern (before → after)
| Context | Before | After |
|---------|--------|-------|
| CSS (Linaria) | `${({ theme }) => theme.font.color.primary}` |
`${themeCssVariables.font.color.primary}` |
| JS runtime (icon size, animation) | `theme.icon.size.md` /
`ICON_SIZES.md` |
`resolveThemeVariableAsNumber(themeCssVariables.icon.size.md)` |
| Color scheme check | `theme.name === 'dark'` |
`useContext(ColorSchemeContext).colorScheme === 'dark'` |
42 lines
1.1 KiB
TypeScript
42 lines
1.1 KiB
TypeScript
import { styled } from '@linaria/react';
|
|
import { useContext } from 'react';
|
|
import { type IconComponent } from 'twenty-ui/display';
|
|
import { ThemeContext, themeCssVariables } from 'twenty-ui/theme-constants';
|
|
|
|
const StyledContainer = styled.div<{ Variant: Variants }>`
|
|
color: ${({ Variant }) =>
|
|
Variant === 'danger' ? themeCssVariables.color.red : 'inherit'};
|
|
align-items: center;
|
|
display: flex;
|
|
flex-direction: row;
|
|
gap: ${themeCssVariables.spacing[2]};
|
|
`;
|
|
|
|
const StyledTextContainer = styled.div``;
|
|
|
|
type CustomSideMenuOptionsProps = {
|
|
LeftIcon: IconComponent; // Any valid React node (e.g., a component)
|
|
Variant: Variants;
|
|
text: string;
|
|
};
|
|
|
|
type Variants = 'normal' | 'danger';
|
|
|
|
export const CustomSideMenuOptions = ({
|
|
LeftIcon,
|
|
Variant,
|
|
text,
|
|
}: CustomSideMenuOptionsProps) => {
|
|
const { theme } = useContext(ThemeContext);
|
|
|
|
return (
|
|
<StyledContainer Variant={Variant}>
|
|
<LeftIcon
|
|
size={theme.icon.size.md}
|
|
stroke={theme.icon.stroke.sm}
|
|
></LeftIcon>
|
|
<StyledTextContainer>{text}</StyledTextContainer>
|
|
</StyledContainer>
|
|
);
|
|
};
|