Charles Bochet
c4140f85df
## Emotion → Linaria migration — PR 1 of 10
First batch of the `twenty-front` migration from Emotion (runtime
CSS-in-JS) to Linaria (zero-runtime, build-time extraction via
wyw-in-js). Covers **100 files** across 10 small standalone modules —
chosen as the lowest-risk starting point.
### Modules migrated
spreadsheet-import (28) · navigation-menu-item (17) · views (14) ·
billing (10) · blocknote-editor (7) · advanced-text-editor (7) ·
favorites (7) · navigation (4) · information-banner (3) ·
sign-in-background-mock (3)
### Migration pattern
Every file follows the same mechanical transformation:
| Emotion | Linaria |
|---|---|
| `import styled from '@emotion/styled'` | `import { styled } from
'@linaria/react'` |
| `${({ theme }) => theme.font.color.primary}` |
`${themeCssVariables.font.color.primary}` |
| `${({ theme }) => theme.spacing(4)}` |
`${themeCssVariables.spacing[4]}` |
| `const theme = useTheme()` | `const { theme } =
useContext(ThemeContext)` |
| `import { type Theme } from '@emotion/react'` | `import { type
ThemeType } from 'twenty-ui/theme'` |
`themeCssVariables` is a build-time object where every leaf is a
`var(--t-xxx)` CSS custom property reference, evaluated statically by
wyw-in-js. Runtime theme access (icon sizes, colors passed as props)
uses `useContext(ThemeContext)`.
### Gotchas encountered & fixed
- **Interpolation return types** — wyw-in-js requires `string | number`,
never `false`/`undefined`. Replaced `condition && 'css'` with `condition
? 'css' : ''`.
- **`css` tag inside `styled` templates** — Linaria `css` returns a
class name, not CSS text. Replaced with plain template strings.
- **`styled(Component)` needs `className`** — added `className` prop to
`NavigationDrawerSection`, `DropdownMenuItemsContainer`, and `Heading`.
- **`shouldForwardProp` not supported** — Linaria filters invalid DOM
props automatically for HTML elements. For custom components, used
wrapper divs where needed.
- **`FormFieldPlaceholderStyles`** — converted from Emotion `css`
function to a static string using `themeCssVariables`.
91 lines
2.9 KiB
TypeScript
91 lines
2.9 KiB
TypeScript
import { styled } from '@linaria/react';
|
|
import { autoUpdate, useFloating } from '@floating-ui/react';
|
|
import { motion } from 'framer-motion';
|
|
import { type MouseEvent as ReactMouseEvent } from 'react';
|
|
import { createPortal } from 'react-dom';
|
|
|
|
import { MENTION_MENU_DROPDOWN_CLICK_OUTSIDE_ID } from '@/ui/input/constants/MentionMenuDropdownClickOutsideId';
|
|
import { MentionMenuListItem } from '@/mention/components/MentionMenuListItem';
|
|
import {
|
|
type CustomMentionMenuProps,
|
|
type MentionItem,
|
|
} from '@/blocknote-editor/types/types';
|
|
import { DropdownContent } from '@/ui/layout/dropdown/components/DropdownContent';
|
|
import { DropdownMenuItemsContainer } from '@/ui/layout/dropdown/components/DropdownMenuItemsContainer';
|
|
import { OverlayContainer } from '@/ui/layout/overlay/components/OverlayContainer';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
export type { MentionItem };
|
|
|
|
const MenuPixelWidth = 240;
|
|
|
|
const StyledContainer = styled.div`
|
|
height: 1px;
|
|
width: 1px;
|
|
`;
|
|
|
|
export const CustomMentionMenu = ({
|
|
items,
|
|
selectedIndex,
|
|
onItemClick,
|
|
}: CustomMentionMenuProps) => {
|
|
const { refs, floatingStyles } = useFloating({
|
|
placement: 'bottom-start',
|
|
whileElementsMounted: autoUpdate,
|
|
});
|
|
|
|
const handleContainerClick = (e: ReactMouseEvent) => {
|
|
e.stopPropagation();
|
|
};
|
|
|
|
if (!isDefined(items) || items.length === 0) {
|
|
return null;
|
|
}
|
|
|
|
const filteredItems = items.filter(
|
|
(item) =>
|
|
isDefined(item.recordId) &&
|
|
isDefined(item.objectNameSingular) &&
|
|
isDefined(item.objectMetadataId),
|
|
);
|
|
|
|
return (
|
|
<StyledContainer ref={refs.setReference}>
|
|
<>
|
|
{createPortal(
|
|
<motion.div
|
|
initial={{ opacity: 0 }}
|
|
animate={{ opacity: 1 }}
|
|
transition={{ duration: 0.1 }}
|
|
onClick={handleContainerClick}
|
|
>
|
|
<OverlayContainer
|
|
ref={refs.setFloating}
|
|
style={floatingStyles}
|
|
data-click-outside-id={MENTION_MENU_DROPDOWN_CLICK_OUTSIDE_ID}
|
|
>
|
|
<DropdownContent widthInPixels={MenuPixelWidth}>
|
|
<DropdownMenuItemsContainer hasMaxHeight>
|
|
{filteredItems.map((item, index) => (
|
|
<MentionMenuListItem
|
|
key={item.recordId!}
|
|
recordId={item.recordId!}
|
|
objectNameSingular={item.objectNameSingular!}
|
|
label={item.label ?? item.title}
|
|
imageUrl={item.imageUrl ?? ''}
|
|
objectLabelSingular={item.objectLabelSingular ?? ''}
|
|
isSelected={index === selectedIndex}
|
|
onClick={() => onItemClick?.(item)}
|
|
/>
|
|
))}
|
|
</DropdownMenuItemsContainer>
|
|
</DropdownContent>
|
|
</OverlayContainer>
|
|
</motion.div>,
|
|
document.body,
|
|
)}
|
|
</>
|
|
</StyledContainer>
|
|
);
|
|
};
|