Weiko
9f30915f6f
## Context Follow-up to #21228, which deprecated `isCustom` on object/field metadata but kept it exposed because the frontend still relied on it. This removes it from the GraphQL API and the frontend entirely. ## Implementation ### Server - Remove `isCustom` `@Field` from the `Object`, `Field`, and `MinimalObjectMetadata` GraphQL types - Remove the `isCustom` `@ResolveField` resolvers and the `isCustomLoader` dataloader (+ payload/interface) - Remove `isCustom` as an internal `@HideField()` on the Object/Field DTOs used by the i18n standard-override gate > Use an explicit isStandard instead (which is the correct gating) ### Frontend - Add `getIsMetadataItemCustom` helper + `useGetIsMetadataItemCustom` hook: an item is custom when `applicationId === currentWorkspace.workspaceCustomApplication.id` - Migrate all consumers off `objectMetadataItem.isCustom` / `fieldMetadataItem.isCustom`; `isRecordFieldReadOnly` now takes a precomputed `isFieldCustom` - Drop `isCustom` from the metadata fragment/mutations/minimal query, FE types, zod schemas, and mock generators; regenerate GraphQL types ## Notes - Breaking change on the (already-deprecated) `Object.isCustom` / `Field.isCustom` GraphQL fields and the `isCustom` filter - FE semantic is "belongs to the workspace custom app" (third-party-app objects/fields are treated as non-custom) - `isCustom` on IndexMetadata / View / Skill / Agent is a separate column and is untouched - Breaking changes on REST metadata API
26 lines
915 B
TypeScript
26 lines
915 B
TypeScript
import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
|
|
import { getIsMetadataItemCustom } from '@/object-metadata/utils/getIsMetadataItemCustom';
|
|
|
|
import { parseDate } from '~/utils/date-utils';
|
|
|
|
export const sortFieldMetadataItem = (
|
|
a: FieldMetadataItem,
|
|
b: FieldMetadataItem,
|
|
workspaceCustomApplicationId?: string | null,
|
|
) => {
|
|
const aIsCustom = getIsMetadataItemCustom(a, workspaceCustomApplicationId);
|
|
const bIsCustom = getIsMetadataItemCustom(b, workspaceCustomApplicationId);
|
|
|
|
const customCompare = aIsCustom === bIsCustom ? 0 : aIsCustom ? 1 : -1;
|
|
if (customCompare !== 0) return customCompare;
|
|
|
|
const dateA = a.createdAt ? parseDate(a.createdAt) : null;
|
|
const dateB = b.createdAt ? parseDate(b.createdAt) : null;
|
|
|
|
if (!dateA && !dateB) return 0;
|
|
if (!dateA) return 1;
|
|
if (!dateB) return -1;
|
|
|
|
return dateB.getTime() - dateA.getTime() > 0 ? -1 : 1;
|
|
};
|