Félix Malfait
c3dd6b25a6
## What Many `oxlint-disable` / `eslint-disable` directives across the repo carry a corrupted rule id — `@typescripttypescript/<rule>` — most likely a find-and-replace accident that mangled the eslint-era `@typescript-eslint/` prefix. oxlint matches disable directives **loosely by rule name**, so these still suppress in practice (not a silent no-op), but the id is malformed and misleading. ## Change Replace them with the **canonical oxlint id** `typescript/<rule>` — matching the plugin name and rule keys declared in `.oxlintrc.json` — **127 files, 262 directives**: | rule | count | | --- | ----- | | `typescript/no-explicit-any` | 250 | | `typescript/ban-ts-comment` | 6 | | `typescript/no-misused-promises` | 4 | | `typescript/no-empty-object-type` | 2 | - `twenty-server`: 122 files - `twenty-front`: 5 files Comment-only — no code or runtime changes. ## Verification `oxlint --type-aware -c .oxlintrc.json` reports **0 warnings / 0 errors** for both `twenty-server` and `twenty-front`. Every changed line is exactly the id correction inside a disable directive (262 insertions / 262 deletions, no collateral edits). > Addresses the cubic review, which flagged that the canonical oxlint id is `typescript/...` (no `@`). Worth noting the original `@typescripttypescript/` was not actually a silent no-op — oxlint matches these directives loosely by rule name — but `typescript/` is the correct, config-aligned id.
54 lines
1.5 KiB
TypeScript
54 lines
1.5 KiB
TypeScript
import { Logger } from '@nestjs/common';
|
|
|
|
interface CommandLoggerOptions {
|
|
verbose?: boolean;
|
|
constructorName: string;
|
|
}
|
|
|
|
export const isCommandLogger = (
|
|
logger: Logger | CommandLogger,
|
|
): logger is CommandLogger => {
|
|
// @ts-expect-error legacy noImplicitAny
|
|
return typeof logger['setVerbose'] === 'function';
|
|
};
|
|
|
|
export class CommandLogger {
|
|
private logger: Logger;
|
|
private verboseFlag: boolean;
|
|
|
|
constructor(options: CommandLoggerOptions) {
|
|
this.logger = new Logger(options.constructorName);
|
|
this.verboseFlag = options.verbose ?? false;
|
|
}
|
|
|
|
// oxlint-disable-next-line typescript/no-explicit-any
|
|
log(message: string, ...optionalParams: [...any, string?]) {
|
|
this.logger.log(message, ...optionalParams);
|
|
}
|
|
|
|
error(message: string, stack?: string, context?: string) {
|
|
this.logger.error(message, stack, context);
|
|
}
|
|
|
|
// oxlint-disable-next-line typescript/no-explicit-any
|
|
warn(message: string, ...optionalParams: [...any, string?]) {
|
|
this.logger.warn(message, ...optionalParams);
|
|
}
|
|
|
|
// oxlint-disable-next-line typescript/no-explicit-any
|
|
debug(message: string, ...optionalParams: [...any, string?]) {
|
|
this.logger.debug(message, ...optionalParams);
|
|
}
|
|
|
|
// oxlint-disable-next-line typescript/no-explicit-any
|
|
verbose(message: string, ...optionalParams: [...any, string?]) {
|
|
if (this.verboseFlag) {
|
|
this.logger.log(message, ...optionalParams);
|
|
}
|
|
}
|
|
|
|
setVerbose(flag: boolean) {
|
|
this.verboseFlag = flag;
|
|
}
|
|
}
|