Félix Malfait
514d0017ea
## Summary - **Module reorganization**: Moved `ApplicationUpgradeService` and cron jobs to `application-upgrade/`, `ApplicationSyncService` to `application-manifest/`, and `runWorkspaceMigration`/`uninstallApplication` mutations to the manifest resolver — each module now has a single clear responsibility. - **Explicit install flow**: Removed implicit `ApplicationEntity` creation from `ApplicationSyncService`. The install service and dev resolver now explicitly create the `ApplicationEntity` before syncing. npm packages are resolved at registration time to extract manifest metadata (universalIdentifier, name, description, etc.), eliminating the `reconcileUniversalIdentifier` hack. - **Better error handling**: Frontend hooks now surface actual server error messages in snackbars instead of swallowing them. Replaced the ugly `ConfirmationModal` for transfer ownership with a proper form modal. Fixed `SettingsAdminTableCard` row height overflow and corrected the `yarn-engine` asset path. ## Test plan - [ ] Register an npm package — verify manifest metadata (name, description, universalIdentifier) is extracted correctly - [ ] Install a registered npm app on a workspace — verify ApplicationEntity is created and sync succeeds - [ ] Test `app:dev` CLI flow — verify local app registration and sync work - [ ] Upload a tarball — verify registration and install flow - [ ] Transfer ownership — verify the new modal UX works - [ ] Verify error messages appear correctly in snackbars when operations fail Made with [Cursor](https://cursor.com)
106 lines
3.4 KiB
TypeScript
106 lines
3.4 KiB
TypeScript
import { expectOneNotInternalServerErrorSnapshot } from 'test/integration/graphql/utils/expect-one-not-internal-server-error-snapshot.util';
|
|
import { buildBaseManifest } from 'test/integration/metadata/suites/application/utils/build-base-manifest.util';
|
|
import { installApplication } from 'test/integration/metadata/suites/application/utils/install-application.util';
|
|
import { setupApplicationForSync } from 'test/integration/metadata/suites/application/utils/setup-application-for-sync.util';
|
|
import { syncApplication } from 'test/integration/metadata/suites/application/utils/sync-application.util';
|
|
import { uninstallApplication } from 'test/integration/metadata/suites/application/utils/uninstall-application.util';
|
|
import { updateFeatureFlag } from 'test/integration/metadata/suites/utils/update-feature-flag.util';
|
|
import { v4 as uuidv4 } from 'uuid';
|
|
import { FeatureFlagKey } from 'twenty-shared/types';
|
|
|
|
const INVALID_UUID_APP_ID = uuidv4();
|
|
const INVALID_UUID_ROLE_ID = uuidv4();
|
|
|
|
describe('Install application should fail when entity does not exist', () => {
|
|
beforeAll(async () => {
|
|
await updateFeatureFlag({
|
|
featureFlag:
|
|
FeatureFlagKey.IS_APPLICATION_INSTALLATION_FROM_TARBALL_ENABLED,
|
|
value: true,
|
|
expectToFail: false,
|
|
});
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await setupApplicationForSync({
|
|
applicationUniversalIdentifier: INVALID_UUID_APP_ID,
|
|
name: 'Test Invalid UUID App',
|
|
description: 'App for testing UUID v4 validation',
|
|
sourcePath: 'test-invalid-uuid',
|
|
});
|
|
}, 60000);
|
|
|
|
afterAll(async () => {
|
|
await updateFeatureFlag({
|
|
featureFlag:
|
|
FeatureFlagKey.IS_APPLICATION_INSTALLATION_FROM_TARBALL_ENABLED,
|
|
value: false,
|
|
expectToFail: false,
|
|
});
|
|
});
|
|
|
|
afterEach(async () => {
|
|
try {
|
|
await uninstallApplication({
|
|
universalIdentifier: INVALID_UUID_APP_ID,
|
|
expectToFail: false,
|
|
});
|
|
} catch {
|
|
// May fail if the test didn't install/sync
|
|
}
|
|
|
|
await globalThis.testDataSource.query(
|
|
`DELETE FROM core."file" WHERE "applicationId" IN (
|
|
SELECT id FROM core."application" WHERE "universalIdentifier" = $1
|
|
)`,
|
|
[INVALID_UUID_APP_ID],
|
|
);
|
|
|
|
await globalThis.testDataSource.query(
|
|
`DELETE FROM core."application"
|
|
WHERE "universalIdentifier" = $1`,
|
|
[INVALID_UUID_APP_ID],
|
|
);
|
|
|
|
await globalThis.testDataSource.query(
|
|
`DELETE FROM core."applicationRegistration"
|
|
WHERE "universalIdentifier" = $1`,
|
|
[INVALID_UUID_APP_ID],
|
|
);
|
|
});
|
|
|
|
it('should fail with execution error when installing non-existent app registration', async () => {
|
|
const { errors } = await installApplication({
|
|
expectToFail: true,
|
|
input: {
|
|
appRegistrationId: '20202020-0000-0000-0000-000000000000',
|
|
},
|
|
});
|
|
|
|
expectOneNotInternalServerErrorSnapshot({ errors });
|
|
});
|
|
|
|
it('should fail when a role has an invalid universalIdentifier', async () => {
|
|
const manifest = buildBaseManifest({
|
|
appId: INVALID_UUID_APP_ID,
|
|
roleId: INVALID_UUID_ROLE_ID,
|
|
overrides: {
|
|
roles: [
|
|
{
|
|
universalIdentifier: 'not-a-valid-uuid',
|
|
label: 'Invalid UUID Role',
|
|
description: 'Role with invalid universalIdentifier',
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
const { errors } = await syncApplication({
|
|
manifest,
|
|
expectToFail: true,
|
|
});
|
|
|
|
expectOneNotInternalServerErrorSnapshot({ errors });
|
|
}, 60000);
|
|
});
|