514d0017ea
## Summary - **Module reorganization**: Moved `ApplicationUpgradeService` and cron jobs to `application-upgrade/`, `ApplicationSyncService` to `application-manifest/`, and `runWorkspaceMigration`/`uninstallApplication` mutations to the manifest resolver — each module now has a single clear responsibility. - **Explicit install flow**: Removed implicit `ApplicationEntity` creation from `ApplicationSyncService`. The install service and dev resolver now explicitly create the `ApplicationEntity` before syncing. npm packages are resolved at registration time to extract manifest metadata (universalIdentifier, name, description, etc.), eliminating the `reconcileUniversalIdentifier` hack. - **Better error handling**: Frontend hooks now surface actual server error messages in snackbars instead of swallowing them. Replaced the ugly `ConfirmationModal` for transfer ownership with a proper form modal. Fixed `SettingsAdminTableCard` row height overflow and corrected the `yarn-engine` asset path. ## Test plan - [ ] Register an npm package — verify manifest metadata (name, description, universalIdentifier) is extracted correctly - [ ] Install a registered npm app on a workspace — verify ApplicationEntity is created and sync succeeds - [ ] Test `app:dev` CLI flow — verify local app registration and sync work - [ ] Upload a tarball — verify registration and install flow - [ ] Transfer ownership — verify the new modal UX works - [ ] Verify error messages appear correctly in snackbars when operations fail Made with [Cursor](https://cursor.com)
185 lines
8.8 KiB
TypeScript
185 lines
8.8 KiB
TypeScript
import { Logger } from '@nestjs/common';
|
|
|
|
import { Command, CommandRunner } from 'nest-commander';
|
|
|
|
import { ApplicationVersionCheckCronCommand } from 'src/engine/core-modules/application/application-upgrade/crons/commands/application-version-check.cron.command';
|
|
import { MarketplaceCatalogSyncCronCommand } from 'src/engine/core-modules/application/application-marketplace/crons/commands/marketplace-catalog-sync.cron.command';
|
|
import { EventLogCleanupCronCommand } from 'src/engine/core-modules/event-logs/cleanup/commands/event-log-cleanup.cron.command';
|
|
import { CheckPublicDomainsValidRecordsCronCommand } from 'src/engine/core-modules/public-domain/crons/commands/check-public-domains-valid-records.cron.command';
|
|
import { CheckCustomDomainValidRecordsCronCommand } from 'src/engine/core-modules/workspace/crons/commands/check-custom-domain-valid-records.cron.command';
|
|
import { CronTriggerCronCommand } from 'src/engine/core-modules/logic-function/logic-function-trigger/triggers/cron/cron-trigger.cron.command';
|
|
import { TrashCleanupCronCommand } from 'src/engine/trash-cleanup/commands/trash-cleanup.cron.command';
|
|
import { CleanOnboardingWorkspacesCronCommand } from 'src/engine/workspace-manager/workspace-cleaner/commands/clean-onboarding-workspaces.cron.command';
|
|
import { CleanSuspendedWorkspacesCronCommand } from 'src/engine/workspace-manager/workspace-cleaner/commands/clean-suspended-workspaces.cron.command';
|
|
import { CalendarEventListFetchCronCommand } from 'src/modules/calendar/calendar-event-import-manager/crons/commands/calendar-event-list-fetch.cron.command';
|
|
import { CalendarEventsImportCronCommand } from 'src/modules/calendar/calendar-event-import-manager/crons/commands/calendar-import.cron.command';
|
|
import { CalendarOngoingStaleCronCommand } from 'src/modules/calendar/calendar-event-import-manager/crons/commands/calendar-ongoing-stale.cron.command';
|
|
import { CalendarRelaunchFailedCalendarChannelsCronCommand } from 'src/modules/calendar/calendar-event-import-manager/crons/commands/calendar-relaunch-failed-calendar-channels.cron.command';
|
|
import { MessagingMessageListFetchCronCommand } from 'src/modules/messaging/message-import-manager/crons/commands/messaging-message-list-fetch.cron.command';
|
|
import { MessagingMessagesImportCronCommand } from 'src/modules/messaging/message-import-manager/crons/commands/messaging-messages-import.cron.command';
|
|
import { MessagingOngoingStaleCronCommand } from 'src/modules/messaging/message-import-manager/crons/commands/messaging-ongoing-stale.cron.command';
|
|
import { MessagingRelaunchFailedMessageChannelsCronCommand } from 'src/modules/messaging/message-import-manager/crons/commands/messaging-relaunch-failed-message-channels.cron.command';
|
|
import { WorkflowCleanWorkflowRunsCronCommand } from 'src/modules/workflow/workflow-runner/workflow-run-queue/cron/command/workflow-clean-workflow-runs.cron.command';
|
|
import { WorkflowHandleStaledRunsCronCommand } from 'src/modules/workflow/workflow-runner/workflow-run-queue/cron/command/workflow-handle-staled-runs.cron.command';
|
|
import { WorkflowRunEnqueueCronCommand } from 'src/modules/workflow/workflow-runner/workflow-run-queue/cron/command/workflow-run-enqueue.cron.command';
|
|
import { WorkflowCronTriggerCronCommand } from 'src/modules/workflow/workflow-trigger/automated-trigger/crons/commands/workflow-cron-trigger.cron.command';
|
|
|
|
@Command({
|
|
name: 'cron:register:all',
|
|
description: 'Register all background sync cron jobs',
|
|
})
|
|
export class CronRegisterAllCommand extends CommandRunner {
|
|
private readonly logger = new Logger(CronRegisterAllCommand.name);
|
|
|
|
constructor(
|
|
private readonly messagingMessagesImportCronCommand: MessagingMessagesImportCronCommand,
|
|
private readonly messagingMessageListFetchCronCommand: MessagingMessageListFetchCronCommand,
|
|
private readonly messagingOngoingStaleCronCommand: MessagingOngoingStaleCronCommand,
|
|
private readonly messagingRelaunchFailedMessageChannelsCronCommand: MessagingRelaunchFailedMessageChannelsCronCommand,
|
|
|
|
private readonly calendarEventListFetchCronCommand: CalendarEventListFetchCronCommand,
|
|
private readonly calendarEventsImportCronCommand: CalendarEventsImportCronCommand,
|
|
private readonly calendarOngoingStaleCronCommand: CalendarOngoingStaleCronCommand,
|
|
private readonly calendarRelaunchFailedCalendarChannelsCronCommand: CalendarRelaunchFailedCalendarChannelsCronCommand,
|
|
|
|
private readonly workflowCronTriggerCronCommand: WorkflowCronTriggerCronCommand,
|
|
private readonly workflowRunEnqueueCronCommand: WorkflowRunEnqueueCronCommand,
|
|
private readonly workflowHandleStaledRunsCronCommand: WorkflowHandleStaledRunsCronCommand,
|
|
private readonly workflowCleanWorkflowRunsCronCommand: WorkflowCleanWorkflowRunsCronCommand,
|
|
|
|
private readonly checkCustomDomainValidRecordsCronCommand: CheckCustomDomainValidRecordsCronCommand,
|
|
private readonly checkPublicDomainsValidRecordsCronCommand: CheckPublicDomainsValidRecordsCronCommand,
|
|
private readonly cronTriggerCronCommand: CronTriggerCronCommand,
|
|
private readonly cleanSuspendedWorkspacesCronCommand: CleanSuspendedWorkspacesCronCommand,
|
|
private readonly cleanOnboardingWorkspacesCronCommand: CleanOnboardingWorkspacesCronCommand,
|
|
private readonly trashCleanupCronCommand: TrashCleanupCronCommand,
|
|
private readonly eventLogCleanupCronCommand: EventLogCleanupCronCommand,
|
|
private readonly marketplaceCatalogSyncCronCommand: MarketplaceCatalogSyncCronCommand,
|
|
private readonly applicationVersionCheckCronCommand: ApplicationVersionCheckCronCommand,
|
|
) {
|
|
super();
|
|
}
|
|
|
|
async run(): Promise<void> {
|
|
this.logger.log('Registering all background sync cron jobs...');
|
|
|
|
const commands = [
|
|
{
|
|
name: 'MessagingMessagesImport',
|
|
command: this.messagingMessagesImportCronCommand,
|
|
},
|
|
{
|
|
name: 'MessagingMessageListFetch',
|
|
command: this.messagingMessageListFetchCronCommand,
|
|
},
|
|
{
|
|
name: 'MessagingOngoingStale',
|
|
command: this.messagingOngoingStaleCronCommand,
|
|
},
|
|
{
|
|
name: 'MessagingRelaunchFailedMessageChannels',
|
|
command: this.messagingRelaunchFailedMessageChannelsCronCommand,
|
|
},
|
|
{
|
|
name: 'CalendarEventListFetch',
|
|
command: this.calendarEventListFetchCronCommand,
|
|
},
|
|
{
|
|
name: 'CalendarEventsImport',
|
|
command: this.calendarEventsImportCronCommand,
|
|
},
|
|
{
|
|
name: 'CalendarOngoingStale',
|
|
command: this.calendarOngoingStaleCronCommand,
|
|
},
|
|
{
|
|
name: 'CalendarRelaunchFailedCalendarChannels',
|
|
command: this.calendarRelaunchFailedCalendarChannelsCronCommand,
|
|
},
|
|
{
|
|
name: 'CheckCustomDomainValidRecords',
|
|
command: this.checkCustomDomainValidRecordsCronCommand,
|
|
},
|
|
{
|
|
name: 'CheckPublicDomainsValidRecords',
|
|
command: this.checkPublicDomainsValidRecordsCronCommand,
|
|
},
|
|
{
|
|
name: 'WorkflowCronTrigger',
|
|
command: this.workflowCronTriggerCronCommand,
|
|
},
|
|
{
|
|
name: 'WorkflowRunEnqueue',
|
|
command: this.workflowRunEnqueueCronCommand,
|
|
},
|
|
{
|
|
name: 'WorkflowHandleStaledRuns',
|
|
command: this.workflowHandleStaledRunsCronCommand,
|
|
},
|
|
{
|
|
name: 'WorkflowCleanWorkflowRuns',
|
|
command: this.workflowCleanWorkflowRunsCronCommand,
|
|
},
|
|
{
|
|
name: 'CronTrigger',
|
|
command: this.cronTriggerCronCommand,
|
|
},
|
|
{
|
|
name: 'CleanSuspendedWorkspaces',
|
|
command: this.cleanSuspendedWorkspacesCronCommand,
|
|
},
|
|
{
|
|
name: 'CleanOnboardingWorkspaces',
|
|
command: this.cleanOnboardingWorkspacesCronCommand,
|
|
},
|
|
{
|
|
name: 'TrashCleanup',
|
|
command: this.trashCleanupCronCommand,
|
|
},
|
|
{
|
|
name: 'EventLogCleanup',
|
|
command: this.eventLogCleanupCronCommand,
|
|
},
|
|
{
|
|
name: 'MarketplaceCatalogSync',
|
|
command: this.marketplaceCatalogSyncCronCommand,
|
|
},
|
|
{
|
|
name: 'ApplicationVersionCheck',
|
|
command: this.applicationVersionCheckCronCommand,
|
|
},
|
|
];
|
|
|
|
let successCount = 0;
|
|
let failureCount = 0;
|
|
const failures: string[] = [];
|
|
const successes: string[] = [];
|
|
|
|
for (const { name, command } of commands) {
|
|
try {
|
|
this.logger.log(`Registering ${name} cron job...`);
|
|
await command.run();
|
|
this.logger.log(`Successfully registered ${name} cron job`);
|
|
successCount++;
|
|
successes.push(name);
|
|
} catch (error) {
|
|
this.logger.error(`Failed to register ${name} cron job:`, error);
|
|
failureCount++;
|
|
failures.push(name);
|
|
}
|
|
}
|
|
|
|
this.logger.log(
|
|
`Cron job registration completed: ${successCount} successful, ${failureCount} failed`,
|
|
);
|
|
|
|
if (failures.length > 0) {
|
|
this.logger.warn(`Failed commands: ${failures.join(', ')}`);
|
|
}
|
|
|
|
if (successCount > 0) {
|
|
this.logger.log(`Successful commands: ${successes.join(', ')}`);
|
|
}
|
|
}
|
|
}
|