Files
twenty/packages/twenty-server/test/integration/rest/suites/view.integration-spec.ts
T
Paul Rastoin c19a799973 Fix view rest api in v2 (#15398)
# Introduction
Initially wanted to reactive the test introduced in
https://github.com/twentyhq/twenty/pull/15393, that was failing because
of direct data source access removing all views ( even seeded one )
which was making the test fail

While doing so discovered a lot of issue with the rest API:
- Rest api wasn't consuming the v2 at all
- Rest api wasn't prepared to handle v2 exceptions
- Rest api did not handled unknown exceptions ( timeout )

Refactored the cleanup of each test to follow black box pattern and
avoid test leakage
2025-10-29 15:07:08 +01:00

291 lines
8.8 KiB
TypeScript

import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';
import { destroyOneCoreView } from 'test/integration/metadata/suites/view/utils/destroy-one-core-view.util';
import { makeRestAPIRequest } from 'test/integration/rest/utils/make-rest-api-request.util';
import {
assertRestApiErrorNotFoundResponse,
assertRestApiSuccessfulResponse,
} from 'test/integration/rest/utils/rest-test-assertions.util';
import { createTestViewWithRestApi } from 'test/integration/rest/utils/view-rest-api.util';
import { generateRecordName } from 'test/integration/utils/generate-record-name';
import { assertViewStructure } from 'test/integration/utils/view-test.util';
import { ViewKey } from 'src/engine/metadata-modules/view/enums/view-key.enum';
import { ViewOpenRecordIn } from 'src/engine/metadata-modules/view/enums/view-open-record-in';
import { ViewType } from 'src/engine/metadata-modules/view/enums/view-type.enum';
describe('View REST API', () => {
let testObjectMetadataId: string;
let testViewId: string | undefined;
beforeAll(async () => {
const {
data: {
createOneObject: { id: objectMetadataId },
},
} = await createOneObjectMetadata({
input: {
nameSingular: 'testViewObject',
namePlural: 'testViewObjects',
labelSingular: 'Test View Object',
labelPlural: 'Test View Objects',
icon: 'IconView',
},
});
testObjectMetadataId = objectMetadataId;
});
afterAll(async () => {
await updateOneObjectMetadata({
expectToFail: false,
input: {
idToUpdate: testObjectMetadataId,
updatePayload: {
isActive: false,
},
},
});
await deleteOneObjectMetadata({
input: { idToDelete: testObjectMetadataId },
});
});
afterEach(async () => {
if (!testViewId) return;
await destroyOneCoreView({
viewId: testViewId,
expectToFail: false,
});
testViewId = undefined;
});
describe('GET /metadata/views', () => {
it('should return all views for workspace', async () => {
const response = await makeRestAPIRequest({
method: 'get',
path: '/metadata/views',
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(response);
expect(Array.isArray(response.body)).toBe(true);
});
it('should return views filtered by objectMetadataId', async () => {
const response = await makeRestAPIRequest({
method: 'get',
path: `/metadata/views?objectMetadataId=${testObjectMetadataId}`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(response);
expect(Array.isArray(response.body)).toBe(true);
if (response.body.length > 0) {
assertViewStructure(response.body[0]);
}
});
});
describe('POST /metadata/views', () => {
it('should create a new view', async () => {
const viewName = generateRecordName('Test View');
const view = await createTestViewWithRestApi({
name: viewName,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
testViewId = view.id;
assertViewStructure(view, {
name: viewName,
objectMetadataId: testObjectMetadataId,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
});
});
it('should create a kanban view', async () => {
const viewName = generateRecordName('Test Kanban View');
const kanbanView = await createTestViewWithRestApi({
name: viewName,
icon: 'IconKanban',
type: ViewType.KANBAN,
key: null,
position: 1,
isCompact: true,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
testViewId = kanbanView.id;
assertViewStructure(kanbanView, {
name: viewName,
type: ViewType.KANBAN,
isCompact: true,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
});
});
describe('GET /metadata/views/:id', () => {
it('should return a view by id', async () => {
const viewName = generateRecordName('Test View for Get');
const view = await createTestViewWithRestApi({
name: viewName,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
testViewId = view.id;
const response = await makeRestAPIRequest({
method: 'get',
path: `/metadata/views/${view.id}`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(response);
assertViewStructure(response.body, {
id: view.id,
name: viewName,
objectMetadataId: testObjectMetadataId,
});
});
it('should return empty object for non-existent view', async () => {
const response = await makeRestAPIRequest({
method: 'get',
path: `/metadata/views/20202020-b7a4-4f8e-9c1d-2e3f4a5b6c7d`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiErrorNotFoundResponse(response);
});
});
describe('PATCH /metadata/views/:id', () => {
it('should update an existing view', async () => {
const viewName = generateRecordName('Test View for Update');
const view = await createTestViewWithRestApi({
name: viewName,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
testViewId = view.id;
const updatedName = generateRecordName('Updated View');
const updateData = {
name: updatedName,
type: ViewType.KANBAN,
isCompact: true,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
};
const response = await makeRestAPIRequest({
method: 'patch',
path: `/metadata/views/${view.id}`,
body: updateData,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(response);
assertViewStructure(response.body, {
id: view.id,
name: updatedName,
type: ViewType.KANBAN,
isCompact: true,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
});
it('should return 404 error when updating non-existent view', async () => {
const updateData = {
name: 'Updated View',
type: ViewType.KANBAN,
};
const response = await makeRestAPIRequest({
method: 'patch',
path: `/metadata/views/20202020-b7a4-4f8e-9c1d-2e3f4a5b6c7d`,
body: updateData,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiErrorNotFoundResponse(response);
});
});
describe('DELETE /metadata/views/:id', () => {
it('should delete an existing view', async () => {
const viewName = generateRecordName('Test View for Delete');
const view = await createTestViewWithRestApi({
name: viewName,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
testViewId = view.id;
const deleteResponse = await makeRestAPIRequest({
method: 'delete',
path: `/metadata/views/${view.id}`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(deleteResponse);
expect(deleteResponse.body.success).toBe(true);
const getResponse = await makeRestAPIRequest({
method: 'get',
path: `/metadata/views/${view.id}`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiErrorNotFoundResponse(getResponse);
});
it('should return 404 error when deleting non-existent view', async () => {
const response = await makeRestAPIRequest({
method: 'delete',
path: `/metadata/views/20202020-b7a4-4f8e-9c1d-2e3f4a5b6c7d`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiErrorNotFoundResponse(response);
});
});
});