Félix Malfait
44aee860d9
## Summary Clean up and consolidate formatting configuration across the monorepo. ## Changes ### 1. Remove Redundant Configs - ❌ Delete `packages/twenty-server/.prettierrc` (had invalid `brakeBeforeElse` typo) - ❌ Delete `packages/twenty-zapier/.prettierrc` - ✅ Use root `.prettierrc` only (Prettier searches up directory tree automatically) ### 2. Improve Root Prettier Config - Change `endOfLine: 'auto'` → `'lf'` for consistent Unix line endings across all OSes ### 3. Enhance VSCode Settings - `files.eol: 'auto'` → `'\\n'` (consistent with Prettier) - Add `files.insertFinalNewline: true` (explicit editor behavior) - Add `files.trimTrailingWhitespace: true` (cleaner files) ### 4. Add `.gitattributes` - Enforce LF line endings at Git level - Prevents `core.autocrlf` from converting based on contributor's OS - Mark patch files as binary (they have mixed line endings by design) - Explicitly define binary file types ### 5. Fix Line Endings - Convert 3 selectable-list state files from CRLF → LF - These were the only source files with Windows line endings ## Why These Changes Matter **Before:** - 3 different Prettier configs (inconsistent, one had typo) - Mixed CRLF/LF depending on contributor's OS - No Git-level enforcement **After:** - Single source of truth for formatting - All files use LF (Unix standard) - Git enforces line endings regardless of OS - Prettier warning about invalid option removed ## Result - ✅ Single `.prettierrc` config - ✅ Consistent LF line endings enforced by Git - ✅ Better VSCode defaults - ✅ No more CRLF files sneaking in from Windows contributors
139 lines
2.4 KiB
TypeScript
139 lines
2.4 KiB
TypeScript
import { TSESLint } from '@typescript-eslint/utils';
|
|
|
|
import { rule, RULE_NAME } from './rest-api-methods-should-be-guarded';
|
|
|
|
const ruleTester = new TSESLint.RuleTester({
|
|
parser: require.resolve('@typescript-eslint/parser'),
|
|
});
|
|
|
|
ruleTester.run(RULE_NAME, rule, {
|
|
valid: [
|
|
{
|
|
code: `
|
|
class TestController {
|
|
@Get()
|
|
@UseGuards(UserAuthGuard)
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
},
|
|
{
|
|
code: `
|
|
class TestController {
|
|
@Get()
|
|
@UseGuards(WorkspaceAuthGuard)
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
},
|
|
{
|
|
code: `
|
|
class TestController {
|
|
@Get()
|
|
@UseGuards(PublicEndpoint)
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
},
|
|
{
|
|
code: `
|
|
class TestController {
|
|
@Get()
|
|
@UseGuards(CaptchaGuard, PublicEndpoint)
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
},
|
|
{
|
|
code: `
|
|
@UseGuards(UserAuthGuard)
|
|
class TestController {
|
|
@Get()
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
},
|
|
{
|
|
code: `
|
|
@UseGuards(WorkspaceAuthGuard)
|
|
class TestController {
|
|
@Get()
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
},
|
|
{
|
|
code: `
|
|
@UseGuards(PublicEndpoint)
|
|
class TestController {
|
|
@Get()
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
},
|
|
{
|
|
code: `
|
|
class TestController {
|
|
regularMethod() {}
|
|
}
|
|
`,
|
|
},
|
|
],
|
|
invalid: [
|
|
{
|
|
code: `
|
|
class TestController {
|
|
@Get()
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
errors: [
|
|
{
|
|
messageId: 'restApiMethodsShouldBeGuarded',
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `
|
|
class TestController {
|
|
@Post()
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
errors: [
|
|
{
|
|
messageId: 'restApiMethodsShouldBeGuarded',
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `
|
|
class TestController {
|
|
@Get()
|
|
@UseGuards(CaptchaGuard)
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
errors: [
|
|
{
|
|
messageId: 'restApiMethodsShouldBeGuarded',
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `
|
|
@UseGuards(CaptchaGuard)
|
|
class TestController {
|
|
@Get()
|
|
testMethod() {}
|
|
}
|
|
`,
|
|
errors: [
|
|
{
|
|
messageId: 'restApiMethodsShouldBeGuarded',
|
|
},
|
|
],
|
|
},
|
|
],
|
|
});
|