Files
twenty/packages/twenty-server/test/integration/metadata/suites/view/update-one-view-view-groups-side-effect-v2.integration-spec.ts
T
Charles Bochet 5c745059ad refactor: remove "core" naming from views and eliminate converter layer (#18667)
## Summary

- **Remove all "core" prefixes** from the views system — the
metadata-based storage migration is complete, so `CoreView`,
`coreViewsSelector`, `getCoreViews`, etc. are now just `View`,
`viewsSelector`, `getViews`
- **Eliminate the entire converter layer** (15 files, ~850 lines
deleted) — `convertCoreViewToView` and all sub-converters were either
no-ops or trivially adding `__typename` / mapping identical enum values.
Local enums now re-export from generated GraphQL types directly (single
source of truth)
- **Unify `View` and `ViewWithRelations`** into one type —
`ViewWithRelations` is now a type alias for `View`, selectors return
data directly without conversion

### Backend
- Rename `@ObjectType('CoreView')` → `@ObjectType('View')` (and all
sub-entities)
- Rename resolver methods: `getCoreViews` → `getViews`, `createCoreView`
→ `createView`, etc.
- Rename `FIND_ALL_CORE_VIEWS_GRAPHQL_OPERATION` →
`FIND_ALL_VIEWS_GRAPHQL_OPERATION`

### Frontend
- Delete 15 converter files (`convertGqlView*ToView*`,
`convertView*ToGql`, `convertViewWithRelationsToView`)
- Re-export `ViewType`, `ViewKey`, `ViewFilterGroupLogicalOperator` from
generated enums (no more duplicate enum definitions with different
casing)
- Replace `ViewOpenRecordInType` with `ViewOpenRecordIn` from generated
- Remove `__typename` from all local view sub-types
- Remove unused `variant` from `ViewFilter`, make `displayValue` and
`definition` optional
- Rename ~45 GraphQL query/mutation files and all selectors to drop
"core" prefix
- Delete unused `viewsWithRelationsSelector`
2026-03-16 09:57:18 +01:00

286 lines
8.8 KiB
TypeScript

import { faker } from '@faker-js/faker';
import { createOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata.util';
import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
import { getMockCreateObjectInput } from 'test/integration/metadata/suites/object-metadata/utils/generate-mock-create-object-metadata-input';
import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';
import { findViewGroups } from 'test/integration/metadata/suites/view-group/utils/find-view-groups.util';
import { createOneView } from 'test/integration/metadata/suites/view/utils/create-one-view.util';
import { updateOneView } from 'test/integration/metadata/suites/view/utils/update-one-view.util';
import {
FieldMetadataType,
type EnumFieldMetadataType,
ViewType,
} from 'twenty-shared/types';
import {
type FieldMetadataComplexOption,
type FieldMetadataDefaultOption,
} from 'src/engine/metadata-modules/field-metadata/dtos/options.input';
type Option = FieldMetadataDefaultOption | FieldMetadataComplexOption;
const generateOption = (index: number): Option => ({
label: `Option ${index}`,
value: `OPTION_${index}`,
color: 'green',
position: index,
});
const generateOptions = (length: number) =>
Array.from({ length }, (_value, index) => generateOption(index));
const testFieldMetadataTypes: EnumFieldMetadataType[] = [
FieldMetadataType.SELECT,
FieldMetadataType.MULTI_SELECT,
];
describe('update-one-view-view-groups-side-effect-v2', () => {
let objectMetadataIdToDelete: string;
const createObjectWithTwoSelectFieldsAndKanbanViewAndGroupedTableView =
async (initialOptions: Option[]) => {
const singular = 'viewSideEffect';
const plural = 'viewSideEffects';
const {
data: { createOneObject },
} = await createOneObjectMetadata({
expectToFail: false,
input: getMockCreateObjectInput({
labelSingular: singular,
labelPlural: plural,
nameSingular: singular,
namePlural: plural,
isLabelSyncedWithName: false,
}),
});
objectMetadataIdToDelete = createOneObject.id;
const {
data: { createOneField: createOneStatusField },
} = await createOneFieldMetadata<typeof FieldMetadataType.SELECT>({
expectToFail: false,
input: {
objectMetadataId: createOneObject.id,
type: FieldMetadataType.SELECT,
name: 'statusField',
label: 'Status Field',
isLabelSyncedWithName: true,
options: initialOptions,
},
gqlFields: 'id options',
});
const phaseFieldOptions = generateOptions(2);
const {
data: { createOneField: createOnePhaseField },
} = await createOneFieldMetadata<typeof FieldMetadataType.SELECT>({
expectToFail: false,
input: {
objectMetadataId: createOneObject.id,
type: FieldMetadataType.SELECT,
name: 'phaseField',
label: 'Phase Field',
isLabelSyncedWithName: true,
options: phaseFieldOptions,
},
gqlFields: 'id options',
});
const {
data: { createView: view },
} = await createOneView({
input: {
id: faker.string.uuid(),
icon: 'IconKanban',
name: 'Kanban View',
objectMetadataId: createOneObject.id,
type: ViewType.KANBAN,
mainGroupByFieldMetadataId: createOneStatusField.id,
},
expectToFail: false,
gqlFields: 'id',
});
const {
data: { createView: groupedTableView },
} = await createOneView({
input: {
id: faker.string.uuid(),
icon: 'IconKanban',
name: 'Grouped Table View',
objectMetadataId: createOneObject.id,
type: ViewType.TABLE,
mainGroupByFieldMetadataId: createOneStatusField.id,
},
expectToFail: false,
gqlFields: 'id',
});
return {
objectMetadataId: createOneObject.id,
statusFieldMetadataId: createOneStatusField.id,
phaseFieldMetadataId: createOnePhaseField.id,
statusFieldOptions: createOneStatusField.options ?? [],
viewId: view.id,
groupedTableViewId: groupedTableView.id,
phaseFieldOptions,
};
};
afterEach(async () => {
await updateOneObjectMetadata({
expectToFail: false,
input: {
idToUpdate: objectMetadataIdToDelete,
updatePayload: {
isActive: false,
},
},
});
await deleteOneObjectMetadata({
expectToFail: false,
input: { idToDelete: objectMetadataIdToDelete },
});
});
describe.each(testFieldMetadataTypes)('%s field type', () => {
it('should delete all view groups when mainGroupByFieldMetadataId is removed', async () => {
const initialOptions = generateOptions(3);
const { groupedTableViewId } =
await createObjectWithTwoSelectFieldsAndKanbanViewAndGroupedTableView(
initialOptions,
);
const {
data: { getViewGroups: initialViewGroups },
} = await findViewGroups({
viewId: groupedTableViewId,
gqlFields: 'id fieldValue',
expectToFail: false,
});
expect(initialViewGroups.length).toBe(4);
await updateOneView({
viewId: groupedTableViewId,
input: {
id: groupedTableViewId,
mainGroupByFieldMetadataId: null,
},
gqlFields: 'id mainGroupByFieldMetadataId',
expectToFail: false,
});
const {
data: { getViewGroups: updatedViewGroups },
} = await findViewGroups({
viewId: groupedTableViewId,
gqlFields: 'id fieldValue',
expectToFail: false,
});
expect(updatedViewGroups.length).toBe(0);
});
it('should delete and recreate view groups when mainGroupByFieldMetadataId changes', async () => {
const initialOptions = generateOptions(3);
const { phaseFieldOptions, phaseFieldMetadataId, viewId } =
await createObjectWithTwoSelectFieldsAndKanbanViewAndGroupedTableView(
initialOptions,
);
const {
data: { getViewGroups: initialViewGroups },
} = await findViewGroups({
viewId,
gqlFields: 'id fieldValue',
expectToFail: false,
});
expect(initialViewGroups.length).toBe(initialOptions.length + 1); // null option
await updateOneView({
viewId,
input: {
id: viewId,
mainGroupByFieldMetadataId: phaseFieldMetadataId,
},
gqlFields: 'id mainGroupByFieldMetadataId',
expectToFail: false,
});
const {
data: { getViewGroups: updatedViewGroups },
} = await findViewGroups({
viewId,
gqlFields: 'id fieldValue',
expectToFail: false,
});
expect(updatedViewGroups.length).toBe(phaseFieldOptions.length + 1);
const actualFieldValues = updatedViewGroups
.map((viewGroup) => viewGroup.fieldValue)
.sort();
const expectedFieldValues = [...phaseFieldOptions, { value: '' }]
.map((option) => option.value)
.sort();
expect(actualFieldValues).toEqual(expectedFieldValues);
});
it('should preserve view groups when mainGroupByFieldMetadataId does not change', async () => {
const initialOptions = generateOptions(3);
const { statusFieldOptions, viewId } =
await createObjectWithTwoSelectFieldsAndKanbanViewAndGroupedTableView(
initialOptions,
);
const {
data: { getViewGroups: initialViewGroups },
} = await findViewGroups({
viewId,
gqlFields: 'id fieldValue',
expectToFail: false,
});
expect(initialViewGroups.length).toBe(statusFieldOptions.length + 1);
await updateOneView({
viewId,
input: {
id: viewId,
name: 'Renamed Kanban View',
},
gqlFields: 'id name mainGroupByFieldMetadataId',
expectToFail: false,
});
const {
data: { getViewGroups: updatedViewGroups },
} = await findViewGroups({
viewId,
gqlFields: 'id fieldValue',
expectToFail: false,
});
expect(updatedViewGroups.length).toBe(statusFieldOptions.length + 1);
const actualFieldValues = updatedViewGroups
.map((viewGroup) => viewGroup.fieldValue)
.sort();
const expectedFieldValues = [...statusFieldOptions, { value: '' }]
.map((option) => option.value)
.sort();
expect(actualFieldValues).toEqual(expectedFieldValues);
});
});
});